From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH] char/tpm: Check return code of wait_for_tpm_stat Date: Tue, 11 Oct 2016 11:13:13 -0600 Message-ID: <20161011171313.GD6881@obsidianresearch.com> References: <1476187261-29027-1-git-send-email-jarkko.sakkinen@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1476187261-29027-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jarkko Sakkinen Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, open list List-Id: tpmdd-devel@lists.sourceforge.net On Tue, Oct 11, 2016 at 03:01:01PM +0300, Jarkko Sakkinen wrote: > From: Peter Huewe > > In some weird cases it might be possible that the TPM does not set > STS.VALID within the given timeout time (or ever) but sets STS.EXPECT > (STS=0x0C) In this case the driver gets stuck in the while loop of > tpm_tis_send_data and loops endlessly. Doesn't that exchange mean the TPM has lost synchronization with the driver? Or maybe it crashed executing a command or something.. Please indicate what hardware is broken like this.. Or how did you get it to do this? Jason ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754109AbcJKRNc (ORCPT ); Tue, 11 Oct 2016 13:13:32 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:40389 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754073AbcJKRNa (ORCPT ); Tue, 11 Oct 2016 13:13:30 -0400 Date: Tue, 11 Oct 2016 11:13:13 -0600 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: tpmdd-devel@lists.sourceforge.net, Peter Huewe , Marcel Selhorst , open list Subject: Re: [PATCH] char/tpm: Check return code of wait_for_tpm_stat Message-ID: <20161011171313.GD6881@obsidianresearch.com> References: <1476187261-29027-1-git-send-email-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476187261-29027-1-git-send-email-jarkko.sakkinen@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.151 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 11, 2016 at 03:01:01PM +0300, Jarkko Sakkinen wrote: > From: Peter Huewe > > In some weird cases it might be possible that the TPM does not set > STS.VALID within the given timeout time (or ever) but sets STS.EXPECT > (STS=0x0C) In this case the driver gets stuck in the while loop of > tpm_tis_send_data and loops endlessly. Doesn't that exchange mean the TPM has lost synchronization with the driver? Or maybe it crashed executing a command or something.. Please indicate what hardware is broken like this.. Or how did you get it to do this? Jason