All of lore.kernel.org
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Meelis Roos <mroos@linux.ee>,
	linux-parisc@vger.kernel.org,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	John David Anglin <dave.anglin@bell.net>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: parisc crash on boot with 4.8+git
Date: Tue, 11 Oct 2016 20:40:02 +0200	[thread overview]
Message-ID: <20161011184002.GA1363@p100.box> (raw)
In-Reply-To: <alpine.LRH.2.20.1610101925320.14896@math.ut.ee>

* Meelis Roos <mroos@linux.ee>:
> > > Memory Ranges:
> > >  0) Start 0x0000000000000000 End 0x000000003fffffff Size   1024 MB
> > >  1) Start 0x0000004040000000 End 0x000000407fdfffff Size   1022 MB
> > > Total Memory: 2046 MB

Meelis and myself debugged the crash off-list.
It turns out, that I missed to zero-initialize the new memblocks.
Patch below fixes this.

Helge

------------
parisc: Zero-initialize newly alloced memblock

Commit 4fe9e1d957e4 ("parisc: Drop bootmem and switch to memblock")
switched to the memblock allocator, but missed to zero-initialize the
newly allocated memblocks. This lead to crashes on some machines like
the rp3410.

Fixes: 4fe9e1d957e4 ("parisc: Drop bootmem and switch to memblock")
Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/arch/parisc/mm/init.c b/arch/parisc/mm/init.c
index 356f384..62ac801 100644
--- a/arch/parisc/mm/init.c
+++ b/arch/parisc/mm/init.c
@@ -105,6 +105,8 @@ static void * __init get_memblock(unsigned long size)
 	else
 		panic("get_memblock() failed.\n");
 
+	memset(__va(phys), 0, size);
+
 	return __va(phys);
 }
 

  reply	other threads:[~2016-10-11 18:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-08 21:52 parisc crash on boot with 4.8+git Meelis Roos
2016-10-08 21:07 ` Helge Deller
2016-10-09  9:03   ` Meelis Roos
2016-10-09  9:06     ` Helge Deller
2016-10-09 21:09       ` Meelis Roos
2016-10-09 19:54         ` Helge Deller
2016-10-10  6:04           ` Meelis Roos
2016-10-10 14:47             ` Helge Deller
2016-10-10 16:26               ` Meelis Roos
2016-10-11 18:40                 ` Helge Deller [this message]
2016-10-09 14:01     ` John David Anglin
2016-10-09 21:13       ` Meelis Roos
2016-10-09 19:50         ` Helge Deller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161011184002.GA1363@p100.box \
    --to=deller@gmx.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=dave.anglin@bell.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=mroos@linux.ee \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.