From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH rdma-core 1/5] Pull uninitialized_var into util/compiler.h
Date: Tue, 11 Oct 2016 14:06:12 -0600 [thread overview]
Message-ID: <20161011200612.GA21656@obsidianresearch.com> (raw)
In-Reply-To: <20161011194633.GP9282-2ukJVAZIZ/Y@public.gmane.org>
On Tue, Oct 11, 2016 at 10:46:33PM +0300, Leon Romanovsky wrote:
> But I'm still left under impression of this article [1] that using such
> macro is a bad thing and we are "punishing" all users of modern compilers.
I agree with the article, it is a bad idea. This is why my version is
disabling the macro entirely if gcc 6 or clang is used - aka the
compilers that run in Travis.
So, new code must not introduce control flow that is more complex than
gcc 6 can understand, and the macro is used only for gcc 4.x and 5.x
compatability to provide warning free compile on popular distros
without a performance hit.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-10-11 20:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 22:36 [PATCH rdma-core 0/5] clang support Jason Gunthorpe
[not found] ` <1475879772-29458-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-10-07 22:36 ` [PATCH rdma-core 1/5] Pull uninitialized_var into util/compiler.h Jason Gunthorpe
[not found] ` <1475879772-29458-2-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-10-09 5:46 ` Leon Romanovsky
[not found] ` <20161009054601.GB9282-2ukJVAZIZ/Y@public.gmane.org>
2016-10-09 23:01 ` Jason Gunthorpe
[not found] ` <20161009230150.GB12551-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-10-10 4:09 ` Leon Romanovsky
[not found] ` <20161010040930.GF9282-2ukJVAZIZ/Y@public.gmane.org>
2016-10-11 18:05 ` Jason Gunthorpe
[not found] ` <20161011180517.GA17866-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-10-11 19:46 ` Leon Romanovsky
[not found] ` <20161011194633.GP9282-2ukJVAZIZ/Y@public.gmane.org>
2016-10-11 20:06 ` Jason Gunthorpe [this message]
2016-10-10 15:18 ` Steve Wise
2016-10-07 22:36 ` [PATCH rdma-core 2/5] ibacm: Avoid clang 3.8 warning -Wmissing-field-initializers Jason Gunthorpe
2016-10-07 22:36 ` [PATCH rdma-core 3/5] mthca: Avoid bogus gcc 4.8 warning -Wmaybe-uninitialized Jason Gunthorpe
2016-10-07 22:36 ` [PATCH rdma-core 4/5] Improve linker flag detection to work with clang and -Werror Jason Gunthorpe
2016-10-07 22:36 ` [PATCH rdma-core 5/5] Update TravisCI to use clang 3.9 as well Jason Gunthorpe
2016-10-12 18:07 ` [PATCH rdma-core 0/5] clang support Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161011200612.GA21656@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.