From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zach Brown Subject: Re: [PATCH v4 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace Date: Tue, 11 Oct 2016 16:29:39 -0500 Message-ID: <20161011212938.GA24636@zach-desktop> References: <1476217580-21229-1-git-send-email-zach.brown@ni.com> <1476217580-21229-2-git-send-email-zach.brown@ni.com> <20161011141407.3b233e83@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20161011141407.3b233e83@xeon-e3> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Stephen Hemminger Cc: devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com, f.fainelli@gmail.com, andrew@lunn.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, rpurdie@rpsys.net, gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net, j.anaszewski@samsung.com, linux-leds@vger.kernel.org, mlindner@marvell.com List-Id: linux-leds@vger.kernel.org On Tue, Oct 11, 2016 at 02:14:07PM -0700, Stephen Hemminger wrote: > On Tue, 11 Oct 2016 15:26:18 -0500 > Zach Brown wrote: > > > Adding led support for phy causes namespace conflicts for some > > phy drivers. > > > > The marvel skge driver declared an enum for representing the states of > > Link LED Register. The enum contained constant LED_OFF which conflicted > > with declartation found in linux/leds.h. > > LED_OFF changed to LED_REG_OFF > > Also changed LED_ON to LED_REG_ON to avoid possible future conflict and > > for consistency. > > > > Signed-off-by: Zach Brown > > Sure, that's fine but not sure why skge would be including linux/leds.h > anyway. It's pretty convoluted. Here's the chain of includes. skge -> netdevice -> dsa -> phy -> phy_led_triggers -> leds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932094AbcJKXFy (ORCPT ); Tue, 11 Oct 2016 19:05:54 -0400 Received: from mail-bl2nam02on0127.outbound.protection.outlook.com ([104.47.38.127]:51232 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753367AbcJKXFw (ORCPT ); Tue, 11 Oct 2016 19:05:52 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=zach.brown@ni.com; Date: Tue, 11 Oct 2016 16:29:39 -0500 From: Zach Brown To: Stephen Hemminger CC: , , , , , , , , , , , Subject: Re: [PATCH v4 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace Message-ID: <20161011212938.GA24636@zach-desktop> References: <1476217580-21229-1-git-send-email-zach.brown@ni.com> <1476217580-21229-2-git-send-email-zach.brown@ni.com> <20161011141407.3b233e83@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20161011141407.3b233e83@xeon-e3> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [130.164.62.11] X-ClientProxiedBy: BY1PR15CA0038.namprd15.prod.outlook.com (10.162.17.176) To DM5PR04MB0619.namprd04.prod.outlook.com (10.172.187.9) X-MS-Office365-Filtering-Correlation-Id: 444b52c4-6ddb-4c85-5f4a-08d3f21db9d9 X-Microsoft-Exchange-Diagnostics: 1;DM5PR04MB0619;2:92HJ9Rvw08auXMQbidK38550tH95aRNNhPnMd0t1mRrx/Z6uiYbPWRXpqAsfUOmVpLmRZg1KMLZF3rXgvBrjVtlsDUVMc85eDtyu055rlkTbyPLfqcnrGqIXsZQYE55IQrUVmscOjRKmWZ3SNiTDgJupM54FBhLapllKo/Rte0qlJwLEvVA7CKKeT9cNsBzujmBWRsxJz0MPLfibDj9khw==;3:fDto81dvkcxeTULaO3ugCPFDoUyExog+Pws+dlaXMtvdm6UgaK+f5TfQvvxYOMXUlYMmR+cHe15HlFdsvSz3jhHgeOTXANRC26xopYjewnCLtvfkHBJ6U8ZvmBGPs9BFHyfxGHE7XBXv13puuKUnLw==;25:d0rM5hh5bOZ/7ndxxtSiJ2JbeKDpcj1e21m9WcjRbkMu0uj4qCWnuTZwiDc+Z/1aCVKMSvaI3hDP1DbM/U9PyFYALyVe+rjvMK2BFVnkKDA5OqMNZPa86w57zc/uoQ9ngsbtneH/+0W/vBksNlkSYxD8jbsCa+GI8Hu4K2E6lnxQh977It98JFUwB8AiLzxNT2TCchw0jWnArxnD+k6ULMRtBShpDa8zXgnuvaZzJkDZCGU+2TkveL/Cnd/5i1osDg4CRhGB1Y81h6B9yDuHSk/lPYMdIjwa2oLXe8p4ebi7B/EYBHFpFyoCOVWJhAwlXUoWjzxiY5I16C+hjKHf+fjg7xxyEaFm6cXjbZtwH6FH5eTNtwfRTpGY6OELK0yJ/oKNJsXi2OdZfbmDj/gJkcH8WNOPFNGzLCF0YFwDAS7DpYc0Tx0fyFj3gXCg8NTO X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR04MB0619; X-Microsoft-Exchange-Diagnostics: 1;DM5PR04MB0619;31:ZfIcXki7ndje+TOjCZMO5Y2fCswyZj4hyWfFxSJxi1QKFKP9vszQ2OjlRmQsoI21H1LogXFJV4BAuoVdQXPKgy0UpYVxUmnu7mav6jgiiQMHTfVXG8X9qiL7bHw1Lb/B28GM45Q1m8LyMeuZBy0k/ix0HIu1D4tuZ7U0hmc+N+ms9vdO8HqieEs/Fs0MPrGDxVWIxtBV//6327Jx5TMsv+bXsodXJAcxLcFqWYYIdE6WZK4/x6r9/lBr70DRvHGFw0YgNiICaxbU6up7Fu6YiA==;20:klJVhF01WlftcBldSYZzNhxQ+O6k0mhNZcYN3TnwAKVxej8znoG4FJuP4SIY8YTRv4qbkQPQ3fryfSrOPrly7CU0pKRo6xw+viYkcjaOx0/49wVw8N75MFcPsE6EQbXEwbReR+yaE884qALCb8pEKsL6/8DfW9ihZIZSl1/Un+qpiuTuYcEZjlabWBB5lw4+wf8nJd5pTJKLrWMltPbEhJ0xGh0Jpl2ihTuGaCB377F+31bkx/5cyK0CO+vjo131NyS//cJZ7qDK4hh1PxXPp0h9DscC0warxnSdQ9TtqIiquHsH1R+DG1BMp4/nzPmm/ZnEfjmsQ6F6SGiMDN7a265aHHZ0GktKn8yv4rO30CK72F+5knoMgZRxWzR4qhU6cs6HmEXwU23vGdnAb8HtpAYE1ufCnA+O6+OMjQGmy7gipJ1wvxgRT8E5BJ68K/6/VwDUf2XNEuapb9EJ+TMj8axi8+sG+GaDNl1gtGOmvSgESOcLw+Fa1/fGyMEXS4opNahnXojkfdpZ9WsbfFuYbuT4RiiRSMiTM/zWMj0PSWXJ/N9AhBuGmQncZq4j1nROGF8vENDaKmM64zBk1tBzwktt5SfSs3NREiGUvH4VZfo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(145744241990776); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:DM5PR04MB0619;BCL:0;PCL:0;RULEID:;SRVR:DM5PR04MB0619; X-Microsoft-Exchange-Diagnostics: 1;DM5PR04MB0619;4:5BgNN+6qT21DzOgrmD1jL/Vt3D7svogeOe2bwWD1VQ7N+KI32Q2cRLoIeLe1PA2kniFJ7btC0Y2W8Q82JVPpPIBlKdG5RRTddOH7DPi9JaCsCryH9zRV5QTlF8wrYYLIuGhIm9tW4dXdthag8t7fRiAYrQMdhVu64ghxiMoKZBykmYoiUL54IMffcbq/Y7ZvxNpPsWryXmZZR9CFA4ry/vJOk799r2dZPxshEAggtJbCURMkAhUdYMa1wBtU5dGRL3CYrImzABO6sm6T3yRMOxgoQqxdlxeIIARtJItV3hH1DO5rRybOyh7lGCmOAn8oA6VNB1+4CKEX4NCmBnl5CVObnkPVqfUTLLEA6+++Ip6O/5R53Uh5e4/xCPJTH45YqyEST79xKRHugVT74bdjQ/dOVWrSGfNw+kMKKKvE1JRNLfDQBxpp3KCB0gOrVJL3D4kJiIGEhLKBVw3oStZNbQ== X-Forefront-PRVS: 00922518D8 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(199003)(189002)(24454002)(77096005)(76176999)(54356999)(2950100002)(7846002)(46406003)(101416001)(19580395003)(5660300001)(33656002)(66066001)(47776003)(50986999)(68736007)(19580405001)(83506001)(92566002)(2906002)(9686002)(97756001)(97736004)(86362001)(106356001)(4326007)(1076002)(6116002)(3846002)(4001350100001)(23726003)(42186005)(7736002)(189998001)(6666003)(7416002)(6916009)(50466002)(81166006)(110136003)(81156014)(305945005)(586003)(8676002)(33716001)(105586002)(18370500001)(107986001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR04MB0619;H:zach-desktop;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM5PR04MB0619;23:yQ5Qk7FmiSnsViQtSBUPWc3R10O1sdhn8ZBq1WeXU?= =?us-ascii?Q?KYCU3fHERfq/cxAcapquznM5MTM/ptJeiFhrA53C8idExl4ACA7vi9+laqrb?= =?us-ascii?Q?zXDe5IZzzIGznShKShdhbrEmqnHrcSjOzbOSI0nwYGmdnYcGqEiq8CZp8ylY?= =?us-ascii?Q?XiOiGqTw1jefWhoxBwkEFW9CrO7buzMUIqOkMlldZ1zmC5MYnz2wUdSP4pfi?= =?us-ascii?Q?0/zWm6KGGa0aPOZ7Y6SRb/jWE7a3GSPapaQZ55u2eOW1nN4U22t2Yy5J/6MA?= =?us-ascii?Q?ne3ua5ZTFDrTJBo+FLJQgpfcsOAeuHOnfciMLSnm7inUtM0gz/L1hqEBIBsS?= =?us-ascii?Q?/Nr9gDVv/J83WGgHu/SdOMGmTzEx5RRSIPicgb8JdfWPJQPRNitFrqFjljG2?= =?us-ascii?Q?eNMddPHS6DBmQW+3LYA0ixhNHUlG9HyfZT8tkSC6fVQwjePq5RryUQKdbGjy?= =?us-ascii?Q?bVLxs9RvjqLp6OhapdE1xZm8iX9fGDN2W0soaWqR5f8GEveQS/kTJSQrKmm0?= =?us-ascii?Q?xDpbnVO18j2t06iAMCiegE4+ejD5okIyv++KScOt2oD33tWiXGh7Xc3YqmUn?= =?us-ascii?Q?FQYe6km6YernffC+HcKSy0MEs0ZUIPTlDfx7jipoQdu43OMcUzQB0bLYcjtU?= =?us-ascii?Q?GVBygg8QH8KHI5tIAq6LWqLeOyGvBldUdWPjgh1OmZWKunXGBOKyz365WPOc?= =?us-ascii?Q?fBSNFlhw1Rix/vdVjGAwEjkhcEgYbXAMvIEu5ZU5srs+IIzmZ49u3vmOKqQa?= =?us-ascii?Q?dhPpndrkM/OVwx1AbXL75WakExKkki+Mi3RcGn/t5L3c50VrY+RQRvVCa75e?= =?us-ascii?Q?JvG9yu6oxCsC2sW2Pi6qLuGzOnCvkf9P0nIiyH+WtsUApgsrHj1B+hhwNye0?= =?us-ascii?Q?p1Nm9cG7+DTbKUvgYxpmf+mOmJWC7nV5SBfFv3ne73sPbUBwhbZ2m2920LT2?= =?us-ascii?Q?zB/XJi07Eyrxl8OrOlNDywmkG5A5wUNawZXcsONACgXT43JQ0PDYfc3iOoFt?= =?us-ascii?Q?shtiz3n3R9lWncftGL4jGFscyLbQG60fy8m1BL3/xGttRnmgaA+o4sq1lWfh?= =?us-ascii?Q?A5TPrDhiEEIJYB5FOeIzCYYG18GE1ypznHlyCrygXc8Ci/NE02NkSEUIAgVY?= =?us-ascii?Q?sjPfk1AEFvOEiFPBvL+oB84sQaX/msa+Q9cCsVHbBXdshTeSziddN+bbDsJU?= =?us-ascii?Q?YZeGyvAy0gPC7xeEjLHPGD4bYGyiiJrEQ6H7RzrEckNIn9hy4K6AMUO5YSim?= =?us-ascii?Q?EtN9EFdhoOyayNb7PM=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR04MB0619;6:SvTgL1z0aCQUJ5VooDGTnm94OgumWCT5s8I5Oqa3XCS6vJMsY+ky1+b5zy9tMjQbci/krwxkwlrMHE/aO4RXzxnVjPgG/KAeqXTKweXl4QpDv1ROpBVKB2v48qiIYtjDoVocrnTVUnVQCAM366hYp13NYoQNxSJmsh6agIe6XKUMBvYavb4X+6QU2arcViKao9PjNTM0icNwhBv15BsIlC/X4Y/vl7R+3r8F02jvUwhcfhxvYS5VZeQWUXSDNcWEAXKpettk3ViUEku1EJk4+udeUPWtJwfGOVRsvZYYWiwlsnCZnCMpBjkCpAtUWKLK;5:XMmT1Pvvr2K0vKNjXq3FzEV0ejEjhmNwx8VjeE1ApapJJ2RupEh50qS4gzxoGcFZEOtmxVYWB67ofqqVtCfN6k5qJYE4ECu3W/LwEM4rKd6gqfbLt6FaK8nTSB6gqSHB9WN5601jpRsGxWIfjmAkGq8KPVx1z7tPGldp5NpSu8c=;24:FgUmomUV/l8s9UczpPKVltdc17/axV7D2KujSvDvL5mgiQxTh0gmB44cJPWY12qISE3SkQ71Jy6foo0q04E1sUCDXXfyfvgCb84KrC6nics=;7:J4T3eW8wPwmmXLA8E7CbTAJ9KPxgkMh2pYEAc0J2Fmif7BqQnI0ZUr5jYKsrXjf0fvX5wkciYWL4PpCWVHlN15Up+xd1rDbcIcXhsRoGGRPNLaGcORLRzdftPQwcMEBXuouewx6zkIg2YETo3JEjA0aF1ykZjzr7Hl+2sYfTleJUxns37PjA2OTXwoBsZaIB02+ONepUG1YNaTGZBRuygdq0FAd1A/PLxyAatiN13J6Mj8VUh2FzR1oWmldcjsu4uZBA2lrMGGFv4fHPuDx18gn8Kc2eDp8pBJmIBpmA4ffpdQ6wGlckTP5G1j11E7jpfvRXvs22sKR5WMmz7vMZ/0lJAKQ8cNfIShHI2dTlhV8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: ni.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2016 21:29:46.1624 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB0619 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 11, 2016 at 02:14:07PM -0700, Stephen Hemminger wrote: > On Tue, 11 Oct 2016 15:26:18 -0500 > Zach Brown wrote: > > > Adding led support for phy causes namespace conflicts for some > > phy drivers. > > > > The marvel skge driver declared an enum for representing the states of > > Link LED Register. The enum contained constant LED_OFF which conflicted > > with declartation found in linux/leds.h. > > LED_OFF changed to LED_REG_OFF > > Also changed LED_ON to LED_REG_ON to avoid possible future conflict and > > for consistency. > > > > Signed-off-by: Zach Brown > > Sure, that's fine but not sure why skge would be including linux/leds.h > anyway. It's pretty convoluted. Here's the chain of includes. skge -> netdevice -> dsa -> phy -> phy_led_triggers -> leds