All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] qed: Add RoCE ll2 & GSI support
Date: Wed, 12 Oct 2016 06:16:30 +0000	[thread overview]
Message-ID: <20161012061629.GO12841@mwanda> (raw)

Hello Ram Amrani,

This is a semi-automatic email about new static checker warnings.

The patch abd49676c707: "qed: Add RoCE ll2 & GSI support" from Oct 1, 
2016, leads to the following Smatch complaint:

drivers/net/ethernet/qlogic/qed/qed_roce.c:2853 qed_roce_ll2_tx()
	 warn: variable dereferenced before check 'cdev' (see line 2846)

drivers/net/ethernet/qlogic/qed/qed_roce.c
  2845	{
  2846		struct qed_hwfn *hwfn = QED_LEADING_HWFN(cdev);
                                                         ^^^^
  2847		struct qed_roce_ll2_info *roce_ll2 = hwfn->ll2;
                                                     ^^^^^^^^^
  2848		enum qed_ll2_roce_flavor_type qed_roce_flavor;
  2849		u8 flags = 0;
  2850		int rc;
  2851		int i;
  2852	
  2853		if (!cdev || !pkt || !params) {
                     ^^^^

This one also.

  2854			DP_ERR(cdev,
  2855			       "roce ll2 tx: failed tx because one of the following is NULL - drv=%p, pkt=%p, params=%p\n",

regards,
dan carpenter

             reply	other threads:[~2016-10-12  6:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-12  6:16 Dan Carpenter [this message]
2016-10-13  6:57 ` [bug report] qed: Add RoCE ll2 & GSI support Amrani, Ram

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161012061629.GO12841@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.