From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH]"drm: change DRM_MIPI_DSI module type from "bool" to "tristate". Date: Wed, 12 Oct 2016 08:51:36 +0200 Message-ID: <20161012065136.GH20761@phenom.ffwll.local> References: <87h98ktxow.fsf@intel.com> <87lgxvqlg3.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B0C06E2B4 for ; Wed, 12 Oct 2016 06:51:41 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id b80so879500wme.3 for ; Tue, 11 Oct 2016 23:51:41 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Sun, Jing A" Cc: Emil Velikov , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "Vetter, Daniel" , Thierry Reding List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBPY3QgMTIsIDIwMTYgYXQgMDM6MDg6MjRBTSArMDAwMCwgU3VuLCBKaW5nIEEgd3Jv dGU6Cj4gSW50ZXJlc3RpbmdseSwgSSBhbSBhYmxlIHRvIHJlbG9hZCBpOTE1IGFuZCBkcm0uIE91 ciBDSSBoYXMgdGVzdHMgZm9yCj4gaTkxNSB1bmxvYWQvcmVsb2FkLCBidXQgZG9lcyBub3QgY2hl Y2sgZHJtLiBJbiBhbnkgY2FzZSB0aGUgY29uZmlnCj4gcHJvYmxlbSBzaG91bGQgbm90IGltcGFj dCB0aGUgcmVsb2FkYWJpbGl0eSBvZiBpOTE1Lgo+ID09PT09PQo+IFNvcnJ5IHRoYXQgSSBkaWRu J3QgbWFrZSBteXNlbGYgY2xlYXIuIEluIG9yZGVyIHRvIHJlcGxhY2UgdGhlIGRlZmF1bHQKPiBp OTE1IG1vZHVsZSB3aXRoIGFuIHVwZGF0ZWQgb25lLCB0aGUgcmVsYXRlZCBEUk0gbW9kdWxlcyBh bHNvIG5lZWQgdG8gYmUKPiB1cGRhdGVkIHRvIG1hdGNoIHRoZSB1cGRhdGVkIGk5MTUsIGhlbmNl IHRoZSByZXN0cmljdGlvbi4KCkp1c3QgdG8gYXZvaWQgdGVhcnMgaW4gdGhlIGZ1dHVyZTogSWYg eW91IHBsYW4gdG8gc2hpcCB0aGlzIGluIHByb2R1Y3QsCnlvdSB3b24ndCBzaGlwLgoKQW5kIGZv ciBkZWJ1Z2dpbmcsIGp1c3QgaW5zdGFsbCBhIGtlcm5lbCB3aXRoIHlvdXIgY2hhbmdlcyBmb3Ig Ym90aCBkcm0KYW5kIGk5MTUuCgpJbiBzaG9ydCwgeW91ciB1c2UtY2FzZSBpc24ndCByZWFsbHkg dmFsaWQgKGJ1dCB3ZSBjb3VsZCBzdGlsbCBtYWtlIHRoZQpkc2kgY29kZSBtb2R1bGFyIGlmIHBl b3BsZSBmZWVsIGxpa2UpLgotRGFuaWVsCgo+IAo+IFJlZ2FyZHMsCj4gU3VuLCBKaW5nCj4gCj4g Cj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiBGcm9tOiBBbmRyemVqIEhhamRhIFttYWls dG86YS5oYWpkYUBzYW1zdW5nLmNvbV0gCj4gU2VudDogVHVlc2RheSwgT2N0b2JlciAxMSwgMjAx NiA1OjUzIFBNCj4gVG86IEphbmkgTmlrdWxhOyBTdW4sIEppbmcgQTsgVGFrYXNoaSBJd2FpCj4g Q2M6IGFpcmxpZWRAbGludXguaWU7IFZldHRlciwgRGFuaWVsOyBsaW51eC1rZXJuZWxAdmdlci5r ZXJuZWwub3JnOyBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnOyBUaGllcnJ5IFJlZGlu ZzsgRW1pbCBWZWxpa292Cj4gU3ViamVjdDogUmU6IFtQQVRDSF0iZHJtOiBjaGFuZ2UgRFJNX01J UElfRFNJIG1vZHVsZSB0eXBlIGZyb20gImJvb2wiIHRvICJ0cmlzdGF0ZSIuCj4gCj4gT24gMTEu MTAuMjAxNiAxMTozMywgSmFuaSBOaWt1bGEgd3JvdGU6Cj4gPiBPbiBUdWUsIDExIE9jdCAyMDE2 LCAiU3VuLCBKaW5nIEEiIDxqaW5nLmEuc3VuQGludGVsLmNvbT4gd3JvdGU6Cj4gPj4gSXQncyBu ZWVkZWQgdGhhdCBEUk0gRHJpdmVyIG1vZHVsZSBjb3VsZCBiZSByZW1vdmVkIGFuZCByZWxvYWRl ZCAKPiA+PiBhZnRlciBrZXJuZWwgYm9vdGluZyBvbiB0aGUgcHJvamVjdHMgdGhhdCBJIGhhdmUg YmVlbiB3b3JraW5nIG9uLCBhbmQgCj4gPj4gSSBob3BlIHN1Y2ggbW9kdWxlIHR5cGUgY2hhbmdl IGNvdWxkIGJlIGFjY2VwdGVkLiBMb29rcyBsaWtlIEl3YWkgaGFzIAo+ID4+IHNpbWlsYXIgY2hh bmdlIHJlcXVlc3QgYXMgd2VsbC4gV291bGQgeW91IHBsZWFzZSByZXZpZXcgaXQgYW5kIGxldCB1 cyAKPiA+PiBrbm93IGlmIGFueSBjb25jZXJucz8KPiA+IExvb2tpbmcgYXQgdGhlIEtjb25maWcs IHNlbGVjdGluZyBDT05GSUdfRFJNX01JUElfRFNJIGlzIGFnYWluc3QgdGhlIAo+ID4gcmVjb21t ZW5kYXRpb25zIG9mIERvY3VtZW50YXRpb24va2J1aWxkL2tjb25maWctbGFuZ3VhZ2UudHh0Ogo+ ID4KPiA+IAlzZWxlY3Qgc2hvdWxkIGJlIHVzZWQgd2l0aCBjYXJlLiBzZWxlY3Qgd2lsbCBmb3Jj ZQo+ID4gCWEgc3ltYm9sIHRvIGEgdmFsdWUgd2l0aG91dCB2aXNpdGluZyB0aGUgZGVwZW5kZW5j aWVzLgo+ID4gCUJ5IGFidXNpbmcgc2VsZWN0IHlvdSBhcmUgYWJsZSB0byBzZWxlY3QgYSBzeW1i b2wgRk9PIGV2ZW4KPiA+IAlpZiBGT08gZGVwZW5kcyBvbiBCQVIgdGhhdCBpcyBub3Qgc2V0Lgo+ ID4gCUluIGdlbmVyYWwgdXNlIHNlbGVjdCBvbmx5IGZvciBub24tdmlzaWJsZSBzeW1ib2xzCj4g PiAJKG5vIHByb21wdHMgYW55d2hlcmUpIGFuZCBmb3Igc3ltYm9scyB3aXRoIG5vIGRlcGVuZGVu Y2llcy4KPiA+IAlUaGF0IHdpbGwgbGltaXQgdGhlIHVzZWZ1bG5lc3MgYnV0IG9uIHRoZSBvdGhl ciBoYW5kIGF2b2lkCj4gPiAJdGhlIGlsbGVnYWwgY29uZmlndXJhdGlvbnMgYWxsIG92ZXIuCj4g Cj4gQWxsIGV4aXN0aW5nIGRyaXZlcnMgd2hpY2ggc2VsZWN0cyBEUk1fTUlQSV9EU0kgYWxzbyBk ZXBlbmRzIG9uIERSTS4KPiBTbyB0aGUgZGVwZW5kZW5jeSBpcyBhbHdheXMgdHJ1ZS4gSSBhbSBu b3Qgc3VyZSBpZiBpdCBjb3VsZCBub3QgY2hhbmdlIGluIHRoZSBmdXR1cmUsIGJ1dCBpbiBzdWNo IGNhc2UgbWlwaV9kc2kgYnVzIHNob3VsZCBiZSBjb21wbGV0ZWx5IGRldGFjaGVkIGZyb20gRFJN IGZyYW1ld29yaywgSSBob3BlIHdlIGhhdmUgbm90IHN1Y2ggY2FzZSB5ZXQgOikKPiAKPiA+Cj4g PiBJbmRlZWQsIHlvdSBtYXkgZW5kIHVwIHdpdGggQ09ORklHX0RSTV9NSVBJX0RTST15IGFuZCBD T05GSUdfRFJNPW0sIAo+ID4gd2hpY2ggdmlvbGF0ZXMgRFJNX01JUElfRFNJIGRlcGVuZGVuY3kg b24gQ09ORklHX0RSTS4gVGhpcyBpcyBicm9rZW4gCj4gPiBhbmQgc2hvdWxkIGJlIGZpeGVkLiBU aGUgc3VnZ2VzdGVkIHBhdGNoIGRvZXMgKm5vdCogZml4IHRoaXMgaXNzdWUuCj4gCj4gQXQgdGhl IG1vbWVudCBpdCBzaG91bGQgbm90IGJlIHBvc3NpYmxlLgo+IAo+IFJlZ2FyZHMKPiBBbmRyemVq Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBk cmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24K aHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753809AbcJLGvs (ORCPT ); Wed, 12 Oct 2016 02:51:48 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33591 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752026AbcJLGvl (ORCPT ); Wed, 12 Oct 2016 02:51:41 -0400 Date: Wed, 12 Oct 2016 08:51:36 +0200 From: Daniel Vetter To: "Sun, Jing A" Cc: Andrzej Hajda , Jani Nikula , Takashi Iwai , Emil Velikov , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "Vetter, Daniel" , Thierry Reding Subject: Re: [PATCH]"drm: change DRM_MIPI_DSI module type from "bool" to "tristate". Message-ID: <20161012065136.GH20761@phenom.ffwll.local> Mail-Followup-To: "Sun, Jing A" , Andrzej Hajda , Jani Nikula , Takashi Iwai , Emil Velikov , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "Vetter, Daniel" , Thierry Reding References: <87h98ktxow.fsf@intel.com> <87lgxvqlg3.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 4.6.0-1-amd64 User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 12, 2016 at 03:08:24AM +0000, Sun, Jing A wrote: > Interestingly, I am able to reload i915 and drm. Our CI has tests for > i915 unload/reload, but does not check drm. In any case the config > problem should not impact the reloadability of i915. > ====== > Sorry that I didn't make myself clear. In order to replace the default > i915 module with an updated one, the related DRM modules also need to be > updated to match the updated i915, hence the restriction. Just to avoid tears in the future: If you plan to ship this in product, you won't ship. And for debugging, just install a kernel with your changes for both drm and i915. In short, your use-case isn't really valid (but we could still make the dsi code modular if people feel like). -Daniel > > Regards, > Sun, Jing > > > -----Original Message----- > From: Andrzej Hajda [mailto:a.hajda@samsung.com] > Sent: Tuesday, October 11, 2016 5:53 PM > To: Jani Nikula; Sun, Jing A; Takashi Iwai > Cc: airlied@linux.ie; Vetter, Daniel; linux-kernel@vger.kernel.org; dri-devel@lists.freedesktop.org; Thierry Reding; Emil Velikov > Subject: Re: [PATCH]"drm: change DRM_MIPI_DSI module type from "bool" to "tristate". > > On 11.10.2016 11:33, Jani Nikula wrote: > > On Tue, 11 Oct 2016, "Sun, Jing A" wrote: > >> It's needed that DRM Driver module could be removed and reloaded > >> after kernel booting on the projects that I have been working on, and > >> I hope such module type change could be accepted. Looks like Iwai has > >> similar change request as well. Would you please review it and let us > >> know if any concerns? > > Looking at the Kconfig, selecting CONFIG_DRM_MIPI_DSI is against the > > recommendations of Documentation/kbuild/kconfig-language.txt: > > > > select should be used with care. select will force > > a symbol to a value without visiting the dependencies. > > By abusing select you are able to select a symbol FOO even > > if FOO depends on BAR that is not set. > > In general use select only for non-visible symbols > > (no prompts anywhere) and for symbols with no dependencies. > > That will limit the usefulness but on the other hand avoid > > the illegal configurations all over. > > All existing drivers which selects DRM_MIPI_DSI also depends on DRM. > So the dependency is always true. I am not sure if it could not change in the future, but in such case mipi_dsi bus should be completely detached from DRM framework, I hope we have not such case yet :) > > > > > Indeed, you may end up with CONFIG_DRM_MIPI_DSI=y and CONFIG_DRM=m, > > which violates DRM_MIPI_DSI dependency on CONFIG_DRM. This is broken > > and should be fixed. The suggested patch does *not* fix this issue. > > At the moment it should not be possible. > > Regards > Andrzej > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch