From: Cyrill Gorcunov <gorcunov@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, jhs@mojatatu.com,
dsa@cumulusnetworks.com, linux-kernel@vger.kernel.org,
kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, avagin@openvz.org, stephen@networkplumber.org
Subject: Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets
Date: Wed, 12 Oct 2016 09:53:29 +0300 [thread overview]
Message-ID: <20161012065329.GH1941@uranus.lan> (raw)
In-Reply-To: <20161012.015022.2273537782016406180.davem@davemloft.net>
On Wed, Oct 12, 2016 at 01:50:22AM -0400, David Miller wrote:
>
> Macros that look like function calls and are also lvalues tend to be
> troublesome.
>
> I know what you're trying to achieve, you want a named way to access
> this so that the intent and semantics are clear.
>
> But I'd rather you do something that provides a way by which normal
> struct member accesses do the job, and your earlier patches achieved
> this.
I can't rename the field, neither a can use union. The only acceptable
option I think is introduce inet_diag_v3 structure, which of course
will require the mode wide patching. If there no objections I could
try to implement it.
next prev parent reply other threads:[~2016-10-12 6:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 10:00 [PATCH v6] net: ip, diag -- Add diag interface for raw sockets Cyrill Gorcunov
2016-10-12 5:50 ` David Miller
2016-10-12 6:53 ` Cyrill Gorcunov [this message]
2016-10-12 23:55 ` David Miller
2016-10-13 7:16 ` Cyrill Gorcunov
2016-10-13 15:43 ` David Ahern
2016-10-13 15:58 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012065329.GH1941@uranus.lan \
--to=gorcunov@gmail.com \
--cc=avagin@openvz.org \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.