From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60744) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buFBK-0006mh-VU for qemu-devel@nongnu.org; Wed, 12 Oct 2016 04:46:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buFBH-0001eh-OG for qemu-devel@nongnu.org; Wed, 12 Oct 2016 04:46:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57286) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buFBH-0001eZ-I8 for qemu-devel@nongnu.org; Wed, 12 Oct 2016 04:46:31 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0DA58C056792 for ; Wed, 12 Oct 2016 08:46:31 +0000 (UTC) Date: Wed, 12 Oct 2016 09:46:27 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20161012084626.GA2031@work-vm> References: <20161011174121.815-1-marcandre.lureau@redhat.com> <87a8ea693q.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <87a8ea693q.fsf@dusky.pond.sub.org> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCHv2] monitor: deprecate 'default' option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , qemu-devel@nongnu.org, Paolo Bonzini * Markus Armbruster (armbru@redhat.com) wrote: > Marc-Andr=E9 Lureau writes: >=20 > > This option does nothing since commit 06ac27f. Deprecate it. > > > > Signed-off-by: Marc-Andr=E9 Lureau > > --- > > vl.c | 11 +++-------- > > include/monitor/monitor.h | 2 +- > > qemu-options.hx | 8 ++++---- > > 3 files changed, 8 insertions(+), 13 deletions(-) > > > > v2: > > - update after Markus review > > - fix error on default monitor > > - drop from qemu-trivial >=20 > Suggest to squash in the appended patch. >=20 > Reviewed-by: Markus Armbruster >=20 > Could go via David, Paolo or myself. David, do you have anything > pending right now? I don't have anything pending at the moment; but I could take it; it doesn't seem especially urgent. Dave >=20 >=20 > diff --git a/monitor.c b/monitor.c > index b07f254..ab9e911 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -4093,7 +4093,7 @@ QemuOptsList qemu_mon_opts =3D { > .name =3D "chardev", > .type =3D QEMU_OPT_STRING, > },{ > - .name =3D "default", > + .name =3D "default", /* deprecated */ > .type =3D QEMU_OPT_BOOL, > },{ > .name =3D "pretty", -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK