Re: [PATCH] genericx86-common.inc: add dependency do_image_wic -> do_bootimg

[Ed Bartosh <ed.bartosh@linux.intel.com>]

On Mon, Oct 10, 2016 at 12:07:10PM -0700, Christopher Larson wrote:
> On Mon, Oct 10, 2016 at 7:43 AM, Ed Bartosh <ed.bartosh@linux.intel.com>
> wrote:
> 
> > do_image_wic depends on do_bootimg on genericx86 machines as it
> > copies files from hddimg/EFI/BOOT directory to boot partition.
> >
> > Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> >
> 
> Thoughts on adding
> https://github.com/MentorEmbedded/meta-mentor/blob/master/meta-mentor-staging/classes/bootimg-wic.bbclass
> to
> image.bbclass? I think we can assume the existence of do_bootimg means we
> should depend on it, as the class was inherited.

Thank you for the idea! I was looking for something like that.

BTW, even adding dependency without checking anything would work:
 do_image_wic[file-checksums] += "${WKS_FILE_CHECKSUM}"
+do_image_wic[recrdeptask] += "do_bootimg"

but it's too implicit. Your suggestion is much better.

I'll send a patch soon.

--
Regards,
Ed