All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: eric@anholt.net
Cc: dri-devel@lists.freedesktop.org
Subject: [bug report] drm/vc4: Add support for drawing 3D frames.
Date: Wed, 12 Oct 2016 20:34:37 +0300	[thread overview]
Message-ID: <20161012133115.GA8539@mwanda> (raw)

Hello Eric Anholt,

The patch d5b1a78a772f: "drm/vc4: Add support for drawing 3D frames."
from Nov 30, 2015, leads to the following static checker warning:

	drivers/gpu/drm/vc4/vc4_gem.c:797 vc4_wait_for_seqno_ioctl_helper()
	warn: ret is never (-4)

drivers/gpu/drm/vc4/vc4_gem.c
   790  static int
   791  vc4_wait_for_seqno_ioctl_helper(struct drm_device *dev,
   792                                  uint64_t seqno,
   793                                  uint64_t *timeout_ns)
   794  {
   795          unsigned long start = jiffies;
   796          int ret = vc4_wait_for_seqno(dev, seqno, *timeout_ns, true);
   797  
   798          if ((ret == -EINTR || ret == -ERESTARTSYS) && *timeout_ns != ~0ull) {
                     ^^^^^^^^^^^^^
Presumably this could be removed?

   799                  uint64_t delta = jiffies_to_nsecs(jiffies - start);
   800  
   801                  if (*timeout_ns >= delta)
   802                          *timeout_ns -= delta;
   803          }
   804  
   805          return ret;
   806  }


regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2016-10-12 17:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-12 17:34 Dan Carpenter [this message]
2016-10-13  4:14 ` [bug report] drm/vc4: Add support for drawing 3D frames Eric Anholt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161012133115.GA8539@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.