From: Wei Liu <wei.liu2@citrix.com>
To: George Dunlap <george.dunlap@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
AndrewCooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
philippe.gabriel@citrix.com, Jan Beulich <JBeulich@suse.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3] gcov: add new interface and 3.4 and 4.7 format support
Date: Wed, 12 Oct 2016 14:31:31 +0100 [thread overview]
Message-ID: <20161012133131.GO3687@citrix.com> (raw)
In-Reply-To: <91e9a42b-f444-735f-759f-6abb7eaa1b89@citrix.com>
On Wed, Oct 12, 2016 at 02:26:26PM +0100, George Dunlap wrote:
[...]
> >>
> >> There is a version field in gcov_info, so we can compare that and reject
> >> incompatible version.
> >>
> >> We need to use hooks in livepatching to call the constructor /
> >> destructor when applying / reverting a live-patch. We might need to be
> >> cautious about locks or whatever, but I'm sure it can be figured out.
> >>
> >> But I have no idea how useful it would be to use gcov and livepatching
> >> together. For now the easiest thing to do is to
> >>
> >> depends on !LIVEPATCH
> >>
> >> in Kconfig.
> >
> > Wouldn't it be just as easy, and more useful, to set a "has been
> > livepatched" flag, and return errors for all gcov hypercalls if its' set?
> >
> > I would expect most users to want to build a single hypervisor that can
> > be used for both gcov testing and live patching (under different
> > circumstances).
>
> I mean software provider, not user, of course. That's what I would want
> for CentOS, and I'm sure that's what the XenServer (and probably Oracle)
> guys want as well.
>
The usefulness of such build is not as big as you might think I'm
afraid -- it wouldn't be useful until we figure out how to apply a
livepatch generated with gcov support built in.
Wei.
> -George
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-10-12 13:32 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 9:40 [PATCH v2 0/9] Rework gcov support in Xen Wei Liu
2016-10-10 9:40 ` [PATCH v2 1/9] Kconfig: use tab instead of space Wei Liu
2016-10-10 11:21 ` Jan Beulich
2016-10-10 9:40 ` [PATCH v2 2/9] Kconfig: add BROKEN config Wei Liu
2016-10-10 11:22 ` Jan Beulich
2016-10-10 9:40 ` [PATCH v2 3/9] xen: delete gcno files in clean target Wei Liu
2016-10-10 11:23 ` Jan Beulich
2016-10-10 9:40 ` [PATCH v2 4/9] xen, tools: rip out old gcov implementation Wei Liu
2016-10-10 11:24 ` Jan Beulich
2016-10-10 9:40 ` [PATCH v2 5/9] gcov: add new interface and 3.4 and 4.7 format support Wei Liu
2016-10-10 11:56 ` Jan Beulich
2016-10-10 12:23 ` Andrew Cooper
2016-10-10 12:56 ` Jan Beulich
2016-10-10 13:12 ` Wei Liu
2016-10-10 13:11 ` Wei Liu
2016-10-10 14:43 ` Wei Liu
2016-10-11 10:31 ` [PATCH v3] " Wei Liu
2016-10-12 12:42 ` Jan Beulich
2016-10-12 13:06 ` Wei Liu
2016-10-12 13:11 ` Jan Beulich
2016-10-12 13:24 ` George Dunlap
2016-10-12 13:26 ` George Dunlap
2016-10-12 13:31 ` Wei Liu [this message]
2016-10-12 13:33 ` Jan Beulich
2016-10-12 13:34 ` Andrew Cooper
2016-10-12 13:41 ` George Dunlap
2016-10-12 13:43 ` Andrew Cooper
2016-10-12 13:29 ` Konrad Rzeszutek Wilk
2016-10-12 13:40 ` Wei Liu
2016-10-12 13:46 ` Konrad Rzeszutek Wilk
2016-10-12 13:50 ` Wei Liu
2016-10-12 13:23 ` Konrad Rzeszutek Wilk
2016-10-12 13:31 ` Jan Beulich
2016-10-12 13:44 ` Konrad Rzeszutek Wilk
2016-10-12 14:08 ` Jan Beulich
2016-10-12 14:17 ` Martin Pohlack
2016-10-12 16:21 ` Konrad Rzeszutek Wilk
2016-10-13 8:05 ` Martin Pohlack
2016-10-12 15:33 ` Wei Liu
2016-10-12 15:42 ` Jan Beulich
2016-10-12 17:07 ` Wei Liu
2016-10-13 8:29 ` Jan Beulich
2016-10-13 8:49 ` Wei Liu
2016-10-13 9:15 ` Jan Beulich
2016-10-13 9:20 ` Wei Liu
2016-10-10 9:40 ` [PATCH v2 6/9] gcov: userspace tools to extract and split gcov data Wei Liu
2016-10-10 15:44 ` Ian Jackson
2016-10-10 9:40 ` [PATCH v2 7/9] Config.mk: expand cc-ver a bit Wei Liu
2016-10-10 11:57 ` Jan Beulich
2016-10-10 9:40 ` [PATCH v2 8/9] Config.mk: introduce cc-ifversion Wei Liu
2016-10-10 12:00 ` Jan Beulich
2016-10-10 13:18 ` Wei Liu
2016-10-10 13:22 ` Jan Beulich
2016-10-10 13:24 ` Wei Liu
2016-10-10 9:40 ` [PATCH v2 9/9] gcov: provide the capability to select gcov format automatically Wei Liu
2016-10-10 12:00 ` Jan Beulich
2016-10-10 15:47 ` [PATCH v2 0/9] Rework gcov support in Xen Ian Jackson
2016-10-10 15:58 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012133131.GO3687@citrix.com \
--to=wei.liu2@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=philippe.gabriel@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.