From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buJt7-0007ED-FJ for qemu-devel@nongnu.org; Wed, 12 Oct 2016 09:48:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buJt5-0006rG-J9 for qemu-devel@nongnu.org; Wed, 12 Oct 2016 09:48:04 -0400 Date: Wed, 12 Oct 2016 15:47:54 +0200 From: Kevin Wolf Message-ID: <20161012134754.GH5544@noname.redhat.com> References: <5326a6d77df350ddfb72574e60f3bbf1228278f8.1475757437.git.berto@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5326a6d77df350ddfb72574e60f3bbf1228278f8.1475757437.git.berto@igalia.com> Subject: Re: [Qemu-devel] [PATCH v10 05/16] block: Check blockers in all nodes involved in a block-commit job List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz , Markus Armbruster , Stefan Hajnoczi Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben: > qmp_block_commit() checks for op blockers in the active and > destination (base) images. However all nodes between top_bs and base > are also involved, and they are removed from the chain afterwards. > > In addition to that, if top_bs is not the active layer then top_bs's > overlay also needs to be checked because it's involved in the job (its > backing image string needs to be updated to point to 'base'). > > This patch checks that none of those nodes are blocked. > > Signed-off-by: Alberto Garcia Reviewed-by: Kevin Wolf