From: Bjorn Helgaas <helgaas@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Ley Foon Tan <lftan@altera.com>,
linux-pci@vger.kernel.org, rfi@lists.rocketboards.org
Subject: Re: [PATCH v2 0/6] PCI: altera: Cleanups
Date: Wed, 12 Oct 2016 11:00:53 -0500 [thread overview]
Message-ID: <20161012160053.GB4308@localhost> (raw)
In-Reply-To: <20161012123804.23240.96181.stgit@bhelgaas-glaptop2.roam.corp.google.com>
On Wed, Oct 12, 2016 at 07:46:59AM -0500, Bjorn Helgaas wrote:
> - Add local "dev" pointers to reduce repetition of things like
> "&pdev->dev".
>
> - Remove platform drvdata because it appears unused (we called
> platform_set_drvdata() but not platform_get_drvdata()).
>
> - Removed an unnecessary platform_get_resource() return value check.
>
> - Rework TLB_CFG_DW0 and TLP_CFG_DW1 to make the code prettier.
>
> Nothing here should change the behavior of the driver.
>
> Changes from v1:
> I dropped the following patches because they were a lot of churn for
> questionable benefit:
> PCI: altera: Name private struct pointer "altera" consistently
> PCI: altera: Rename _altera_pcie_cfg_read() to altera_raw_cfg_read()
> PCI: altera: Rename CRA accessors
> PCI: altera: Swap order of altera_cra_writel() reg/val arguments
>
> ---
>
> Bjorn Helgaas (6):
> PCI: altera: Add local struct device pointers
> PCI: altera: Remove unused platform data
> PCI: altera: Remove redundant platform_get_resource() return value check
> PCI: altera: Rename altera_pcie_valid_config() to altera_pcie_valid_device()
> PCI: altera: Simplify TLB_CFG_DW0 usage
> PCI: altera: Simplify TLP_CFG_DW1 usage
I applied these to pci/host-altera for v4.9. I hope to ask Linus to
pull them tomorrow, so if you see any issues, let me know soon.
next prev parent reply other threads:[~2016-10-12 16:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 12:46 [PATCH v2 0/6] PCI: altera: Cleanups Bjorn Helgaas
2016-10-12 12:47 ` [PATCH v2 1/6] PCI: altera: Add local struct device pointers Bjorn Helgaas
2016-10-12 12:47 ` [PATCH v2 2/6] PCI: altera: Remove unused platform data Bjorn Helgaas
2016-10-12 12:47 ` [PATCH v2 3/6] PCI: altera: Remove redundant platform_get_resource() return value check Bjorn Helgaas
2016-10-12 12:47 ` [PATCH v2 4/6] PCI: altera: Rename altera_pcie_valid_config() to altera_pcie_valid_device() Bjorn Helgaas
2016-10-12 12:47 ` [PATCH v2 5/6] PCI: altera: Simplify TLB_CFG_DW0 usage Bjorn Helgaas
2016-10-12 12:47 ` [PATCH v2 6/6] PCI: altera: Simplify TLP_CFG_DW1 usage Bjorn Helgaas
2016-10-12 16:00 ` Bjorn Helgaas [this message]
2016-10-13 10:28 ` [PATCH v2 0/6] PCI: altera: Cleanups Ley Foon Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012160053.GB4308@localhost \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=lftan@altera.com \
--cc=linux-pci@vger.kernel.org \
--cc=rfi@lists.rocketboards.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.