All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: "Michal Simek" <michal.simek@xilinx.com>,
	"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 0/5] PCI: xilinx: Cleanups
Date: Wed, 12 Oct 2016 11:03:34 -0500	[thread overview]
Message-ID: <20161012160334.GI4308@localhost> (raw)
In-Reply-To: <20161012130819.25793.17542.stgit@bhelgaas-glaptop2.roam.corp.google.com>

On Wed, Oct 12, 2016 at 08:10:30AM -0500, Bjorn Helgaas wrote:
>   - Add local "dev" pointers to reduce repetition of things like
>     "&pdev->dev".
> 
>   - Remove platform drvdata because it appears unused (we called
>     platform_set_drvdata() but not platform_get_drvdata()).
> 
>   - Remove unused xilinx_pcie_assign_msi() argument.
> 
> Nothing here should change the behavior of the driver.
> 
> Changes from v1:
>   Added "PCI: xilinx: Removed unused xilinx_pcie_assign_msi() argument"
>   I dropped the following patches because they were a lot of churn for
>   questionable benefit:
>     PCI: xilinx: Name private struct pointer "xilinx" consistently
>     PCI: xilinx: Rename accessors
>     PCI: xilinx: Swap order of xilinx_writel() reg/val arguments
>     PCI: xilinx-nwl: Name private struct pointer "nwl" consistently
>     PCI: xilinx-nwl: Swap order of nwl_bridge_writel() reg/val arguments
> 
> ---
> 
> Bjorn Helgaas (5):
>       PCI: xilinx: Add local struct device pointers
>       PCI: xilinx: Remove unused platform data
>       PCI: xilinx: Removed unused xilinx_pcie_assign_msi() argument
>       PCI: xilinx-nwl: Add local struct device pointers
>       PCI: xilinx-nwl: Remove unused platform data

I applied these to pci/host-xilinx for v4.9.  I hope to ask Linus to
pull them tomorrow, so if you see any issues, let me know soon.

      parent reply	other threads:[~2016-10-12 16:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-12 13:10 [PATCH v2 0/5] PCI: xilinx: Cleanups Bjorn Helgaas
2016-10-12 13:10 ` [PATCH v2 1/5] PCI: xilinx: Add local struct device pointers Bjorn Helgaas
2016-10-12 13:10 ` [PATCH v2 2/5] PCI: xilinx: Remove unused platform data Bjorn Helgaas
2016-10-12 13:10 ` [PATCH v2 3/5] PCI: xilinx: Removed unused xilinx_pcie_assign_msi() argument Bjorn Helgaas
2016-10-12 13:11 ` [PATCH v2 4/5] PCI: xilinx-nwl: Add local struct device pointers Bjorn Helgaas
2016-10-12 13:11 ` [PATCH v2 5/5] PCI: xilinx-nwl: Remove unused platform data Bjorn Helgaas
2016-10-12 16:03 ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161012160334.GI4308@localhost \
    --to=helgaas@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=soren.brinkmann@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.