From: Bjorn Helgaas <helgaas@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 0/6] PCI: armada: Cleanups
Date: Wed, 12 Oct 2016 11:04:24 -0500 [thread overview]
Message-ID: <20161012160424.GK4308@localhost> (raw)
In-Reply-To: <20161012131957.26736.14194.stgit@bhelgaas-glaptop2.roam.corp.google.com>
On Wed, Oct 12, 2016 at 08:25:11AM -0500, Bjorn Helgaas wrote:
> - Remove platform drvdata because it appears unused (we called
> platform_set_drvdata() but not platform_get_drvdata()).
>
> - Remove redundant struct members.
>
> - Use generic DesignWare accessors when possible.
>
> - Pass device-specific struct to internal functions for consistency.
>
> Nothing here should change the behavior of the driver.
>
> Changes from v1:
> I dropped the following patches because they were a lot of churn for
> questionable benefit:
> PCI: armada: Name private struct pointer "armada8k" consistently
> PCI: armada: Add register accessors
>
> ---
>
> Bjorn Helgaas (6):
> PCI: armada: Remove unused platform data
> PCI: armada: Add local base pointer
> PCI: armada: Remove redundant struct armada8k_pcie.base
> PCI: armada: Use generic DesignWare accessors
> PCI: armada: Pass device-specific struct to internal functions
> PCI: armada: Reorder struct armada8k_pcie
>
>
> drivers/pci/host/pcie-armada8k.c | 78 ++++++++++++++++++--------------------
I applied these to pci/host-armada for v4.9. I hope to ask Linus to
pull them tomorrow, so if you see any issues, let me know soon.
prev parent reply other threads:[~2016-10-12 16:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 13:25 [PATCH v2 0/6] PCI: armada: Cleanups Bjorn Helgaas
2016-10-12 13:25 ` [PATCH v2 1/6] PCI: armada: Remove unused platform data Bjorn Helgaas
2016-10-12 13:25 ` [PATCH v2 2/6] PCI: armada: Add local base pointer Bjorn Helgaas
2016-10-12 13:25 ` [PATCH v2 3/6] PCI: armada: Remove redundant struct armada8k_pcie.base Bjorn Helgaas
2016-10-12 13:25 ` [PATCH v2 4/6] PCI: armada: Use generic DesignWare accessors Bjorn Helgaas
2016-10-12 13:25 ` [PATCH v2 5/6] PCI: armada: Pass device-specific struct to internal functions Bjorn Helgaas
2016-10-12 13:26 ` [PATCH v2 6/6] PCI: armada: Reorder struct armada8k_pcie Bjorn Helgaas
2016-10-12 16:04 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012160424.GK4308@localhost \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.