Re: [PATCH v2 0/8] PCI: imx6: Cleanups

[Bjorn Helgaas <helgaas@kernel.org>]

On Wed, Oct 12, 2016 at 08:47:32AM -0500, Bjorn Helgaas wrote:
>   - Add local "dev" pointers to reduce repetition of things like
>     "&pdev->dev".
> 
>   - Clean up redundant dev->of_node usage.
> 
>   - Remove redundant struct members.
> 
>   - Pass struct imx6_pcie pointer rather than register address to PHY
>     accessors.  This enables use of the generic DesignWare accessors.
> 
>   - Use generic DesignWare accessors when possible.
> 
>   - Pass device-specific struct to internal functions for consistency.
> 
>   - Remove unused return values.
> 
> Nothing here should change the behavior of the driver.
> 
> Changes from v1:
>   I dropped the following patches because they were a lot of churn for
>   questionable benefit:
>     PCI: imx6: Name private struct pointer "imx6" consistently
>     PCI: imx6: Name PHY accessors consistently with other i.MX6 accessors
>     PCI: imx6: Add register accessors
> 
> ---
> 
> Bjorn Helgaas (8):
>       PCI: imx6: Add local struct device pointers
>       PCI: imx6: Remove redundant of_node pointer
>       PCI: imx6: Removed unused struct imx6_pcie.mem_base
>       PCI: imx6: Pass struct imx6_pcie to PHY accessors
>       PCI: imx6: Pass device-specific struct to internal functions
>       PCI: imx6: Use generic DesignWare accessors
>       PCI: imx6: Reorder struct imx6_pcie
>       PCI: imx6: Remove unused return values
> 
> 
>  drivers/pci/host/pci-imx6.c |  250 ++++++++++++++++++++++---------------------
>  1 file changed, 126 insertions(+), 124 deletions(-)

I applied these to pci/host-imx6 for v4.9.  I hope to ask Linus to
pull them tomorrow, so if you see any issues, let me know soon.