From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buQSj-0005Bn-Ur for qemu-devel@nongnu.org; Wed, 12 Oct 2016 16:49:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buQSi-00021K-Pa for qemu-devel@nongnu.org; Wed, 12 Oct 2016 16:49:17 -0400 From: Max Reitz Date: Wed, 12 Oct 2016 22:49:05 +0200 Message-Id: <20161012204907.25941-2-mreitz@redhat.com> In-Reply-To: <20161012204907.25941-1-mreitz@redhat.com> References: <20161012204907.25941-1-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH 1/3] block: Fix bdrv_iterate_format() sorting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Max Reitz , Kevin Wolf , Stefan Hajnoczi , Hao QingFeng bdrv_iterate_format() did not actually sort the formats by name but by "pointer interpreted as string". That is probably not what we intended to do, so fix it (by changing qsort_strcmp() so it matches the example from qsort()'s manual page). Signed-off-by: Max Reitz --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index bb1f1ec..e46e4b2 100644 --- a/block.c +++ b/block.c @@ -2789,7 +2789,7 @@ const char *bdrv_get_format_name(BlockDriverState *bs) static int qsort_strcmp(const void *a, const void *b) { - return strcmp(a, b); + return strcmp(*(char *const *)a, *(char *const *)b); } void bdrv_iterate_format(void (*it)(void *opaque, const char *name), -- 2.10.0