All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: nfsd: managing pages under network I/O
Date: Wed, 12 Oct 2016 23:35:35 -0700	[thread overview]
Message-ID: <20161013063535.GA7149@infradead.org> (raw)
In-Reply-To: <BD4A3DBB-71B5-4C30-8976-43F4DD58CBBE@oracle.com>

On Wed, Oct 12, 2016 at 01:42:26PM -0400, Chuck Lever wrote:
> I'm studying the way that the ->recvfrom and ->sendto calls work
> for RPC-over-RDMA.
> 
> The ->sendto path moves pages out of the svc_rqst before posting
> I/O (RDMA Write and Send). Once the work is posted, ->sendto
> returns, and looks like svc_rqst is released at that point. The
> subsequent completion of the Send then releases those moved pages.
> 
> I'm wondering if the transport can be simplified: instead of
> moving pages around, ->sendto could just wait until the Write and
> Send activity is complete, then return. The upper layer then
> releases everything.

I'd prefer not block for no reason at all.

> Another option would be for ->sendto to return a value that means
> the transport will release the svc_rqst and pages.

Or just let the transport always release it.  We only have two
different implementations of the relevant ops anyway.

  reply	other threads:[~2016-10-13  6:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-12 17:42 nfsd: managing pages under network I/O Chuck Lever
2016-10-13  6:35 ` Christoph Hellwig [this message]
2016-10-13 13:36   ` Chuck Lever
2016-10-13 14:32     ` Chuck Lever
2016-10-19 17:26 ` J. Bruce Fields
2016-10-19 18:28   ` Chuck Lever
2016-10-19 19:16     ` J. Bruce Fields
2016-10-19 19:21       ` Chuck Lever
2016-10-19 19:26         ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161013063535.GA7149@infradead.org \
    --to=hch@infradead.org \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.