From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 13 Oct 2016 08:53:21 +0000 Subject: [patch] drm/imx: drm_dev_alloc() returns error pointers Message-Id: <20161013085321.GG16198@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Philipp Zabel , Lucas Stach Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org We are checking for NULL here, when we should be checking for error pointers. Fixes: 54db5decce17 ("drm/imx: drop deprecated load/unload drm_driver ops") Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c index 98df09c..3acc976 100644 --- a/drivers/gpu/drm/imx/imx-drm-core.c +++ b/drivers/gpu/drm/imx/imx-drm-core.c @@ -357,8 +357,8 @@ static int imx_drm_bind(struct device *dev) int ret; drm = drm_dev_alloc(&imx_drm_driver, dev); - if (!drm) - return -ENOMEM; + if (IS_ERR(drm)) + return PTR_ERR(drm); imxdrm = devm_kzalloc(dev, sizeof(*imxdrm), GFP_KERNEL); if (!imxdrm) { From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] drm/imx: drm_dev_alloc() returns error pointers Date: Thu, 13 Oct 2016 11:53:21 +0300 Message-ID: <20161013085321.GG16198@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id A6A1A6E9A8 for ; Thu, 13 Oct 2016 08:53:37 +0000 (UTC) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Philipp Zabel , Lucas Stach Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org V2UgYXJlIGNoZWNraW5nIGZvciBOVUxMIGhlcmUsIHdoZW4gd2Ugc2hvdWxkIGJlIGNoZWNraW5n IGZvciBlcnJvcgpwb2ludGVycy4KCkZpeGVzOiA1NGRiNWRlY2NlMTcgKCJkcm0vaW14OiBkcm9w IGRlcHJlY2F0ZWQgbG9hZC91bmxvYWQgZHJtX2RyaXZlciBvcHMiKQpTaWduZWQtb2ZmLWJ5OiBE YW4gQ2FycGVudGVyIDxkYW4uY2FycGVudGVyQG9yYWNsZS5jb20+CgpkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2lteC9pbXgtZHJtLWNvcmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pbXgvaW14 LWRybS1jb3JlLmMKaW5kZXggOThkZjA5Yy4uM2FjYzk3NiAxMDA2NDQKLS0tIGEvZHJpdmVycy9n cHUvZHJtL2lteC9pbXgtZHJtLWNvcmUuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vaW14L2lteC1k cm0tY29yZS5jCkBAIC0zNTcsOCArMzU3LDggQEAgc3RhdGljIGludCBpbXhfZHJtX2JpbmQoc3Ry dWN0IGRldmljZSAqZGV2KQogCWludCByZXQ7CiAKIAlkcm0gPSBkcm1fZGV2X2FsbG9jKCZpbXhf ZHJtX2RyaXZlciwgZGV2KTsKLQlpZiAoIWRybSkKLQkJcmV0dXJuIC1FTk9NRU07CisJaWYgKElT X0VSUihkcm0pKQorCQlyZXR1cm4gUFRSX0VSUihkcm0pOwogCiAJaW14ZHJtID0gZGV2bV9remFs bG9jKGRldiwgc2l6ZW9mKCppbXhkcm0pLCBHRlBfS0VSTkVMKTsKIAlpZiAoIWlteGRybSkgewpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK