From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 13 Oct 2016 10:20:40 +0000 Subject: [patch] drm/exynos: fix a timeout loop Message-Id: <20161013102040.GA5576@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Inki Dae , Tobias Jakobi Cc: linux-samsung-soc@vger.kernel.org, kernel-janitors@vger.kernel.org, Seung-Woo Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Kyungmin Park , Kukjin Kim , dri-devel@lists.freedesktop.org We were trying to print an error message if we timed out here, but the loop actually ends with "tries" set to UINT_MAX and not zero. Fix this by changing from tries-- to --tries. A for loop would actually be the most natural way to do this. My fix means we only loop 99 times instead of 100 but that's probably ok. Fixes: a696394c5224 ('drm/exynos: mixer: simplify loop in vp_win_reset()') Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c index edb20a3..fcc7e4f 100644 --- a/drivers/gpu/drm/exynos/exynos_mixer.c +++ b/drivers/gpu/drm/exynos/exynos_mixer.c @@ -701,7 +701,7 @@ static void vp_win_reset(struct mixer_context *ctx) unsigned int tries = 100; vp_reg_write(res, VP_SRESET, VP_SRESET_PROCESSING); - while (tries--) { + while (--tries) { /* waiting until VP_SRESET_PROCESSING is 0 */ if (~vp_reg_read(res, VP_SRESET) & VP_SRESET_PROCESSING) break; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] drm/exynos: fix a timeout loop Date: Thu, 13 Oct 2016 13:20:40 +0300 Message-ID: <20161013102040.GA5576@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Inki Dae , Tobias Jakobi Cc: linux-samsung-soc@vger.kernel.org, kernel-janitors@vger.kernel.org, Seung-Woo Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Kyungmin Park , Kukjin Kim , dri-devel@lists.freedesktop.org List-Id: linux-samsung-soc@vger.kernel.org V2Ugd2VyZSB0cnlpbmcgdG8gcHJpbnQgYW4gZXJyb3IgbWVzc2FnZSBpZiB3ZSB0aW1lZCBvdXQg aGVyZSwgYnV0IHRoZQpsb29wIGFjdHVhbGx5IGVuZHMgd2l0aCAidHJpZXMiIHNldCB0byBVSU5U X01BWCBhbmQgbm90IHplcm8uICBGaXggdGhpcwpieSBjaGFuZ2luZyBmcm9tIHRyaWVzLS0gdG8g LS10cmllcy4KCkEgZm9yIGxvb3Agd291bGQgYWN0dWFsbHkgYmUgdGhlIG1vc3QgbmF0dXJhbCB3 YXkgdG8gZG8gdGhpcy4gIE15IGZpeAptZWFucyB3ZSBvbmx5IGxvb3AgOTkgdGltZXMgaW5zdGVh ZCBvZiAxMDAgYnV0IHRoYXQncyBwcm9iYWJseSBvay4KCkZpeGVzOiBhNjk2Mzk0YzUyMjQgKCdk cm0vZXh5bm9zOiBtaXhlcjogc2ltcGxpZnkgbG9vcCBpbiB2cF93aW5fcmVzZXQoKScpClNpZ25l ZC1vZmYtYnk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4KCmRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19taXhlci5jIGIvZHJpdmVycy9n cHUvZHJtL2V4eW5vcy9leHlub3NfbWl4ZXIuYwppbmRleCBlZGIyMGEzLi5mY2M3ZTRmIDEwMDY0 NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19taXhlci5jCisrKyBiL2RyaXZl cnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX21peGVyLmMKQEAgLTcwMSw3ICs3MDEsNyBAQCBzdGF0 aWMgdm9pZCB2cF93aW5fcmVzZXQoc3RydWN0IG1peGVyX2NvbnRleHQgKmN0eCkKIAl1bnNpZ25l ZCBpbnQgdHJpZXMgPSAxMDA7CiAKIAl2cF9yZWdfd3JpdGUocmVzLCBWUF9TUkVTRVQsIFZQX1NS RVNFVF9QUk9DRVNTSU5HKTsKLQl3aGlsZSAodHJpZXMtLSkgeworCXdoaWxlICgtLXRyaWVzKSB7 CiAJCS8qIHdhaXRpbmcgdW50aWwgVlBfU1JFU0VUX1BST0NFU1NJTkcgaXMgMCAqLwogCQlpZiAo fnZwX3JlZ19yZWFkKHJlcywgVlBfU1JFU0VUKSAmIFZQX1NSRVNFVF9QUk9DRVNTSU5HKQogCQkJ YnJlYWs7Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=