All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	dharageswari.r@intel.com, vinod.koul@intel.com,
	jayachandran.b@intel.com, broonie@kernel.org, jeeja.kp@intel.com
Subject: Re: inconsistent reference counting for snd-soc-skl
Date: Thu, 13 Oct 2016 19:11:06 +0530	[thread overview]
Message-ID: <20161013134102.GA24627@subhransu-desktop> (raw)
In-Reply-To: <120ab1f8-002d-de8e-358e-f3b486dc1012@sakamocchi.jp>

On Thu, Oct 13, 2016 at 10:19:37PM +0900, Takashi Sakamoto wrote:
> Hi,
> 
> I find an issue of snd-soc-skl due to inconsistent reference counting.
> See this call graph.
> 
> skl_probe()
> ->skl_first_init()
>   ->skl_i915_init()
>     ->snd_hdac_display_power() (CONFIG_SND_SOC_HDAC_HDMI is enabled)
>       ->bus->i915_power_refcount++
> ->all error pathes
>   ->skl_free()
>     ->snd_hda_i915_exit()
>       ->WARN_ON(!bus->i915_power_refcount)
> 
> This might be also hit by rmmod(8). I see this bug in kernel 4.8 and
> pre-4.9.

Thanks Takashi for reporting. We will fix this.

Regards,
Subhransu

> 
> 
> Regards
> 
> Takashi Sakamoto

-- 

       reply	other threads:[~2016-10-13 13:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <120ab1f8-002d-de8e-358e-f3b486dc1012@sakamocchi.jp>
2016-10-13 13:41 ` Subhransu S. Prusty [this message]
2016-10-13 13:54   ` inconsistent reference counting for snd-soc-skl Takashi Sakamoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161013134102.GA24627@subhransu-desktop \
    --to=subhransu.s.prusty@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=dharageswari.r@intel.com \
    --cc=jayachandran.b@intel.com \
    --cc=jeeja.kp@intel.com \
    --cc=o-takashi@sakamocchi.jp \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.