Re: [PATCH v4 1/2] gcov: add new interface and new formats support

[Wei Liu <wei.liu2@citrix.com>]

On Thu, Oct 13, 2016 at 09:38:45AM -0400, Konrad Rzeszutek Wilk wrote:
> > diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c
> > index 93f107c..2f64bb5 100644
> > --- a/xen/common/sysctl.c
> > +++ b/xen/common/sysctl.c
> > @@ -28,6 +28,7 @@
> >  #include <xsm/xsm.h>
> >  #include <xen/pmstat.h>
> >  #include <xen/livepatch.h>
> > +#include <xen/gcov.h>
> >  
> >  long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl)
> >  {
> > @@ -395,6 +396,13 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl)
> >      }
> >      break;
> >  
> > +#ifdef CONFIG_GCOV
> > +    case XEN_SYSCTL_gcov_op:
> > +        ret = sysctl_gcov_op(&op->u.gcov_op);
> > +        copyback = 1;
> > +        break;
> > +#endif
> 
> Should there be an XSM entry in flask_sysctl for this?
> And also in flask/policy/access_vectors
> 
> And in tools/flask/policy/policy.conf
> 
> Maybe that should be a seperate patch?

Yes. That's planned. Didn't want to cram in too much stuff in one single
patch.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel