From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56929) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buezJ-0006LW-8C for qemu-devel@nongnu.org; Thu, 13 Oct 2016 08:19:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buezF-0003xj-TD for qemu-devel@nongnu.org; Thu, 13 Oct 2016 08:19:53 -0400 Received: from 5.mo179.mail-out.ovh.net ([46.105.43.140]:33285) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buezF-0003xF-N7 for qemu-devel@nongnu.org; Thu, 13 Oct 2016 08:19:49 -0400 Received: from player792.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo179.mail-out.ovh.net (Postfix) with ESMTP id E3BE5FFB0D2 for ; Thu, 13 Oct 2016 14:19:48 +0200 (CEST) Date: Thu, 13 Oct 2016 14:19:45 +0200 From: Greg Kurz Message-ID: <20161013141945.045ce45e@bahia> In-Reply-To: References: <57ff5d71.4a3c9d0a.90936.6097@mx.google.com> <20161013135854.2cf48a4d@bahia> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/3] 9pfs: fix xattr related issues List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Li Qiang Cc: qemu-devel@nongnu.org, Li Qiang On Thu, 13 Oct 2016 20:10:17 +0800 Li Qiang wrote: > I'm not sure of this, I use > > git format-patch -3 -s --subject-prefix="PATCH v3" --cover-letter > > to generate this patchset first and then modify some text. Then > > git send-email *.patch --to xx --to > > Is there anything wrong? > The git commands look ok ASAICT... the problem seems to be gmail rewriting the MessageID header, which breaks the mail threading. Either this is something you can control in your gmail account settings, either there's a workaround for it, either you should move away from gmail. FYI, there was a patchset with a gmail From address this morning, which doesn't have the problem: [PATCH v2 00/13] Refactor common part of xen backend and frontend I'll review this patchset but please try to fix it for next time. Cheers. -- Greg > On 2016-10-13 19:58 GMT+08:00 Greg Kurz wrote: > > > On Thu, 13 Oct 2016 03:09:40 -0700 > > Li Qiang wrote: > > > > > From: Li Qiang > > > > > > The current xattr implementation in 9pfs has several issues. > > > > > > -The 'copied_len' in V9fsXattr is used both for accounting bytes and to > > tag the xattr fid. > > > -The 'len/copied_len' field in V9fsXattr has a wrong type. > > > -The read/write dispatch function of xattr uses unsafe computations. > > > > > > This patchset solves these issues. > > > > > > Li Qiang (3): > > > 9pfs: add xattrwalk_fid field in V9fsXattr struct > > > 9pfs: convert 'len/copied_len' field in V9fsXattr to the type of > > > uint64_t > > > 9pfs: fix integer overflow issue in xattr read/write > > > > > > hw/9pfs/9p.c | 39 ++++++++++++++++----------------------- > > > hw/9pfs/9p.h | 5 +++-- > > > 2 files changed, 19 insertions(+), 25 deletions(-) > > > > > > > Weird... the patches appear in separate threads, which is perturbing. > > > > The cover letter has this: > > > > Message-ID: <57ff5d71.4a3c9d0a.90936.6097@mx.google.com> > > X-Google-Original-Message-ID: <1476353383-4679-1-git-send-email-Qiang( > > liqiang6-s@360.cn)> > > > > and patch 1/3 has that: > > > > In-Reply-To: <1476353383-4679-1-git-send-email-Qiang(liqiang6-s@360.cn)> > > References: <1476353383-4679-1-git-send-email-Qiang(liqiang6-s@360.cn)> > > > > Is it a "feature" of gmail to rewrite Message-ID headers ? Can it be > > turned off ? > > > > Cheers. > > > > -- > > Greg > >