From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 3/3] drm/i915: Remove superfluous locking
 around userfault_list
Date: Thu, 13 Oct 2016 16:47:56 +0200
Message-ID: <20161013144756.GD20761@phenom.ffwll.local>
References: <20161011132524.GC20761@phenom.ffwll.local>
 <20161011143759.28052-1-chris@chris-wilson.co.uk>
 <20161011143759.28052-3-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com
 [IPv6:2a00:1450:400c:c09::242])
 by gabe.freedesktop.org (Postfix) with ESMTPS id BC05D6E04A
 for <intel-gfx@lists.freedesktop.org>; Thu, 13 Oct 2016 14:48:00 +0000 (UTC)
Received: by mail-wm0-x242.google.com with SMTP id o81so20946wma.2
 for <intel-gfx@lists.freedesktop.org>; Thu, 13 Oct 2016 07:48:00 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20161011143759.28052-3-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCBPY3QgMTEsIDIwMTYgYXQgMDM6Mzc6NTlQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IE5vdyB0aGF0IHdlIGhhdmUgcmVkdWNlZCB0aGUgYWNjZXNzIHRvIHRoZSBsaXN0IHRv
IGVpdGhlciAoYSkgdW5kZXIgdGhlCj4gc3RydWN0X211dGV4IHdoaWxzdCBob2xkaW5nIHRoZSBS
UE0gd2FrZXJlZiAoc28gdGhhdCBjb25jdXJyZW50IHdyaXRlcnMgdG8KPiB0aGUgbGlzdCBhcmUg
c2VyaWFsaXNlZCBieSBzdHJ1Y3RfbXV0ZXgpIGFuZCAoYikgdW5kZXIgdGhlIGF0b21pYwo+IHJ1
bnRpbWUgc3VzcGVuZCAod2hpY2ggY2Fubm90IHJ1biBjb25jdXJyZW50bHkgd2l0aCBhbnkgb3Ro
ZXIgYWNjZXNzb3IgZHVlCj4gdG8gdGhlIGF0b21pYyBuYXR1cmUgb2YgdGhlIHJ1bnRpbWUgc3Vz
cGVuZCkgd2UgY2FuIHJlbW92ZSB0aGUgZXh0cmEKPiBsb2NraW5nIGFyb3VuZCB0aGUgbGlzdCBp
dHNlbGYuCj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxz
b24uY28udWs+CgpTbyB0aGlzIGlzIGEgYml0IGEgcGV0IHBlZXZlIG9mIG1pbmUsIGJ1dCB3aGVu
IGNoYW5naW5nIGxvY2tpbmcgc2NoZW1lcwpJJ20gdHJ5aW5nIHRvIG1ha2UgYW4gYXMgY2xlYXIg
YXMgcG9zc2libGUgZGlzdGluY3Rpb24gYmV0d2VlbiBsb2NraW5nCih3aGljaCBpcyBqdXN0IG1l
YW50IHRvIHByb3RlY3QgdGhlIGludGVncml0eSBvZiBkYXRhIHN0cnVjdHVyZXMsIGxpa2UKZS5n
LiB0aGUgdXNlcmZhdWx0X2xpc3QgaGVyZSkuIEFuZCBhbnl0aGluZyBlbHNlIHdoaWNoIG1hbmFn
ZXMgbGlmZXRpbWVzCmFuZCByZXNvdXJjZXMgKGFsbCB0aGUgZ2V0L3B1dCBzdHVmZiB3ZSBoYXZl
KSBvciBvcmRlcmluZy9zZXF1ZW5jZQood2FpdGluZywgd2FraW5nIHVwIG90aGVyIHN0dWZmIGFu
ZCBhbGwgdGhhdCkuCgpUaGUgcmVhc29uIGZvciB0aGF0IGlzIHRoYXQgd2l0aCBhIEJLTCBpdCBp
cyBzdXBlciBlYXN5IHRvIHNtYXNoIGFsbCB0aGVzZQp0aGluZ3MgaW50byBvbmUsIGJ1dCBpZiB5
b3UgaGF2ZSBsb2NraW5nIHRoYXQgYWxzbyBrZWVwcyBzdHVmZiBhbGl2ZSBhbmQKZ3VhcmFudGVl
cyBvcmRlcmluZyAob3IgdGhlIG90aGVyIHdheSByb3VuZCkgaXQgYmVjb21lcyBuaWdoIHRvIGlt
cG9zc2libGUKdG8gdW50YW5nbGUuCgpIZW5jZSB3aHkgSSBkb24ndCBsaWtlIHRoaXMuCi1EYW5p
ZWwKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggfCAgMyAtLS0KPiAg
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyB8IDIxICsrKystLS0tLS0tLS0tLS0tLS0t
LQo+ICAyIGZpbGVzIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25zKC0pCj4g
Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5kZXggNzJiMzEyNmM2Yzc0Li4xM2NhOTY4YTc2
MGEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsrKyBi
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBAQCAtMTM1OSw5ICsxMzU5LDYgQEAg
c3RydWN0IGk5MTVfZ2VtX21tIHsKPiAgCSAqLwo+ICAJc3RydWN0IGxpc3RfaGVhZCB1bmJvdW5k
X2xpc3Q7Cj4gIAo+IC0JLyoqIFByb3RlY3RzIGFjY2VzcyB0byB0aGUgdXNlcmZhdWx0X2xpc3Qg
Ki8KPiAtCXNwaW5sb2NrX3QgdXNlcmZhdWx0X2xvY2s7Cj4gLQo+ICAJLyoqIExpc3Qgb2YgYWxs
IG9iamVjdHMgaW4gZ3R0X3NwYWNlLCBjdXJyZW50bHkgbW1hcGVkIGJ5IHVzZXJzcGFjZS4KPiAg
CSAqIEFsbCBvYmplY3RzIHdpdGhpbiB0aGlzIGxpc3QgbXVzdCBhbHNvIGJlIG9uIGJvdW5kX2xp
c3QuCj4gIAkgKi8KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0u
YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBpbmRleCA1ODdhOTFhZjVhM2Yu
LmEyNjhlODA0MDA1YyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl
bS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IEBAIC0xODUzLDkg
KzE4NTMsNyBAQCBpbnQgaTkxNV9nZW1fZmF1bHQoc3RydWN0IHZtX2FyZWFfc3RydWN0ICphcmVh
LCBzdHJ1Y3Qgdm1fZmF1bHQgKnZtZikKPiAgCQlnb3RvIGVycl91bnBpbjsKPiAgCj4gIAlhc3Nl
cnRfcnBtX3dha2Vsb2NrX2hlbGQoZGV2X3ByaXYpOwo+IC0Jc3Bpbl9sb2NrKCZkZXZfcHJpdi0+
bW0udXNlcmZhdWx0X2xvY2spOwo+ICAJbGlzdF9hZGQoJm9iai0+dXNlcmZhdWx0X2xpbmssICZk
ZXZfcHJpdi0+bW0udXNlcmZhdWx0X2xpc3QpOwo+IC0Jc3Bpbl91bmxvY2soJmRldl9wcml2LT5t
bS51c2VyZmF1bHRfbG9jayk7Cj4gIAo+ICBlcnJfdW5waW46Cj4gIAlfX2k5MTVfdm1hX3VucGlu
KHZtYSk7Cj4gQEAgLTE5MjUsNyArMTkyMyw2IEBAIHZvaWQKPiAgaTkxNV9nZW1fcmVsZWFzZV9t
bWFwKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmopCj4gIHsKPiAgCXN0cnVjdCBkcm1f
aTkxNV9wcml2YXRlICppOTE1ID0gdG9faTkxNShvYmotPmJhc2UuZGV2KTsKPiAtCWJvb2wgemFw
ID0gZmFsc2U7Cj4gIAo+ICAJLyogU2VyaWFsaXNhdGlvbiBiZXR3ZWVuIHVzZXIgR1RUIGFjY2Vz
cyBhbmQgb3VyIGNvZGUgZGVwZW5kcyB1cG9uCj4gIAkgKiByZXZva2luZyB0aGUgQ1BVJ3MgUFRF
IHdoaWxzdCB0aGUgbXV0ZXggaXMgaGVsZC4gVGhlIG5leHQgdXNlcgo+IEBAIC0xOTM3LDE1ICsx
OTM0LDEwIEBAIGk5MTVfZ2VtX3JlbGVhc2VfbW1hcChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVj
dCAqb2JqKQo+ICAJICovCj4gIAlhc3NlcnRfcnBtX3dha2Vsb2NrX2hlbGQoaTkxNSk7Cj4gIAo+
IC0Jc3Bpbl9sb2NrKCZpOTE1LT5tbS51c2VyZmF1bHRfbG9jayk7Cj4gLQlpZiAoIWxpc3RfZW1w
dHkoJm9iai0+dXNlcmZhdWx0X2xpbmspKSB7Cj4gLQkJbGlzdF9kZWxfaW5pdCgmb2JqLT51c2Vy
ZmF1bHRfbGluayk7Cj4gLQkJemFwID0gdHJ1ZTsKPiAtCX0KPiAtCXNwaW5fdW5sb2NrKCZpOTE1
LT5tbS51c2VyZmF1bHRfbG9jayk7Cj4gLQlpZiAoIXphcCkKPiArCWlmIChsaXN0X2VtcHR5KCZv
YmotPnVzZXJmYXVsdF9saW5rKSkKPiAgCQlyZXR1cm47Cj4gIAo+ICsJbGlzdF9kZWxfaW5pdCgm
b2JqLT51c2VyZmF1bHRfbGluayk7Cj4gIAlkcm1fdm1hX25vZGVfdW5tYXAoJm9iai0+YmFzZS52
bWFfbm9kZSwKPiAgCQkJICAgb2JqLT5iYXNlLmRldi0+YW5vbl9pbm9kZS0+aV9tYXBwaW5nKTsK
PiAgCj4gQEAgLTE5NjMsMTMgKzE5NTUsOSBAQCB2b2lkCj4gIGk5MTVfZ2VtX3JlbGVhc2VfYWxs
X21tYXBzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgewo+ICAJc3RydWN0
IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwgKm9uOwo+IC0Jc3RydWN0IGxpc3RfaGVhZCB1c2Vy
ZmF1bHRfbGlzdDsKPiAtCj4gLQlzcGluX2xvY2soJmRldl9wcml2LT5tbS51c2VyZmF1bHRfbG9j
ayk7Cj4gLQlsaXN0X3JlcGxhY2VfaW5pdCgmZGV2X3ByaXYtPm1tLnVzZXJmYXVsdF9saXN0LCAm
dXNlcmZhdWx0X2xpc3QpOwo+IC0Jc3Bpbl91bmxvY2soJmRldl9wcml2LT5tbS51c2VyZmF1bHRf
bG9jayk7Cj4gIAo+IC0JbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlKG9iaiwgb24sICZ1c2VyZmF1
bHRfbGlzdCwgdXNlcmZhdWx0X2xpbmspCj4gKwlsaXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUob2Jq
LCBvbiwKPiArCQkJCSAmZGV2X3ByaXYtPm1tLnVzZXJmYXVsdF9saXN0LCB1c2VyZmF1bHRfbGlu
aykKPiAgCQlpOTE1X2dlbV9yZWxlYXNlX21tYXAob2JqKTsKPiAgfQo+ICAKPiBAQCAtNDQ1Nyw3
ICs0NDQ1LDYgQEAgaW50IGk5MTVfZ2VtX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAg
CWludCByZXQ7Cj4gIAo+ICAJbXV0ZXhfbG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+IC0Jc3Bp
bl9sb2NrX2luaXQoJmRldl9wcml2LT5tbS51c2VyZmF1bHRfbG9jayk7Cj4gIAo+ICAJaWYgKCFp
OTE1LmVuYWJsZV9leGVjbGlzdHMpIHsKPiAgCQlkZXZfcHJpdi0+Z3QucmVzdW1lID0gaW50ZWxf
bGVnYWN5X3N1Ym1pc3Npb25fcmVzdW1lOwo+IC0tIAo+IDIuOS4zCj4gCj4gX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBs
aXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJl
ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRl
cgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwu
Y2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt
Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v
bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==