From: Bjorn Helgaas <helgaas@kernel.org>
To: Murali Karicheri <m-karicheri2@ti.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 0/6] PCI: keystone: Cleanups
Date: Thu, 13 Oct 2016 13:27:29 -0500 [thread overview]
Message-ID: <20161013182729.GD21529@localhost> (raw)
In-Reply-To: <57FFCADE.7040300@ti.com>
On Thu, Oct 13, 2016 at 01:56:46PM -0400, Murali Karicheri wrote:
> On 10/12/2016 12:06 PM, Bjorn Helgaas wrote:
> > On Wed, Oct 12, 2016 at 08:53:00AM -0500, Bjorn Helgaas wrote:
> >> - Add local "dev" pointers to reduce repetition of things like
> >> "&pdev->dev".
> >>
> >> - Use generic DesignWare accessors when possible.
> >>
> >> - Pass device-specific struct instead of register addresses to IRQ and
> >> DBI functions.
> >>
> >> - Add app register accessors to encapsulate usage of va_app_base.
> >>
> >> Nothing here should change the behavior of the driver.
> >>
> >> Changes from v1:
> >> Added local struct device pointers.
> >> I dropped the following patch because it was a lot of churn for
> >> questionable benefit:
> >> PCI: keystone: Name private struct pointer "keystone" consistently
> >>
> >> ---
> >>
> >> Bjorn Helgaas (6):
> >> PCI: keystone: Add local struct device pointers
> >> PCI: keystone: Use generic DesignWare accessors
> >> PCI: keystone: Pass keystone_pcie, not address, to IRQ functions
> >> PCI: keystone: Pass keystone_pcie, not va_app_base, to DBI functions
> >> PCI: keystone: Add app register accessors
> >> PCI: keystone: Reorder struct keystone_pcie
> >>
> >>
> >> drivers/pci/host/pci-keystone-dw.c | 123 ++++++++++++++++++++----------------
> >> drivers/pci/host/pci-keystone.c | 28 ++++----
> >> drivers/pci/host/pci-keystone.h | 9 +--
> >> 3 files changed, 88 insertions(+), 72 deletions(-)
> >
> > I applied these to pci/host-keystone for v4.9. I hope to ask Linus to
> > pull them tomorrow, so if you see any issues, let me know soon.
> >
> Bjorn,
>
> I have reviewed them and they look good to me. For testing, I am in the
> middle of a high visibility debug and it will be a while before I can test
> these.
Thanks a lot, Murali! No hurry; if I broke something, we can fix it
during the rest of the cycle.
Bjorn
prev parent reply other threads:[~2016-10-13 18:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 13:53 [PATCH v2 0/6] PCI: keystone: Cleanups Bjorn Helgaas
2016-10-12 13:53 ` [PATCH v2 1/6] PCI: keystone: Add local struct device pointers Bjorn Helgaas
2016-10-12 13:53 ` [PATCH v2 2/6] PCI: keystone: Use generic DesignWare accessors Bjorn Helgaas
2016-10-12 13:53 ` [PATCH v2 3/6] PCI: keystone: Pass keystone_pcie, not address, to IRQ functions Bjorn Helgaas
2016-10-12 13:53 ` [PATCH v2 4/6] PCI: keystone: Pass keystone_pcie, not va_app_base, to DBI functions Bjorn Helgaas
2016-10-12 13:53 ` [PATCH v2 5/6] PCI: keystone: Add app register accessors Bjorn Helgaas
2016-10-12 13:53 ` [PATCH v2 6/6] PCI: keystone: Reorder struct keystone_pcie Bjorn Helgaas
2016-10-12 16:06 ` [PATCH v2 0/6] PCI: keystone: Cleanups Bjorn Helgaas
2016-10-13 17:56 ` Murali Karicheri
2016-10-13 18:27 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013182729.GD21529@localhost \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=m-karicheri2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.