From: Christoph Hellwig <hch@infradead.org>
To: Vineeth Remanan Pillai <vineethp@amazon.com>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, kamatam@amazon.com,
aliguori@amazon.com
Subject: Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag
Date: Thu, 13 Oct 2016 13:09:04 -0700 [thread overview]
Message-ID: <20161013200904.GA23139@infradead.org> (raw)
In-Reply-To: <1476388731-24053-1-git-send-email-vineethp@amazon.com>
On Thu, Oct 13, 2016 at 07:58:51PM +0000, Vineeth Remanan Pillai wrote:
> filename_lookup used to return success for non-existing file when called
> with LOOKUP_PARENT flag. This behaviour was changed with
> commit 8bcb77fabd7c ("namei: split off filename_lookupat()
> with LOOKUP_PARENT")
>
> The above patch split parent lookup functionality to a different function
> filename_parentat and changed all calls to filename_lookup(LOOKUP_PARENT)
> to the new function filename_parentat. But functions like kern_path which
> passed the flags directly to filename_lookup regressed due to this.
>
> This patch aims to fix the regressed behaviour by calling
> filename_parentat from filename_lookup if the flags contain LOOKUP_PARENT.
What callers shows te problems? That's probaby were the fix need to got
in, and even if not that's still part of a good bug report.
next prev parent reply other threads:[~2016-10-13 20:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 19:58 [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag Vineeth Remanan Pillai
2016-10-13 20:06 ` Al Viro
2016-10-13 20:09 ` Christoph Hellwig [this message]
2016-10-13 20:26 ` Al Viro
2016-10-13 20:41 ` Vineeth Remanan Pillai
2016-10-13 20:44 ` Christoph Hellwig
2016-10-13 21:24 ` Al Viro
2016-10-13 22:14 ` Vineeth Remanan Pillai
2016-10-13 23:31 ` Al Viro
2016-10-14 0:02 ` Remanan Pillai, Vineeth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013200904.GA23139@infradead.org \
--to=hch@infradead.org \
--cc=aliguori@amazon.com \
--cc=kamatam@amazon.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vineethp@amazon.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.