Re: [Qemu-devel] [PATCH 4/4] qga: add vsock-listen method

[Michael Roth <mdroth@linux.vnet.ibm.com>]

Quoting Stefan Hajnoczi (2016-10-12 10:07:33)
> On Fri, Oct 07, 2016 at 12:07:41PM -0500, Michael Roth wrote:
> > Quoting Stefan Hajnoczi (2016-10-06 11:40:18)
> > > Add AF_VSOCK (virtio-vsock) support as an alternative to virtio-serial.
> > > 
> > >   $ qemu-system-x86_64 -device vhost-vsock-pci,guest-cid=3 ...
> > >   (guest)# qemu-ga -m vsock-listen -p 3:1234
> > > 
> > > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > 
> > Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> > 
> > I still need to get a vsock environment set up to test with, but looks
> > good other than minor comments in patch 3.
> 
> Linux 4.8 has the guest and vhost drivers:
> 
> CONFIG_VSOCKETS=m
> CONFIG_VIRTIO_VSOCKETS=m
> CONFIG_VIRTIO_VSOCKETS_COMMON=m
> CONFIG_VHOST_VSOCK=m

I still need to do some work to get this fully integrated into my
test set up, but I ran these patches through some basic testing
with a 4.8.0 host and 4.9 guest and everything seems to be in
working order. I think Eric had some comments related to parameter
parsing in patch 3, but otherwise looks good.

> 
> Stefan