From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 13 Oct 2016 16:37:43 -0700 From: Adam Manzanares To: Tejun Heo CC: Adam Manzanares , , , , , , , , , , , , , , , Subject: Re: [PATCH v5 4/4] ata: ATA Command Priority Disabled By Default Message-ID: <20161013233742.GA5854@hgst.com> References: <1476399631-5799-1-git-send-email-adam.manzanares@hgst.com> <1476399631-5799-5-git-send-email-adam.manzanares@hgst.com> <20161013232230.GB32534@mtj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" In-Reply-To: <20161013232230.GB32534@mtj.duckdns.org> Return-Path: adam.manzanares@wdc.com List-ID: SGVsbG8gVGVqdW4sCgpUaGUgMTAvMTMvMjAxNiAxOToyMiwgVGVqdW4gSGVvIHdyb3RlOgo+IEhl bGxvLCBBZGFtLgo+IAo+IFNvcnJ5IGFib3V0IGxhdGUgcmVwbHkuICBXYXMgb24gdmFjYXRpb24u CgpOUCBJIHdhcyBvbiB2YWNhdGlvbiBhdCB0aGUgZW5kIG9mIHRoZSB3ZWVrIGxhc3Qgd2Vlay4K Cj4gCj4gT24gVGh1LCBPY3QgMTMsIDIwMTYgYXQgMDQ6MDA6MzFQTSAtMDcwMCwgQWRhbSBNYW56 YW5hcmVzIHdyb3RlOgo+ID4gQWRkIGEgc3lzZnMgZW50cnkgdG8gdHVybiBvbiBwcmlvcml0eSBp bmZvcm1hdGlvbiBiZWluZyBwYXNzZWQKPiA+IHRvIGEgQVRBIGRldmljZS4gQnkgZGVmYXVsdCB0 aGlzIGZlYXR1cmUgaXMgdHVybmVkIG9mZi4KPiA+IAo+ID4gVGhpcyBwYXRjaCBkZXBlbmRzIG9u IGF0YTogRW5hYmxpbmcgQVRBIENvbW1hbmQgUHJpb3JpdGllcwo+IAo+IExvb2tzIGdlbmVyYWxs eSBnb29kIGJ1dCBjYW4gd2UgcGxlYXNlIHVzZSBhIGRldmljZSBhdHRyaWJ1dGUgbmFtZQo+IHdo aWNoIGlzIG1vcmUgc3BlY2lmaWMgLSBpZS4gZW5hYmxlX25jcV9wcmlvPwoKV2lsbCBkbywgSSds bCBhbHNvIGRvdWJsZSBjaGVjayB0aGUgbmFtaW5nIHNjaGVtZSBvZiBmdW5jdGlvbnMgYW5kIHZh cmlhYmxlcyAKYWxzby4gVGhlIGZ1bmN0aW9ucyB0aGF0IGNoZWNrIGlmIHRoZSBkZXZpY2UgaGFz IHRoZSBuY3EgcHJpbyBjYXBhYmlsaXR5IG1pZ2h0CmJlIHRvbyBzaW1pbGFyIHRvIHRoZSBmdW5j dGlvbiB0aGF0IGNoZWNrcyBpZiB0aGUgZGV2aWNlIGF0dHJpYnV0ZSBpcyAKZW5hYmxlZC4KCj4g Cj4gVGhhbmtzLgo+IAo+IC0tIAo+IHRlanVuCgpUYWtlIGNhcmUsCkFkYW0KV2VzdGVybiBEaWdp dGFsIENvcnBvcmF0aW9uIChhbmQgaXRzIHN1YnNpZGlhcmllcykgRS1tYWlsIENvbmZpZGVudGlh bGl0eSBOb3RpY2UgJiBEaXNjbGFpbWVyOgoKVGhpcyBlLW1haWwgYW5kIGFueSBmaWxlcyB0cmFu c21pdHRlZCB3aXRoIGl0IG1heSBjb250YWluIGNvbmZpZGVudGlhbCBvciBsZWdhbGx5IHByaXZp bGVnZWQgaW5mb3JtYXRpb24gb2YgV0RDIGFuZC9vciBpdHMgYWZmaWxpYXRlcywgYW5kIGFyZSBp bnRlbmRlZCBzb2xlbHkgZm9yIHRoZSB1c2Ugb2YgdGhlIGluZGl2aWR1YWwgb3IgZW50aXR5IHRv IHdoaWNoIHRoZXkgYXJlIGFkZHJlc3NlZC4gSWYgeW91IGFyZSBub3QgdGhlIGludGVuZGVkIHJl Y2lwaWVudCwgYW55IGRpc2Nsb3N1cmUsIGNvcHlpbmcsIGRpc3RyaWJ1dGlvbiBvciBhbnkgYWN0 aW9uIHRha2VuIG9yIG9taXR0ZWQgdG8gYmUgdGFrZW4gaW4gcmVsaWFuY2Ugb24gaXQsIGlzIHBy b2hpYml0ZWQuIElmIHlvdSBoYXZlIHJlY2VpdmVkIHRoaXMgZS1tYWlsIGluIGVycm9yLCBwbGVh c2Ugbm90aWZ5IHRoZSBzZW5kZXIgaW1tZWRpYXRlbHkgYW5kIGRlbGV0ZSB0aGUgZS1tYWlsIGlu IGl0cyBlbnRpcmV0eSBmcm9tIHlvdXIgc3lzdGVtLgo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Manzanares Subject: Re: [PATCH v5 4/4] ata: ATA Command Priority Disabled By Default Date: Thu, 13 Oct 2016 16:37:43 -0700 Message-ID: <20161013233742.GA5854@hgst.com> References: <1476399631-5799-1-git-send-email-adam.manzanares@hgst.com> <1476399631-5799-5-git-send-email-adam.manzanares@hgst.com> <20161013232230.GB32534@mtj.duckdns.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Return-path: Content-Disposition: inline In-Reply-To: <20161013232230.GB32534@mtj.duckdns.org> Sender: linux-block-owner@vger.kernel.org To: Tejun Heo Cc: Adam Manzanares , axboe@kernel.dk, dan.j.williams@intel.com, hare@suse.de, martin.petersen@oracle.com, mchristi@redhat.com, toshi.kani@hpe.com, ming.lei@canonical.com, sathya.prakash@broadcom.com, chaitra.basappa@broadcom.com, suganath-prabu.subramani@broadcom.com, linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org List-Id: linux-ide@vger.kernel.org Hello Tejun, The 10/13/2016 19:22, Tejun Heo wrote: > Hello, Adam. > > Sorry about late reply. Was on vacation. NP I was on vacation at the end of the week last week. > > On Thu, Oct 13, 2016 at 04:00:31PM -0700, Adam Manzanares wrote: > > Add a sysfs entry to turn on priority information being passed > > to a ATA device. By default this feature is turned off. > > > > This patch depends on ata: Enabling ATA Command Priorities > > Looks generally good but can we please use a device attribute name > which is more specific - ie. enable_ncq_prio? Will do, I'll also double check the naming scheme of functions and variables also. The functions that check if the device has the ncq prio capability might be too similar to the function that checks if the device attribute is enabled. > > Thanks. > > -- > tejun Take care, Adam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933938AbcJMXjM (ORCPT ); Thu, 13 Oct 2016 19:39:12 -0400 Received: from esa1.hgst.iphmx.com ([68.232.141.245]:57424 "EHLO esa1.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932235AbcJMXiS (ORCPT ); Thu, 13 Oct 2016 19:38:18 -0400 X-IronPort-AV: E=Sophos;i="5.31,490,1473091200"; d="scan'208";a="25183519" Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Adam.Manzanares@wdc.com; Date: Thu, 13 Oct 2016 16:37:43 -0700 From: Adam Manzanares To: Tejun Heo CC: Adam Manzanares , , , , , , , , , , , , , , , Subject: Re: [PATCH v5 4/4] ata: ATA Command Priority Disabled By Default Message-ID: <20161013233742.GA5854@hgst.com> References: <1476399631-5799-1-git-send-email-adam.manzanares@hgst.com> <1476399631-5799-5-git-send-email-adam.manzanares@hgst.com> <20161013232230.GB32534@mtj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <20161013232230.GB32534@mtj.duckdns.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [199.255.44.173] X-ClientProxiedBy: CO2PR06CA030.namprd06.prod.outlook.com (10.141.242.30) To BY2PR0401MB1719.namprd04.prod.outlook.com (10.163.29.17) X-MS-Office365-Filtering-Correlation-Id: c1a6c449-6725-4f49-80db-08d3f3c1f3ca X-Microsoft-Exchange-Diagnostics: 1;BY2PR0401MB1719;2:ZMff+Kp+Kda3OUgNa5FrSIW/44OUYtdkbeEC0+DLaMitjrF9lnqHEfqAWbPhdhOarO4Q837E6nmKpsrqZda1W+fso/VWvce0PPjb7h7eD5n6dFNKF18Z4u6rDeTVN1Lsd4HpPsa3mcYcFUpVkjYeQJMLpIhATH7B+F8S8QREvTKRuwSBee8rd4kw5VWPKSqXAN5H9BI7OrMiVmXKrClnGg==;3:A9AgF6STIjkW1QpsQbnVFxnntI43jvgy8rLl8NV33Zvx5Kus3FAZqYJDqrOHZP3F373PmQrndvdeD+p0K3d9CNr67kOiQ95gnKJMoHEbrQy44Nw5kVKRKYic1ZH1fU5P0gVEMa10yl/d4mRxBSSZUA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0401MB1719; X-Microsoft-Exchange-Diagnostics: 1;BY2PR0401MB1719;25:oINVwUQmknVJfIeNyQo4jq0s5OFJy93xE9IH/oqWO/Bw0Uv4QgAPGRLV/mi4ZJYkS+tkLp/PezuQ85Gp+t/Qgubao8Z6PvlymFf+mFAnguuIzKLb2+N3lzxJwK8DbWetBmiSZR1pcesCq8YlTzYsHbL86KGg38lQjnmAgbWJj22j5f0CcHCpbxvImsonCJowoNGz7kNlsHjJAoFS1p/8Q56SIHGpA7HedJyEUUcmL2Rhjnf672YWOv2Q7+A9krr9+ub63XEd9Cl5GGKNWja148PGNweL/BEcCZOcr84TDlSKEJyngIs97P+a5KakwKjPeEIUhdtQK2MTHO4uFXeO/7USG5O1ceYraUsmsmzIpD0kSc6vLRcF/PcPb2XoBJUf/6ZfN1ycoM/InEghZjxXOWxM013Bd7MlDVOxXVY1pqw+u4qr5phwk2EidmkKfZwRrjawwpDarcMkp2LbyTxhLIrrFAkFs/jBSzGwDBgfQCDliO2mSha0t78mUtLF1O4zpFuS18bRpbWmxCuOE4bsC6PfJmVmxrdgQS5bNSM219ULn33G3U6RmVki7iurR91JX+wU05pmZg00SbCEEoZ2uLqjOXmp+t1KgB/wSsX5UeGQqDH+4+kOoEROXOF9keF3RLiNQlZOY8n6tgSoCxO8Q7duZ1LIAsfuFIokM3V/Dqub+6cAcjENauxCQfduSHA3AZ8OVOzKniql5Y5EycMPFg== X-Microsoft-Exchange-Diagnostics: 1;BY2PR0401MB1719;31:uwFHlMfw9cWmk7ENBVLVBDKZOxONGvC41av1aAELv0PLdtUQ3RnfNS79A8vaGhG0RRXLC+5XpYJ47YRpoJwPb3cQq2zKI0lWO9YbFAdFfN5QIGMDJpu4iuOXKAcI2hFO629ceRK55l3PJRsIcjEUokZfVbfC8GiSvzPBIKBwGs/nu8XnVWWiIJIDKJCD2LeAxQJDRp3/X8bN8s7Jl1/EjDnXAIVMpbaKjcqxmr7M9K+MzovMHZ4an4iy+9ziDEzU;20:5IZJbBaAa/3yu9dXI6Azqixs4qCrVdCAt6EGUv7E1nFnXfHbXZWmAm5JSrKLKlvU0yP11lvVZBX9NQcDHb5rYZdB2iOYEcWgCk/x+GBrpAshpZV0rEpvPQfJo6FL14L1IY+i1dpml1xdxZT0G5Y76c+R5pIv+VL/5XYV1TX4Y2AXJptIgL3gg628dg7AQk0bbH29xB4lp1up3V/xr9218rJmZ0SZPrFPWDUhmoCVy2vjdQw23wiuI15yokb/sS1jcmxKIAbACPBrmeau06lN7TQvLoWINbWcOqTaR7m/61jLWa8iJNvtw9axdQdg9ty8945yFlzSXmg1yXaNbEclbrDoyPajdoJedg4jz7HzTN62E2qYyc2BZdUhTA9YX18x+r/zzXf/0zTNgfVOhehZhQr/klPWcsesae8uaR3I8jsqTPnyw0C23CjIRe1Krj4GawWwZfFqNYK4W2tjMLpwvMruIovSXvSyOUUwu2g9GMHqqfK+Kl2R22Ym65JCY9ud X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:BY2PR0401MB1719;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0401MB1719; X-Microsoft-Exchange-Diagnostics: 1;BY2PR0401MB1719;4:X7TzaOlXKDJqDHF/JabnTyBplCNikn+rYLyJ5q7rHmk3SJ8gcjHxSmk3Rr4qklw80hOBzEDoujgDkv7HtBR6SbNR5Fd0ySXWzbKID+38A5kcWEBypYkbHpdImx8rnEEkLJJOXbbEVWbXB1fEghaXDj/UxcvikBRyUoHYSxx7j+lMw0uS4HMZeaICAbd8Y6mZzk1pOo7PFI2LmdFxdQ/15lus8lX69iz1cNGKrw0KkX5giY25gxYF4XQwFCnUOxkPsw48rgJIufOThlXeWHj6eWL+JeKX0TI01F01rZ/LpCoc4vk/4HuyqDrmjnSjAbiQAG6amb8RXwLW1PT+Vt/eo3IWCzxYpuNHEG83ATOSpwsz+Hff99Mj8OZtIz8MHQeFuIYeqztEKpDmObXESHYUlQTkhneBhVAwlyz0yRlpkPo= X-Forefront-PRVS: 0094E3478A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(43544003)(24454002)(189002)(199003)(21086003)(2906002)(42186005)(6916009)(2950100002)(105586002)(3846002)(50986999)(110136003)(69596002)(54356999)(23676002)(76176999)(7416002)(5660300001)(101416001)(6666003)(106356001)(36756003)(50466002)(92566002)(66066001)(33656002)(189998001)(86362001)(4326007)(7736002)(47776003)(77096005)(4001350100001)(1076002)(8676002)(97736004)(83506001)(6116002)(9686002)(68736007)(7846002)(81156014)(305945005)(586003)(81166006)(7099028)(18370500001);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR0401MB1719;H:hgst.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjA0MDFNQjE3MTk7MjM6emNTaitIL2ZTc1dBaWhtdUp4bk5EYS9v?= =?utf-8?B?bExpUVlFVUhIVmo2cDVqWTZzakFoMHNXYVhwQm1uK2w5U1NOemxqQk4zSkFx?= =?utf-8?B?Vmx1elVRSms2QzJXb1FtRWdia0NRcXVJQ3VsdG5jclJwWmR0ekR2RjZMZXJQ?= =?utf-8?B?MERrclppNGVlK2JHYm1YMEROOHZoY0lOS2VBKzRQM2NGNzQ4WXNNbFo5R3I0?= =?utf-8?B?TlYvWERCKzREeTVyVGEzREVZa0h0cEk5OHY0eTIrNXA0L1d6OGxXNHJXRHF1?= =?utf-8?B?amlXSEJxbCtoTVpOU1o0ekF6OVlXcmlyeEJtNXdLVklZMEIwQXhWQ2RQcnB1?= =?utf-8?B?UTBKT0R2YVQzYmFrRHFpelFTcDYzKy9QN3lZYzNtc3hqWnFIRGdwZFhwUU5N?= =?utf-8?B?UVhDNnA2K08xdXVtVDQvVk1XcnI0eFZ4NGpOLzRKR21BM3QxNkcxbWNDSktx?= =?utf-8?B?SndDNDdtUXI1Q1lWU0hsaGNDaG9zRytqdmtrN2ZjL1dVK2lVajkzdXRXY2Jx?= =?utf-8?B?QktaUVAwZk5iMGU5d01iQmJuWU84SUtHNTVjKzg5aEJmWk5oS1JuN3lNT3d0?= =?utf-8?B?Y3R5QXduU2IrNzk1TUw1dzExczlkU3dhZUs4L29jMkMyZktwWUwzNHR2TUph?= =?utf-8?B?bDVkZVBRem8zcGx3VGpKYVUrZTRZU1A0UG5PRGpBZzBZMTBPbWcvSXVvTkZu?= =?utf-8?B?SkdJZDB0Y1QwOTNieHo5aHRNblhTWmJJSWVkaWVPMUNyUWwwSkVLYjlhRk9x?= =?utf-8?B?cjduRTNiaVNKdUp5UGdOdi9UU3lLc0U0dStnaVhoRkNnc2lVdFpWZUVkYVho?= =?utf-8?B?bFhUQ3I2NERuQ0dtd0x2TUdTZ0pMSDBsRVNCanZ5Z2k1VjRIZFN5a1dnZmps?= =?utf-8?B?dlM4SE5nN3U4WHhmOE4vYmpxUkRTWVpMS3dIbjJwMXFjR1VEUFFuaVk2SGM1?= =?utf-8?B?Y29oMitLdlMxT21zaWl2b0d4a1RYNXBISGtMZmFZdUh4UTV3OXRCcTZlb1ZT?= =?utf-8?B?ZUlVaWRlL3VmWVVNZ3RDc1hZYnlJS0JwMEZKbldDUEpJRUhUdkZRaUgvYzN6?= =?utf-8?B?Wm1CZndqOXJzVG8rdUtoL0x1M0tvMDhRT0ZZNnVZc3BKdlA0RS9FL1B3blhs?= =?utf-8?B?bTFZKzlPcTdQVHpYakdtUlk3VWozUGNiTUd6aUtsN3hzVEFCVUJ4NjBiNXl4?= =?utf-8?B?R3Vwc05SbXhFb3U4M3JJZU9hYW0zek8vNzFtOHR5RWQwMThiL08zVDhPYXl0?= =?utf-8?B?Tk56U3JRdWw5bzJ1M0diSDhVYVFINjFTWVB2dWU4RUdTdzBwYzZzR2xMT2NI?= =?utf-8?B?VU5nck9KTjFNMXg2VU9KSG5QWFltS1JGTE9YOHdWamh4dHBnQTlaODlyWXZJ?= =?utf-8?B?aVdlcm1YTndpRzRITWhncTExMThOdGJaaDBDYmkybk8zTW1qNGVubVRQTW1K?= =?utf-8?B?WGNFM29YQldFNnBYbG9PcDZOcnB4Tmtla0tRZkNpSVZwTzA3V0RidENWcHVW?= =?utf-8?B?OTd4UXpJMUE5SWFpZkQvZmcwY0lUTE1KaFRoSFNJYXdhNUlqdEx5aisrYVlC?= =?utf-8?B?S0tRRFh4MWtEbFBRc3FOSnBWUk4xWFIzcW1WQllSNHBrTFFOVzlUVWFyZHJN?= =?utf-8?Q?0zLKqCgxbeU2srptYMfpOv?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR0401MB1719;6:QwqOiFBdX1ClgYTECXuFF17sPn2YgVccmhvfGVcV6HTix4Zg8hdMOnrKv6I/oXwyt9AcgQAWWJu3sRRGRVI+EpHKubf60eMxDuk7gIN6Ah51JVNJ/okxjqtT4X2EzOxgGGLwnL+MBTc1JpVxRTKyn+eymsiXCXcG0n5Fzb4Mz7T3fax9X+M7FgWDPMUBQ6ojKvffGgSCvoEMk36HGuS/yMM+vUVnmLF1Xdtmn9QHzbQwO4zfG1LjiSmLvW1GoVbHjoSpcX05Q0VuW9yicwwUcd74A2tsnTZrTyr8EUEQBdpjepDruL5nTK5D2fFnqQ3Ubu+ItkGrIfkoVmFYYY99hA==;5:BR1Dibpci0w1FDREOsc0E3TtVa7ldropt+6gPMcQ/+xe+QQ+KA0iYg5AVB4kQU+4JZTjjxhQmxmPdvZjvQ0j8c7p5rFPoskVXW4tFXBg/JKRcKdYKA72ryehOTJ3qynN0kHO4KZYPQSP/sQm5/xhUXmaSNSURj9ZnNjcwojczGM=;24:abcebRlxKkuLeDInfqknMNkPsyyGbxL6BLHYqmAUgn2b5Vj/7whBe/aq45n0ZVsNzI8Neazmp+uXHYY7bCiSL6sjseaz/I2NLBySju+mj/I= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY2PR0401MB1719;7:zSuQ8bD8XKpvbJiQ0OyfhGeqvezuFDdQaaorbx0MbEL+nJoeSx6GvP7WsINhSCwJKoa5qrfRA/euKbeEaoID1SAo/2xerN+23vtXf+vohFQ3mREv+SVk2C2blfElURw2VcOVke4tAoW6LGSGLRWzwTUHnAYxucW+fR4u4jAGZrTI1dMUE1uNrT2ZJSkDzeEm+aT8YkG/L1rDFGWnqLXWTBCAMnoq6Rk0yeXptV57F4kf841X1pKaDpN56Ajf4uvp3t7qgoZb0Nfb7hwluzcVqxDonVxHYfYMbc82zN4CsGq63n0Kgm50QXsoF5H156SGtJrC3q4VyczrRyOjTKYOxIU0n7aP/bE1aHQIgfDJWxs=;20:kHWKsDEOZwSig3+63TkWmjy7MECGFTnnjTqf1fgGfpNtmmFSkDHvBjZ3wVNv3PunBLbnOQhaG0RcjImMJyscGmzEMueHa6A56Engu7YyXUEO5Rlyo00fhcMNzwoUEc/J1CjL3q1zWxN5c03c624vUVkI0Szb0KTrJIYZmdO/yMQJdJPpIeOfe/MTek64rR+rk2/70XjNAxboSp3ytuNkR1jtgLhupVxzVjpDLGn7bP5VPaYmPdWm8keSk5LeAjwJ X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2016 23:37:52.4346 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0401MB1719 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Tejun, The 10/13/2016 19:22, Tejun Heo wrote: > Hello, Adam. > > Sorry about late reply. Was on vacation. NP I was on vacation at the end of the week last week. > > On Thu, Oct 13, 2016 at 04:00:31PM -0700, Adam Manzanares wrote: > > Add a sysfs entry to turn on priority information being passed > > to a ATA device. By default this feature is turned off. > > > > This patch depends on ata: Enabling ATA Command Priorities > > Looks generally good but can we please use a device attribute name > which is more specific - ie. enable_ncq_prio? Will do, I'll also double check the naming scheme of functions and variables also. The functions that check if the device has the ncq prio capability might be too similar to the function that checks if the device attribute is enabled. > > Thanks. > > -- > tejun Take care, Adam