From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:37020 "EHLO
        ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753761AbcJNDob (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Thu, 13 Oct 2016 23:44:31 -0400
Date: Fri, 14 Oct 2016 03:49:05 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>,
        Miklos Szeredi <mszeredi@redhat.com>,
        CAI Qian <caiqian@redhat.com>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] overlayfs: Fix setting IOP_XATTR flag
Message-ID: <20161014024905.GY19539@ZenIV.linux.org.uk>
References: <1476407016-4993-1-git-send-email-agruenba@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1476407016-4993-1-git-send-email-agruenba@redhat.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Fri, Oct 14, 2016 at 03:03:36AM +0200, Andreas Gruenbacher wrote:
> From: Vivek Goyal <vgoyal@redhat.com>
> 
> ovl_fill_super calls ovl_new_inode to create a root inode for the new
> superblock before initializing sb->s_xattr.  This wrongly causes
> IOP_XATTR to be cleared in i_opflags of the new inode, causing SELinux
> to log the following message:
> 
>   SELinux: (dev overlay, type overlay) has no xattr support
> 
> Fix this by initializing sb->s_xattr and similar fields before calling
> ovl_new_inode.

Applied.