Re: [PATCH] staging: vt6655: Fix line over 80 characters.

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Oct 14, 2016 at 03:21:24AM +0530, Varsha Rao wrote:
> This patch fixes the checkpatch warning of line over 80 characters.
> 
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> ---
>  drivers/staging/vt6655/mac.c |   3 +-
>  drivers/staging/vt6655/rf.c  | 737 +++++++++++++++++++++++++++++--------------
>  2 files changed, 495 insertions(+), 245 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c
> index 4aaa99b..23de67c 100644
> --- a/drivers/staging/vt6655/mac.c
> +++ b/drivers/staging/vt6655/mac.c
> @@ -315,7 +315,8 @@ bool MACbSoftwareReset(struct vnt_private *priv)
>   */
>  bool MACbSafeSoftwareReset(struct vnt_private *priv)
>  {
> -	unsigned char abyTmpRegData[MAC_MAX_CONTEXT_SIZE_PAGE0 + MAC_MAX_CONTEXT_SIZE_PAGE1];
> +	unsigned char abyTmpRegData[MAC_MAX_CONTEXT_SIZE_PAGE0 +
> +				    MAC_MAX_CONTEXT_SIZE_PAGE1];
>  	bool bRetVal;
>  
>  	/* PATCH....
> diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
> index 1762c05..2e0e0c2 100644
> --- a/drivers/staging/vt6655/rf.c
> +++ b/drivers/staging/vt6655/rf.c
> @@ -63,37 +63,65 @@ static const unsigned long dwAL2230InitTable[CB_AL2230_INIT_SEQ] = {
>  };
>  
>  static const unsigned long dwAL2230ChannelTable0[CB_MAX_CHANNEL] = {
> -	0x03F79000 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW, /* channel = 1, Tf = 2412MHz */
> -	0x03F79000 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW, /* channel = 2, Tf = 2417MHz */
> -	0x03E79000 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW, /* channel = 3, Tf = 2422MHz */
> -	0x03E79000 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW, /* channel = 4, Tf = 2427MHz */
> -	0x03F7A000 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW, /* channel = 5, Tf = 2432MHz */
> -	0x03F7A000 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW, /* channel = 6, Tf = 2437MHz */
> -	0x03E7A000 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW, /* channel = 7, Tf = 2442MHz */
> -	0x03E7A000 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW, /* channel = 8, Tf = 2447MHz */
> -	0x03F7B000 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW, /* channel = 9, Tf = 2452MHz */
> -	0x03F7B000 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW, /* channel = 10, Tf = 2457MHz */
> -	0x03E7B000 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW, /* channel = 11, Tf = 2462MHz */
> -	0x03E7B000 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW, /* channel = 12, Tf = 2467MHz */
> -	0x03F7C000 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW, /* channel = 13, Tf = 2472MHz */
> -	0x03E7C000 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW  /* channel = 14, Tf = 2412M */
> +	/* channel = 1, Tf = 2412MHz */
> +	0x03F79000 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
> +	/* channel = 2, Tf = 2417MHz */
> +	0x03F79000 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
> +	/* channel = 3, Tf = 2422MHz */

People keep trying to "fix" these lines.  Please just leave them as-is,
it's much easier to read them in the old way, right?  And that takes
precedence over the "obey checkpatch.pl" movement.

thanks,

greg k-h