Re: [kvm-unit-tests PATCH v7 12/13] pci: Add pci-testdev PCI bus test device

[Peter Xu <peterx@redhat.com>]

On Fri, Oct 14, 2016 at 09:07:07AM +0200, Andrew Jones wrote:
> On Fri, Oct 14, 2016 at 01:01:48PM +0800, Peter Xu wrote:
> > On Thu, Oct 13, 2016 at 03:16:49PM +0200, Alexander Gordeev wrote:
> > > On Thu, Oct 13, 2016 at 02:52:49PM +0800, Peter Xu wrote:
> > > > On Wed, Oct 12, 2016 at 06:54:28PM +0200, Alexander Gordeev wrote:
> > > > > On Fri, Sep 23, 2016 at 03:25:42PM +0800, Peter Xu wrote:
> > > > > > > +	width = ops->io_readb(&test->width);
> > > > > > > +	if (width != 1 && width != 2 && width != 4)
> > > > > > > +		return false;
> > > > > > 
> > > > > > IIUC we only have 1?
> > > > > 
> > > > > I guess it boils what *have* does mean here.
> > > > > 
> > > > > pci-testdev protocol allows it to be any, but hw/misc/pci-testdev.c
> > > > > implements just 1 (yet?).
> > > > 
> > > > Do we have other possible implementations for pci-testdev protocol?
> > > 
> > > I typed answer twice, but realized I do not get the question. :)
> > > Could you paraphrase, please?
> > 
> > Sorry for not being clear. I am just wondering whether there is other
> > implementation for pci-testdev besides the one in QEMU. It looks like
> > a special device to test QEMU only.
> 
> Yes. pci-testdev (most likely) has never been implemented anywhere other
> than in QEMU. It was written specifically for kvm-unit-tests. See
> 
> http://www.linux-kvm.org/page/KVM-unit-tests#Testdevs
> 
> for a synopsis of all testdevs. Please feel free to add more details to
> the pci-testdev section. Feel free to help maintain the document in any
> other ways too, of course :-)

Thanks, Drew.

I am trying to use edu device for testing Intel IOMMU. I'll try to
post RFC patches first though. When needed, I can update the document
for edu device (though I still don't know how to do that).

-- peterx