From: Jiri Benc <jbenc@redhat.com>
To: Tom Herbert <tom@herbertland.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<roopa@cumulusnetworks.com>, <kernel-team@fb.com>
Subject: Re: [PATCH net-next 1/2] lwtunnel: Add destroy state operation
Date: Fri, 14 Oct 2016 10:59:47 +0200 [thread overview]
Message-ID: <20161014105948.2a53c2cd@griffin> (raw)
In-Reply-To: <20161014005743.288956-2-tom@herbertland.com>
On Thu, 13 Oct 2016 17:57:42 -0700, Tom Herbert wrote:
> @@ -43,13 +44,11 @@ struct lwtunnel_encap_ops {
> int (*get_encap_size)(struct lwtunnel_state *lwtstate);
> int (*cmp_encap)(struct lwtunnel_state *a, struct lwtunnel_state *b);
> int (*xmit)(struct sk_buff *skb);
> + void (*destroy_state)(struct lwtunnel_state *lws);
> };
Could you add destroy_state next to build_state? Seems weird to have
those two scattered at the opposite ends of the structure. Looks good
otherwise.
Thanks,
Jiri
next prev parent reply other threads:[~2016-10-14 8:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 0:57 [PATCH net-next 0/2] ila: Cache a route in ILA lwt structure Tom Herbert
2016-10-14 0:57 ` [PATCH net-next 1/2] lwtunnel: Add destroy state operation Tom Herbert
2016-10-14 5:58 ` Roopa Prabhu
2016-10-14 8:59 ` Jiri Benc [this message]
2016-10-14 15:15 ` David Miller
2016-10-14 0:57 ` [PATCH net-next 2/2] ila: Cache a route to translated address Tom Herbert
2016-10-14 6:22 ` Roopa Prabhu
2016-10-14 9:04 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161014105948.2a53c2cd@griffin \
--to=jbenc@redhat.com \
--cc=davem@davemloft.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.