From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 03/10] core: offload handling of BR2_EXTERNAL into the script
Date: Fri, 14 Oct 2016 11:29:36 +0200 [thread overview]
Message-ID: <20161014112936.272bf8e3@free-electrons.com> (raw)
In-Reply-To: <7715d5d66e4d09a1d56432fcbbd8578bdade0663.1475399381.git.yann.morin.1998@free.fr>
Hello,
On Sun, 2 Oct 2016 11:09:52 +0200, Yann E. MORIN wrote:
> +$(shell support/scripts/br2-external \
> + -m \
> + -o '${BR2_EXTERNAL_FILE}' \
> + $(BR2_EXTERNAL))
Excessive newline usage here. Also, why ${} instead of $() ?
> +BR2_EXTERNAL_ERROR =
> +include $(BR2_EXTERNAL_FILE)
> +ifneq ($(BR2_EXTERNAL_ERROR),)
> +$(error $(BR2_EXTERNAL_ERROR))
> endif
I don't really like this BR2_EXTERNAL_ERROR variable that gets written
in the .mk file by the br2-external script if it fails, and then
re-used here. But I'm not sure I have a better proposal.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-10-14 9:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-02 9:09 [Buildroot] [PATCH 00/10 v6] br2-external: support multiple trees at once Yann E. MORIN
2016-10-02 9:09 ` [Buildroot] [PATCH 01/10] core: do not hard-code inclusion of br2-external in Kconfig Yann E. MORIN
2016-10-02 9:09 ` [Buildroot] [PATCH 02/10] core: get rid of our dummy br2-external tree Yann E. MORIN
2016-10-02 9:09 ` [Buildroot] [PATCH 03/10] core: offload handling of BR2_EXTERNAL into the script Yann E. MORIN
2016-10-14 9:29 ` Thomas Petazzoni [this message]
2016-10-02 9:09 ` [Buildroot] [PATCH 04/10] core/br2-external: validate even more Yann E. MORIN
2016-10-02 9:09 ` [Buildroot] [PATCH 05/10] core: introduce per br2-external NAME Yann E. MORIN
2016-10-02 9:09 ` [Buildroot] [PATCH 06/10] docs/manual: document the " Yann E. MORIN
2016-10-02 9:09 ` [Buildroot] [PATCH 07/10] docs/manual: add appendix to convert old br2-external trees Yann E. MORIN
2016-10-02 9:09 ` [Buildroot] [PATCH 08/10] core: add support for multiple " Yann E. MORIN
2016-10-02 9:09 ` [Buildroot] [PATCH 09/10] docs/manual: document multi br2-external Yann E. MORIN
2016-10-02 9:09 ` [Buildroot] [PATCH 10/10] core: allow a br2-external tree to override a defconfig Yann E. MORIN
-- strict thread matches above, loose matches on Subject: below --
2016-09-25 14:52 [Buildroot] [PATCH 00/10 v5] br2-external: support multiple trees at once Yann E. MORIN
2016-09-25 14:52 ` [Buildroot] [PATCH 03/10] core: offload handling of BR2_EXTERNAL into the script Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161014112936.272bf8e3@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.