From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [RFC PATCH 00/11] Introduce writeback connectors Date: Fri, 14 Oct 2016 15:50:18 +0300 Message-ID: <20161014125018.GD4329@intel.com> References: <1476197648-24918-1-git-send-email-brian.starkey@arm.com> <6e794da8-49de-0440-ea70-272bfe47332b@codeaurora.org> <20161014123914.GA10745@e106950-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id CFE3F6EC63 for ; Fri, 14 Oct 2016 12:50:23 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20161014123914.GA10745@e106950-lin.cambridge.arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Brian Starkey Cc: liviu.dudau@arm.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, hverkuil@xs4all.nl, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBPY3QgMTQsIDIwMTYgYXQgMDE6Mzk6MTVQTSArMDEwMCwgQnJpYW4gU3RhcmtleSB3 cm90ZToKPiBIaSBBcmNoaXQsCj4gCj4gT24gRnJpLCBPY3QgMTQsIDIwMTYgYXQgMDQ6MjA6MTRQ TSArMDUzMCwgQXJjaGl0IFRhbmVqYSB3cm90ZToKPiA+SGkgQnJpYW4sCj4gPgo+ID5PbiAxMC8x MS8yMDE2IDA4OjIzIFBNLCBCcmlhbiBTdGFya2V5IHdyb3RlOgo+ID4+SGksCj4gPj4KPiA+PlRo aXMgUkZDIHNlcmllcyBpbnRyb2R1Y2VzIGEgbmV3IGNvbm5lY3RvciB0eXBlOgo+ID4+IERSTV9N T0RFX0NPTk5FQ1RPUl9XUklURUJBQ0sKPiA+Pkl0IGlzIGEgZm9sbG93LW9uIGZyb20gYSBwcmV2 aW91cyBkaXNjdXNzaW9uOiBbMV0KPiA+Pgo+ID4+V3JpdGViYWNrIGNvbm5lY3RvcnMgYXJlIHVz ZWQgdG8gZXhwb3NlIHRoZSBtZW1vcnkgd3JpdGViYWNrIGVuZ2luZXMKPiA+PmZvdW5kIGluIHNv bWUgZGlzcGxheSBjb250cm9sbGVycywgd2hpY2ggY2FuIHdyaXRlIGEgQ1JUQydzCj4gPj5jb21w b3NpdGlvbiByZXN1bHQgdG8gYSBtZW1vcnkgYnVmZmVyLgo+ID4+VGhpcyBpcyB1c2VmdWwgZS5n LiBmb3IgdGVzdGluZywgc2NyZWVuLXJlY29yZGluZywgc2NyZWVuc2hvdHMsCj4gPj53aXJlbGVz cyBkaXNwbGF5LCBkaXNwbGF5IGNsb25pbmcsIG1lbW9yeS10by1tZW1vcnkgY29tcG9zaXRpb24u Cj4gPj4KPiA+PlBhdGNoZXMgMS03IGluY2x1ZGUgdGhlIGNvcmUgZnJhbWV3b3JrIGNoYW5nZXMg cmVxdWlyZWQsIGFuZCBwYXRjaGVzCj4gPj44LTExIGltcGxlbWVudCBhIHdyaXRlYmFjayBjb25u ZWN0b3IgZm9yIHRoZSBNYWxpLURQIHdyaXRlYmFjayBlbmdpbmUuCj4gPj5UaGUgTWFsaS1EUCBw YXRjaGVzIGRlcGVuZCBvbiB0aGlzIG90aGVyIHNlcmllczogWzJdLgo+ID4+Cj4gPj5UaGUgY29u bmVjdG9yIGlzIGdpdmVuIHRoZSBGQl9JRCBwcm9wZXJ0eSBmb3IgdGhlIG91dHB1dCBmcmFtZWJ1 ZmZlciwKPiA+PmFuZCB0d28gbmV3IHJlYWQtb25seSBwcm9wZXJ0aWVzOiBQSVhFTF9GT1JNQVRT IGFuZAo+ID4+UElYRUxfRk9STUFUU19TSVpFLCB3aGljaCBleHBvc2UgdGhlIHN1cHBvcnRlZCBm cmFtZWJ1ZmZlciBwaXhlbAo+ID4+Zm9ybWF0cyBvZiB0aGUgZW5naW5lLgo+ID4+Cj4gPj5UaGUg RURJRCBwcm9wZXJ0eSBpcyBub3QgZXhwb3NlZCBmb3Igd3JpdGViYWNrIGNvbm5lY3RvcnMuCj4g Pj4KPiA+PldyaXRlYmFjayBjb25uZWN0b3IgdXNhZ2U6Cj4gPj4tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLQo+ID4+RHVlIHRvIGNvbm5lY3RvciByb3V0aW5nIGNoYW5nZXMgYmVpbmcgdHJlYXRl ZCBhcyAiZnVsbCBtb2Rlc2V0Igo+ID4+b3BlcmF0aW9ucywgYW55IGNsaWVudCB3aGljaCB3aXNo ZXMgdG8gdXNlIGEgd3JpdGViYWNrIGNvbm5lY3Rvcgo+ID4+c2hvdWxkIGluY2x1ZGUgdGhlIGNv bm5lY3RvciBpbiBldmVyeSBtb2Rlc2V0LiBUaGUgd3JpdGViYWNrIHdpbGwgbm90Cj4gPj5hY3R1 YWxseSBiZWNvbWUgYWN0aXZlIHVudGlsIGEgZnJhbWVidWZmZXIgaXMgYXR0YWNoZWQuCj4gPj4K PiA+PlRoZSB3cml0ZWJhY2sgaXRzZWxmIGlzIGVuYWJsZWQgYnkgYXR0YWNoaW5nIGEgZnJhbWVi dWZmZXIgdG8gdGhlCj4gPj5GQl9JRCBwcm9wZXJ0eSBvZiB0aGUgY29ubmVjdG9yLiBUaGUgZHJp dmVyIG11c3QgdGhlbiBlbnN1cmUgdGhhdCB0aGUKPiA+PkNSVEMgY29udGVudCBvZiB0aGF0IGF0 b21pYyBjb21taXQgaXMgd3JpdHRlbiBpbnRvIHRoZSBmcmFtZWJ1ZmZlci4KPiA+Pgo+ID4+VGhl IHdyaXRlYmFjayB3b3JrcyBpbiBhIG9uZS1zaG90IG1vZGUgd2l0aCBlYWNoIGF0b21pYyBjb21t aXQuIFRoaXMKPiA+PnByZXZlbnRzIHRoZSBzYW1lIGNvbnRlbnQgZnJvbSBiZWluZyB3cml0dGVu IG11bHRpcGxlIHRpbWVzLgo+ID4+SW4gc29tZSBjYXNlcyAoZnJvbnQtYnVmZmVyIHJlbmRlcmlu ZykgdGhlcmUgbWlnaHQgYmUgYSBkZXNpcmUgZm9yCj4gPj5jb250aW51b3VzIG9wZXJhdGlvbiAt IEkgdGhpbmsgYSBwcm9wZXJ0eSBjb3VsZCBiZSBhZGRlZCBsYXRlciBmb3IKPiA+PnRoaXMga2lu ZCBvZiBjb250cm9sLgo+ID4+Cj4gPj5Xcml0ZWJhY2sgY2FuIGJlIGRpc2FibGVkIGJ5IHNldHRp bmcgRkJfSUQgdG8gemVyby4KPiA+Pgo+ID4+S25vd24gaXNzdWVzOgo+ID4+LS0tLS0tLS0tLS0t LQo+ID4+ICogSSdtIG5vdCBzdXJlIHdoYXQgIkRQTVMiIHNob3VsZCBtZWFuIGZvciB3cml0ZWJh Y2sgY29ubmVjdG9ycy4KPiA+PiAgIEl0IGNvdWxkIGJlIHVzZWQgdG8gZGlzYWJsZSB3cml0ZWJh Y2sgKGV2ZW4gd2hlbiBhIGZyYW1lYnVmZmVyIGlzCj4gPj4gICBhdHRhY2hlZCksIG9yIGl0IGNv dWxkIGJlIGhpZGRlbiBlbnRpcmVseSAod2hpY2ggd291bGQgYnJlYWsgdGhlCj4gPj4gICBsZWdh Y3kgRFBNUyBjYWxsIGZvciB3cml0ZWJhY2sgY29ubmVjdG9ycykuCj4gPj4gKiBXaXRoIERhbmll bCdzIHJlY2VudCByZS1pdGVyYXRpb24gb2YgdGhlIHVzZXJzcGFjZSBBUEkgcnVsZXMsIEkKPiA+ PiAgIGZ1bGx5IGV4cGVjdCB0byBwcm92aWRlIHNvbWUgdXNlcnNwYWNlIGNvZGUgdG8gc3VwcG9y dCB0aGlzLiBUaGUKPiA+PiAgIHF1ZXN0aW9uIGlzIHdoYXQsIGFuZCB3aGVyZT8gV2Ugd2FudCB0 byB1c2Ugd3JpdGViYWNrIGZvciB0ZXN0aW5nLAo+ID4+ICAgc28gcGVyaGFwcyBzb21lIHRlc3Rz IGluIGlndCBpcyBzdWl0YWJsZS4KPiA+PiAqIERvY3VtZW50YXRpb24uIFByb2JhYmx5IHNvbWUg cG9ydGlvbiBvZiB0aGlzIGNvdmVyIGxldHRlciBuZWVkcyB0bwo+ID4+ICAgbWFrZSBpdCBpbnRv IERvY3VtZW50YXRpb24vCj4gPj4gKiBTeW5jaHJvbmlzYXRpb24uIE91ciBoYXJkd2FyZSB3aWxs IGZpbmlzaCB0aGUgd3JpdGViYWNrIGJ5IHRoZSBuZXh0Cj4gPj4gICB2c3luYy4gSSd2ZSBub3Qg aW1wbGVtZW50ZWQgZmVuY2Ugc3VwcG9ydCBoZXJlLCBidXQgaXQgd291bGQgYmUgYW4KPiA+PiAg IG9idmlvdXMgYWRkaXRpb24uCj4gPj4KPiA+PlNlZSBBbHNvOgo+ID4+LS0tLS0tLS0tCj4gPj5b MV0gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvYXJjaGl2ZXMvZHJpLWRldmVsLzIwMTYt SnVseS8xMTMxOTcuaHRtbAo+ID4+WzJdIGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL2Fy Y2hpdmVzL2RyaS1kZXZlbC8yMDE2LU9jdG9iZXIvMTIwNDg2Lmh0bWwKPiA+Pgo+ID4+SSB3ZWxj b21lIGFueSBjb21tZW50cywgZXNwZWNpYWxseSBpZiB0aGlzIGFwcHJvYWNoIGRvZXMvZG9lc24n dCBmaXQKPiA+PndlbGwgd2l0aCBhbnlvbmUgZWxzZSdzIGhhcmR3YXJlLgo+ID4KPiA+VGhhbmtz IGZvciB3b3JraW5nIG9uIHRoaXMhIFNvbWUgcG9pbnRzIGJlbG93Lgo+ID4KPiA+LSBXcml0ZWJh Y2sgaGFyZHdhcmUgZ2VuZXJhbGx5IGFsbG93cyB1cyB0byBzcGVjaWZ5IHRoZSByZWdpb24gd2l0 aGluCj4gPnRoZSBmcmFtZWJ1ZmZlciB3ZSB3YW50IHRvIHdyaXRlIHRvLiBJdCdzIGFuYWxvZ291 cyB0byB0aGUgU1JDX1gvWS9XL0gKPiA+cGxhbmUgcHJvcGVydGllcy4gV2UgY291bGQgaGF2ZSBz aW1pbGFyIHByb3BzIGZvciB0aGUgd3JpdGViYWNrCj4gPmNvbm5lY3RvcnMsIGFuZCBtYXliZSBz ZXQgdGhlbSB0byB0aGUgRkJfSUQgZGltZW5zaW9ucyBpZiB0aGV5IGFyZW4ndAo+ID5jb25maWd1 cmVkIGJ5IHVzZXJzcGFjZS4KPiA+Cj4gPi0gQmVzaWRlcyB0aGUgYWJvdmUgcHJvcGVydHksIHdy aXRlYmFjayBoYXJkd2FyZSBjYW4gaGF2ZSBwcm92aXNpb25zCj4gPmZvciBzY2FsaW5nLCBjb2xv ciBzcGFjZSBjb252ZXJzaW9uIGFuZCByb3RhdGlvbi4gVGhpcyB3b3VsZCBtZWFuIHRoYXQKPiA+ d2UnZCBldmVudHVhbGx5IGFkZCBtb3JlIHdyaXRlYmFjayBzcGVjaWZpYyBwcm9wcy9wYXJhbXMg aW4KPiA+ZHJtX2Nvbm5lY3Rvci9kcm1fY29ubmVjdG9yX3N0YXRlLiBXb3VsZCB3ZSBiZSBva2F5 IGFkZGluZyBtb3JlIHN1Y2gKPiA+cHJvcHMgZm9yIGNvbm5lY3RvcnM/Cj4gCj4gSSd2ZSB3b25k ZXJlZCB0aGUgc2FtZSB0aGluZyBhYm91dCBibG9hdGluZyBub24td3JpdGViYWNrIGNvbm5lY3Rv cnMKPiB3aXRoIHdyaXRlYmFjay1zcGVjaWZpYyBzdHVmZi4gSWYgaXQgZG9lcyBiZWNvbWUgc2ln bmlmaWNhbnQsIG1heWJlCj4gd2Ugc2hvdWxkIHN1YmNsYXNzIGRybV9jb25uZWN0b3IgYW5kIGFk ZCBhIGRybV93cml0ZWJhY2tfc3RhdGUgcG9pbnRlcgo+IHRvIGRybV9jb25uZWN0b3Jfc3RhdGUu Cj4gCj4gVmlsbGUgdG91Y2hlZCBvbiBzY2FsaW5nIHN1cHBvcnQgcHJldmlvdXNseSwgc3VnZ2Vz dGluZyBhZGRpbmcgYQo+IGZpeGVkX21vZGUgcHJvcGVydHkgKGZvciBhbGwgdHlwZXMgb2YgY29u bmVjdG9ycykgLSBvbiB3cml0ZWJhY2sgdGhpcwo+IHdvdWxkIHJlcHJlc2VudCBzY2FsaW5nIHRo ZSBmcmFtZWJ1ZmZlciwgYW5kIG9uIG5vcm1hbCBjb25uZWN0b3JzIGl0Cj4gY291bGQgY29udHJv bCBvdXRwdXQgc2NhbGluZyAobGlrZSBwYW5lbC1maXR0aW5nKS4KCldlIGdvdCBzb21lIHBhdGNo ZXMgWzFdIHBvc3RlZCBmb3IgaTkxNSByZWNlbnRseSB0aGF0IGFkZGVkIGEgYnVuY2ggb2YgbmV3 CnByb3BlcnRpZXMgdG8gY29udHJvbCBwb3N0LWJsZW5kaW5nIHNjYWxpbmcsIGJ1dCBJJ20gbm90 IHN1cmUgSSBsaWtlIHRoZQphcHByb2FjaCBzaW5jZSBpdCBzZWVtcyBoYXJkZXIgdG8gcmVjb25j aWxlIHdpdGggdGhlIGN1cnJlbnQgd2F5IHdlIGRlYWwKd2l0aCBzY2FsaW5nIGZvciBlRFAvTFZE Uy9EU0kvZXRjLiBTbyBJJ20gc3RpbGwgc29tZXdoYXQgcGFydGlhbCB0byB0aGUKZml4ZWQgbW9k ZSBpZGVhLiBKdXN0IEZZSS4KClsxXSBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9hcmNo aXZlcy9pbnRlbC1nZngvMjAxNi1BdWd1c3QvMTA1NTU3Lmh0bWwKCj4gCj4gQ2VydGFpbmx5IGRl c3RpbmF0aW9uIGNvb3JkcywgY29sb3Itc3BhY2UgY29udmVyc3Rpb24gZXRjLiBhcmUgdGhpbmdz Cj4gdGhhdCBhcmUgd29ydGggYWRkaW5nLCBidXQgSU1PIEknZCByYXRoZXIga2VlcCB0aGlzIGlu aXRpYWwKPiBpbXBsZW1lbnRhdGlvbiBzbWFsbCBzbyB3ZSBjYW4gZW5hYmxlIHRoZSBiYXNpYyBj YXNlIHJpZ2h0IGF3YXkuIEZvcgo+IHRoZSBtb3N0IHBhcnQsIHRoZSBhZGRpdGlvbmFsIHRoaW5n cyBhcmUgImp1c3QgcHJvcGVydGllcyIgd2hpY2gKPiBzaG91bGQgYmUgZWFzaWx5IGFkZGVkIGxh dGVyIHdpdGhvdXQgaW1wYWN0aW5nIHRoZSBvdmVyYWxsIGludGVyZmFjZS4KPiAKPiBDaGVlcnMs Cj4gQnJpYW4KPiA+Cj4gPlRoYW5rcywKPiA+QXJjaGl0Cj4gPgo+ID4+Cj4gPj5UaGFua3MsCj4g Pj4KPiA+Pi1Ccmlhbgo+ID4+Cj4gPj4tLS0KPiA+Pgo+ID4+QnJpYW4gU3RhcmtleSAoMTApOgo+ ID4+ICBkcm06IGFkZCB3cml0ZWJhY2sgY29ubmVjdG9yIHR5cGUKPiA+PiAgZHJtL2ZiLWhlbHBl cjogc2tpcCB3cml0ZWJhY2sgY29ubmVjdG9ycwo+ID4+ICBkcm06IGV4dHJhY3QgQ1JUQy9wbGFu ZSBkaXNhYmxlIGZyb20gZHJtX2ZyYW1lYnVmZmVyX3JlbW92ZQo+ID4+ICBkcm06IGFkZCBfX2Ry bV9mcmFtZWJ1ZmZlcl9yZW1vdmVfYXRvbWljCj4gPj4gIGRybTogYWRkIGZiIHRvIGNvbm5lY3Rv ciBzdGF0ZQo+ID4+ICBkcm06IGV4cG9zZSBmYl9pZCBwcm9wZXJ0eSBmb3Igd3JpdGViYWNrIGNv bm5lY3RvcnMKPiA+PiAgZHJtOiBhZGQgd3JpdGViYWNrLWNvbm5lY3RvciBwaXhlbCBmb3JtYXQg cHJvcGVydGllcwo+ID4+ICBkcm06IG1hbGktZHA6IHJlbmFtZSBtYWxpZHBfaW5wdXRfZm9ybWF0 Cj4gPj4gIGRybTogbWFsaS1kcDogYWRkIFJHQiB3cml0ZWJhY2sgZm9ybWF0cyBmb3IgRFA1NTAv RFA2NTAKPiA+PiAgZHJtOiBtYWxpLWRwOiBhZGQgd3JpdGViYWNrIGNvbm5lY3Rvcgo+ID4+Cj4g Pj5MaXZpdSBEdWRhdSAoMSk6Cj4gPj4gIGRybTogbWFsaS1kcDogQWRkIHN1cHBvcnQgZm9yIHdy aXRlYmFjayBvbiBEUDU1MC9EUDY1MAo+ID4+Cj4gPj4gZHJpdmVycy9ncHUvZHJtL2FybS9NYWtl ZmlsZSAgICAgICAgfCAgICAxICsKPiA+PiBkcml2ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9jcnRj LmMgICB8ICAgMTAgKysKPiA+PiBkcml2ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9kcnYuYyAgICB8 ICAgMjUgKysrLQo+ID4+IGRyaXZlcnMvZ3B1L2RybS9hcm0vbWFsaWRwX2Rydi5oICAgIHwgICAg NSArCj4gPj4gZHJpdmVycy9ncHUvZHJtL2FybS9tYWxpZHBfaHcuYyAgICAgfCAgMTA0ICsrKysr KysrKystLS0tCj4gPj4gZHJpdmVycy9ncHUvZHJtL2FybS9tYWxpZHBfaHcuaCAgICAgfCAgIDI3 ICsrKy0KPiA+PiBkcml2ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9tdy5jICAgICB8ICAyNjggKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiA+PiBkcml2ZXJzL2dwdS9kcm0vYXJt L21hbGlkcF9wbGFuZXMuYyB8ICAgIDggKy0KPiA+PiBkcml2ZXJzL2dwdS9kcm0vYXJtL21hbGlk cF9yZWdzLmggICB8ICAgMTUgKysKPiA+PiBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jICAg ICAgICB8ICAgNDAgKysrKysrCj4gPj4gZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVy LmMgfCAgICA0ICsKPiA+PiBkcml2ZXJzL2dwdS9kcm0vZHJtX2Nvbm5lY3Rvci5jICAgICB8ICAg NzkgKysrKysrKysrKy0KPiA+PiBkcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYyAgICAgICAgICB8 ICAgMTQgKy0KPiA+PiBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jICAgICB8ICAgIDQg Kwo+ID4+IGRyaXZlcnMvZ3B1L2RybS9kcm1fZnJhbWVidWZmZXIuYyAgIHwgIDI0OSArKysrKysr KysrKysrKysrKysrKysrKysrKysrLS0tLQo+ID4+IGRyaXZlcnMvZ3B1L2RybS9kcm1faW9jdGwu YyAgICAgICAgIHwgICAgNyArCj4gPj4gaW5jbHVkZS9kcm0vZHJtUC5oICAgICAgICAgICAgICAg ICAgfCAgICAyICsKPiA+PiBpbmNsdWRlL2RybS9kcm1fYXRvbWljLmggICAgICAgICAgICB8ICAg IDMgKwo+ID4+IGluY2x1ZGUvZHJtL2RybV9jb25uZWN0b3IuaCAgICAgICAgIHwgICAxNSArKwo+ ID4+IGluY2x1ZGUvZHJtL2RybV9jcnRjLmggICAgICAgICAgICAgIHwgICAxMiArKwo+ID4+IGlu Y2x1ZGUvdWFwaS9kcm0vZHJtLmggICAgICAgICAgICAgIHwgICAxMCArKwo+ID4+IGluY2x1ZGUv dWFwaS9kcm0vZHJtX21vZGUuaCAgICAgICAgIHwgICAgMSArCj4gPj4gMjIgZmlsZXMgY2hhbmdl ZCwgODMwIGluc2VydGlvbnMoKyksIDczIGRlbGV0aW9ucygtKQo+ID4+IGNyZWF0ZSBtb2RlIDEw MDY0NCBkcml2ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9tdy5jCj4gPj4KPiA+Cj4gPi0tIAo+ID5R dWFsY29tbSBJbm5vdmF0aW9uIENlbnRlciwgSW5jLiBpcyBhIG1lbWJlciBvZiBDb2RlIEF1cm9y YSBGb3J1bSwKPiA+YSBMaW51eCBGb3VuZGF0aW9uIENvbGxhYm9yYXRpdmUgUHJvamVjdAo+ID4t LQo+ID5UbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJz Y3JpYmUgbGludXgtbWVkaWEiIGluCj4gPnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRv bW9Admdlci5rZXJuZWwub3JnCj4gPk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2Vy Lmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo+ID4KCi0tIApWaWxsZSBTeXJqw6Rsw6QK SW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga09.intel.com ([134.134.136.24]:31019 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752977AbcJNMuY (ORCPT ); Fri, 14 Oct 2016 08:50:24 -0400 Date: Fri, 14 Oct 2016 15:50:18 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Brian Starkey Cc: Archit Taneja , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, liviu.dudau@arm.com, robdclark@gmail.com, hverkuil@xs4all.nl, eric@anholt.net, daniel@ffwll.ch Subject: Re: [RFC PATCH 00/11] Introduce writeback connectors Message-ID: <20161014125018.GD4329@intel.com> References: <1476197648-24918-1-git-send-email-brian.starkey@arm.com> <6e794da8-49de-0440-ea70-272bfe47332b@codeaurora.org> <20161014123914.GA10745@e106950-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161014123914.GA10745@e106950-lin.cambridge.arm.com> Sender: linux-media-owner@vger.kernel.org List-ID: On Fri, Oct 14, 2016 at 01:39:15PM +0100, Brian Starkey wrote: > Hi Archit, > > On Fri, Oct 14, 2016 at 04:20:14PM +0530, Archit Taneja wrote: > >Hi Brian, > > > >On 10/11/2016 08:23 PM, Brian Starkey wrote: > >>Hi, > >> > >>This RFC series introduces a new connector type: > >> DRM_MODE_CONNECTOR_WRITEBACK > >>It is a follow-on from a previous discussion: [1] > >> > >>Writeback connectors are used to expose the memory writeback engines > >>found in some display controllers, which can write a CRTC's > >>composition result to a memory buffer. > >>This is useful e.g. for testing, screen-recording, screenshots, > >>wireless display, display cloning, memory-to-memory composition. > >> > >>Patches 1-7 include the core framework changes required, and patches > >>8-11 implement a writeback connector for the Mali-DP writeback engine. > >>The Mali-DP patches depend on this other series: [2]. > >> > >>The connector is given the FB_ID property for the output framebuffer, > >>and two new read-only properties: PIXEL_FORMATS and > >>PIXEL_FORMATS_SIZE, which expose the supported framebuffer pixel > >>formats of the engine. > >> > >>The EDID property is not exposed for writeback connectors. > >> > >>Writeback connector usage: > >>-------------------------- > >>Due to connector routing changes being treated as "full modeset" > >>operations, any client which wishes to use a writeback connector > >>should include the connector in every modeset. The writeback will not > >>actually become active until a framebuffer is attached. > >> > >>The writeback itself is enabled by attaching a framebuffer to the > >>FB_ID property of the connector. The driver must then ensure that the > >>CRTC content of that atomic commit is written into the framebuffer. > >> > >>The writeback works in a one-shot mode with each atomic commit. This > >>prevents the same content from being written multiple times. > >>In some cases (front-buffer rendering) there might be a desire for > >>continuous operation - I think a property could be added later for > >>this kind of control. > >> > >>Writeback can be disabled by setting FB_ID to zero. > >> > >>Known issues: > >>------------- > >> * I'm not sure what "DPMS" should mean for writeback connectors. > >> It could be used to disable writeback (even when a framebuffer is > >> attached), or it could be hidden entirely (which would break the > >> legacy DPMS call for writeback connectors). > >> * With Daniel's recent re-iteration of the userspace API rules, I > >> fully expect to provide some userspace code to support this. The > >> question is what, and where? We want to use writeback for testing, > >> so perhaps some tests in igt is suitable. > >> * Documentation. Probably some portion of this cover letter needs to > >> make it into Documentation/ > >> * Synchronisation. Our hardware will finish the writeback by the next > >> vsync. I've not implemented fence support here, but it would be an > >> obvious addition. > >> > >>See Also: > >>--------- > >>[1] https://lists.freedesktop.org/archives/dri-devel/2016-July/113197.html > >>[2] https://lists.freedesktop.org/archives/dri-devel/2016-October/120486.html > >> > >>I welcome any comments, especially if this approach does/doesn't fit > >>well with anyone else's hardware. > > > >Thanks for working on this! Some points below. > > > >- Writeback hardware generally allows us to specify the region within > >the framebuffer we want to write to. It's analogous to the SRC_X/Y/W/H > >plane properties. We could have similar props for the writeback > >connectors, and maybe set them to the FB_ID dimensions if they aren't > >configured by userspace. > > > >- Besides the above property, writeback hardware can have provisions > >for scaling, color space conversion and rotation. This would mean that > >we'd eventually add more writeback specific props/params in > >drm_connector/drm_connector_state. Would we be okay adding more such > >props for connectors? > > I've wondered the same thing about bloating non-writeback connectors > with writeback-specific stuff. If it does become significant, maybe > we should subclass drm_connector and add a drm_writeback_state pointer > to drm_connector_state. > > Ville touched on scaling support previously, suggesting adding a > fixed_mode property (for all types of connectors) - on writeback this > would represent scaling the framebuffer, and on normal connectors it > could control output scaling (like panel-fitting). We got some patches [1] posted for i915 recently that added a bunch of new properties to control post-blending scaling, but I'm not sure I like the approach since it seems harder to reconcile with the current way we deal with scaling for eDP/LVDS/DSI/etc. So I'm still somewhat partial to the fixed mode idea. Just FYI. [1] https://lists.freedesktop.org/archives/intel-gfx/2016-August/105557.html > > Certainly destination coords, color-space converstion etc. are things > that are worth adding, but IMO I'd rather keep this initial > implementation small so we can enable the basic case right away. For > the most part, the additional things are "just properties" which > should be easily added later without impacting the overall interface. > > Cheers, > Brian > > > >Thanks, > >Archit > > > >> > >>Thanks, > >> > >>-Brian > >> > >>--- > >> > >>Brian Starkey (10): > >> drm: add writeback connector type > >> drm/fb-helper: skip writeback connectors > >> drm: extract CRTC/plane disable from drm_framebuffer_remove > >> drm: add __drm_framebuffer_remove_atomic > >> drm: add fb to connector state > >> drm: expose fb_id property for writeback connectors > >> drm: add writeback-connector pixel format properties > >> drm: mali-dp: rename malidp_input_format > >> drm: mali-dp: add RGB writeback formats for DP550/DP650 > >> drm: mali-dp: add writeback connector > >> > >>Liviu Dudau (1): > >> drm: mali-dp: Add support for writeback on DP550/DP650 > >> > >> drivers/gpu/drm/arm/Makefile | 1 + > >> drivers/gpu/drm/arm/malidp_crtc.c | 10 ++ > >> drivers/gpu/drm/arm/malidp_drv.c | 25 +++- > >> drivers/gpu/drm/arm/malidp_drv.h | 5 + > >> drivers/gpu/drm/arm/malidp_hw.c | 104 ++++++++++---- > >> drivers/gpu/drm/arm/malidp_hw.h | 27 +++- > >> drivers/gpu/drm/arm/malidp_mw.c | 268 +++++++++++++++++++++++++++++++++++ > >> drivers/gpu/drm/arm/malidp_planes.c | 8 +- > >> drivers/gpu/drm/arm/malidp_regs.h | 15 ++ > >> drivers/gpu/drm/drm_atomic.c | 40 ++++++ > >> drivers/gpu/drm/drm_atomic_helper.c | 4 + > >> drivers/gpu/drm/drm_connector.c | 79 ++++++++++- > >> drivers/gpu/drm/drm_crtc.c | 14 +- > >> drivers/gpu/drm/drm_fb_helper.c | 4 + > >> drivers/gpu/drm/drm_framebuffer.c | 249 ++++++++++++++++++++++++++++---- > >> drivers/gpu/drm/drm_ioctl.c | 7 + > >> include/drm/drmP.h | 2 + > >> include/drm/drm_atomic.h | 3 + > >> include/drm/drm_connector.h | 15 ++ > >> include/drm/drm_crtc.h | 12 ++ > >> include/uapi/drm/drm.h | 10 ++ > >> include/uapi/drm/drm_mode.h | 1 + > >> 22 files changed, 830 insertions(+), 73 deletions(-) > >> create mode 100644 drivers/gpu/drm/arm/malidp_mw.c > >> > > > >-- > >Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > >a Linux Foundation Collaborative Project > >-- > >To unsubscribe from this list: send the line "unsubscribe linux-media" in > >the body of a message to majordomo@vger.kernel.org > >More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- Ville Syrjälä Intel OTC