From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756457AbcJNTSB (ORCPT ); Fri, 14 Oct 2016 15:18:01 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:43919 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756312AbcJNTR3 (ORCPT ); Fri, 14 Oct 2016 15:17:29 -0400 Date: Fri, 14 Oct 2016 15:16:13 -0400 From: Konrad Rzeszutek Wilk To: Boris Ostrovsky Cc: david.vrabel@citrix.com, JGross@suse.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, roger.pau@citrix.com Subject: Re: [Xen-devel] [PATCH 5/8] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC Message-ID: <20161014191613.GB16777@localhost.localdomain> References: <1476468318-24422-1-git-send-email-boris.ostrovsky@oracle.com> <1476468318-24422-6-git-send-email-boris.ostrovsky@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476468318-24422-6-git-send-email-boris.ostrovsky@oracle.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 14, 2016 at 02:05:15PM -0400, Boris Ostrovsky wrote: > Make sure they don't use these devices since they are not emulated > for unprivileged PVH guest. Which means they would just return 0 ? Or would it get worst since the in/out would go to the hypervisor which would kill the guest? > > Also don't initialize hypercall page for them in init_hvm_pv_info() > since this has already been done. > > Signed-off-by: Boris Ostrovsky > --- > arch/x86/xen/enlighten.c | 24 +++++++++++++++++------- > 1 file changed, 17 insertions(+), 7 deletions(-) > > diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c > index d38d568..6c1a330 100644 > --- a/arch/x86/xen/enlighten.c > +++ b/arch/x86/xen/enlighten.c > @@ -1803,10 +1803,21 @@ static void __init init_hvm_pv_info(void) > minor = eax & 0xffff; > printk(KERN_INFO "Xen version %d.%d.\n", major, minor); > > - cpuid(base + 2, &pages, &msr, &ecx, &edx); > + xen_domain_type = XEN_HVM_DOMAIN; > > - pfn = __pa(hypercall_page); > - wrmsr_safe(msr, (u32)pfn, (u32)(pfn >> 32)); > + /* PVH set up hypercall page earlier in xen_prepare_pvh() */ A period at the end? > + if (xen_pvh_domain()) { > + pv_info.name = "Xen PVH"; > +#ifdef CONFIG_ACPI > + /* No PIC or IOAPIC */ Here? > + acpi_irq_model = ACPI_IRQ_MODEL_PLATFORM; > +#endif > + } else { > + pv_info.name = "Xen HVM"; > + cpuid(base + 2, &pages, &msr, &ecx, &edx); Could you use cpuid_ebx ? > + pfn = __pa(hypercall_page); > + wrmsr_safe(msr, (u32)pfn, (u32)(pfn >> 32)); > + } > > xen_setup_features(); > > @@ -1815,10 +1826,6 @@ static void __init init_hvm_pv_info(void) > this_cpu_write(xen_vcpu_id, ebx); > else > this_cpu_write(xen_vcpu_id, smp_processor_id()); > - > - pv_info.name = "Xen HVM"; > - > - xen_domain_type = XEN_HVM_DOMAIN; > } > > static int xen_cpu_up_prepare(unsigned int cpu) > @@ -1892,6 +1899,9 @@ static void __init xen_hvm_guest_init(void) > > init_hvm_pv_info(); > > + if (xen_pvh_domain()) > + x86_platform.legacy.rtc = 0; > + > xen_hvm_init_shared_info(); > > xen_panic_handler_init(); > -- > 1.8.3.1 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 5/8] xen/pvh: Prevent PVH guests from using PIC, RTC and IOAPIC Date: Fri, 14 Oct 2016 15:16:13 -0400 Message-ID: <20161014191613.GB16777@localhost.localdomain> References: <1476468318-24422-1-git-send-email-boris.ostrovsky@oracle.com> <1476468318-24422-6-git-send-email-boris.ostrovsky@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bv7xz-00044F-7u for xen-devel@lists.xenproject.org; Fri, 14 Oct 2016 19:16:27 +0000 Content-Disposition: inline In-Reply-To: <1476468318-24422-6-git-send-email-boris.ostrovsky@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Boris Ostrovsky Cc: JGross@suse.com, xen-devel@lists.xenproject.org, roger.pau@citrix.com, david.vrabel@citrix.com, linux-kernel@vger.kernel.org List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBPY3QgMTQsIDIwMTYgYXQgMDI6MDU6MTVQTSAtMDQwMCwgQm9yaXMgT3N0cm92c2t5 IHdyb3RlOgo+IE1ha2Ugc3VyZSB0aGV5IGRvbid0IHVzZSB0aGVzZSBkZXZpY2VzIHNpbmNlIHRo ZXkgYXJlIG5vdCBlbXVsYXRlZAo+IGZvciB1bnByaXZpbGVnZWQgUFZIIGd1ZXN0LgoKV2hpY2gg bWVhbnMgdGhleSB3b3VsZCBqdXN0IHJldHVybiAwID8gT3Igd291bGQgaXQgZ2V0IHdvcnN0IHNp bmNlCnRoZSBpbi9vdXQgd291bGQgZ28gdG8gdGhlIGh5cGVydmlzb3Igd2hpY2ggd291bGQga2ls bCB0aGUgZ3Vlc3Q/Cj4gCj4gQWxzbyBkb24ndCBpbml0aWFsaXplIGh5cGVyY2FsbCBwYWdlIGZv ciB0aGVtIGluIGluaXRfaHZtX3B2X2luZm8oKQo+IHNpbmNlIHRoaXMgaGFzIGFscmVhZHkgYmVl biBkb25lLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEJvcmlzIE9zdHJvdnNreSA8Ym9yaXMub3N0cm92 c2t5QG9yYWNsZS5jb20+Cj4gLS0tCj4gIGFyY2gveDg2L3hlbi9lbmxpZ2h0ZW4uYyB8IDI0ICsr KysrKysrKysrKysrKysrLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygr KSwgNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvYXJjaC94ODYveGVuL2VubGlnaHRl bi5jIGIvYXJjaC94ODYveGVuL2VubGlnaHRlbi5jCj4gaW5kZXggZDM4ZDU2OC4uNmMxYTMzMCAx MDA2NDQKPiAtLS0gYS9hcmNoL3g4Ni94ZW4vZW5saWdodGVuLmMKPiArKysgYi9hcmNoL3g4Ni94 ZW4vZW5saWdodGVuLmMKPiBAQCAtMTgwMywxMCArMTgwMywyMSBAQCBzdGF0aWMgdm9pZCBfX2lu aXQgaW5pdF9odm1fcHZfaW5mbyh2b2lkKQo+ICAJbWlub3IgPSBlYXggJiAweGZmZmY7Cj4gIAlw cmludGsoS0VSTl9JTkZPICJYZW4gdmVyc2lvbiAlZC4lZC5cbiIsIG1ham9yLCBtaW5vcik7Cj4g IAo+IC0JY3B1aWQoYmFzZSArIDIsICZwYWdlcywgJm1zciwgJmVjeCwgJmVkeCk7Cj4gKwl4ZW5f ZG9tYWluX3R5cGUgPSBYRU5fSFZNX0RPTUFJTjsKPiAgCj4gLQlwZm4gPSBfX3BhKGh5cGVyY2Fs bF9wYWdlKTsKPiAtCXdybXNyX3NhZmUobXNyLCAodTMyKXBmbiwgKHUzMikocGZuID4+IDMyKSk7 Cj4gKwkvKiBQVkggc2V0IHVwIGh5cGVyY2FsbCBwYWdlIGVhcmxpZXIgaW4geGVuX3ByZXBhcmVf cHZoKCkgKi8KCkEgcGVyaW9kIGF0IHRoZSBlbmQ/Cj4gKwlpZiAoeGVuX3B2aF9kb21haW4oKSkg ewo+ICsJCXB2X2luZm8ubmFtZSA9ICJYZW4gUFZIIjsKPiArI2lmZGVmIENPTkZJR19BQ1BJCj4g KwkJLyogTm8gUElDIG9yIElPQVBJQyAqLwoKSGVyZT8KPiArCQlhY3BpX2lycV9tb2RlbCA9IEFD UElfSVJRX01PREVMX1BMQVRGT1JNOwo+ICsjZW5kaWYKPiArCX0gZWxzZSB7Cj4gKwkJcHZfaW5m by5uYW1lID0gIlhlbiBIVk0iOwo+ICsJCWNwdWlkKGJhc2UgKyAyLCAmcGFnZXMsICZtc3IsICZl Y3gsICZlZHgpOwoKQ291bGQgeW91IHVzZSBjcHVpZF9lYnggPwo+ICsJCXBmbiA9IF9fcGEoaHlw ZXJjYWxsX3BhZ2UpOwo+ICsJCXdybXNyX3NhZmUobXNyLCAodTMyKXBmbiwgKHUzMikocGZuID4+ IDMyKSk7Cj4gKwl9Cj4gIAo+ICAJeGVuX3NldHVwX2ZlYXR1cmVzKCk7Cj4gIAo+IEBAIC0xODE1 LDEwICsxODI2LDYgQEAgc3RhdGljIHZvaWQgX19pbml0IGluaXRfaHZtX3B2X2luZm8odm9pZCkK PiAgCQl0aGlzX2NwdV93cml0ZSh4ZW5fdmNwdV9pZCwgZWJ4KTsKPiAgCWVsc2UKPiAgCQl0aGlz X2NwdV93cml0ZSh4ZW5fdmNwdV9pZCwgc21wX3Byb2Nlc3Nvcl9pZCgpKTsKPiAtCj4gLQlwdl9p bmZvLm5hbWUgPSAiWGVuIEhWTSI7Cj4gLQo+IC0JeGVuX2RvbWFpbl90eXBlID0gWEVOX0hWTV9E T01BSU47Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbnQgeGVuX2NwdV91cF9wcmVwYXJlKHVuc2lnbmVk IGludCBjcHUpCj4gQEAgLTE4OTIsNiArMTg5OSw5IEBAIHN0YXRpYyB2b2lkIF9faW5pdCB4ZW5f aHZtX2d1ZXN0X2luaXQodm9pZCkKPiAgCj4gIAlpbml0X2h2bV9wdl9pbmZvKCk7Cj4gIAo+ICsJ aWYgKHhlbl9wdmhfZG9tYWluKCkpCj4gKwkJeDg2X3BsYXRmb3JtLmxlZ2FjeS5ydGMgPSAwOwo+ ICsKPiAgCXhlbl9odm1faW5pdF9zaGFyZWRfaW5mbygpOwo+ICAKPiAgCXhlbl9wYW5pY19oYW5k bGVyX2luaXQoKTsKPiAtLSAKPiAxLjguMy4xCj4gCj4gCj4gX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KPiBYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Cj4gWGVu LWRldmVsQGxpc3RzLnhlbi5vcmcKPiBodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwg bWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK