All of lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: Weirdness with discard cmd and get log pages
Date: Fri, 14 Oct 2016 19:19:33 -0400	[thread overview]
Message-ID: <20161014231932.GA19846@localhost.localdomain> (raw)
In-Reply-To: <CAG3=cOmZpmE=OXJr9cqu75-c7XQ8upeCBFUhsakn_3ts=zPkXg@mail.gmail.com>

On Fri, Oct 14, 2016@02:33:49PM -0700, Nisha Miller wrote:
> My problem is that I need to make it work on Kernel 2.6.33. For now,
> since blkdiscard and fstrim send only 1 range I'm ok with current
> support for discard cmd.
> 
> However I need to fix the issue for get log pages. Are there any known
> issues with mapping user buffers in older linux-nvme drivers?

I'm pretty sure it works. I tested on a RHEL 6.6 (a 2.6.32 fork), and
I can read all the log pages without issue.

The nvme-cli doesn't align every buffer on page boundaries, so many of
these passthru commands require PRP2. Is your device using this correctly
on non-RW commands?

  reply	other threads:[~2016-10-14 23:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-13 15:46 Weirdness with discard cmd and get log pages Nisha Miller
2016-10-13 16:15 ` Keith Busch
2016-10-13 18:18   ` Nisha Miller
2016-10-13 23:18     ` Keith Busch
2016-10-14 17:44       ` Keith Busch
2016-10-14 21:33         ` Nisha Miller
2016-10-14 23:19           ` Keith Busch [this message]
2016-10-18 16:55             ` Nisha Miller
2016-10-18 17:08               ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161014231932.GA19846@localhost.localdomain \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.