From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH 00/57] don't break long lines on strings
Date: Sat, 15 Oct 2016 13:38:40 -0300 [thread overview]
Message-ID: <20161015133840.7b5755a2@vento.lan> (raw)
In-Reply-To: <20161015154614.67f97a81@kant>
Em Sat, 15 Oct 2016 15:46:14 +0200
Stefan Richter <stefanr@s5r6.in-berlin.de> escreveu:
> On Oct 14 Mauro Carvalho Chehab wrote:
> > There are lots of drivers on media that breaks long line strings in order to
> > fit into 80 columns. This was an usual practice to make checkpatch happy.
>
> This was practice even before checkpatch existed.
True, but before checkpatch, we didn't care much to enforce breaking
long string lines, letting up to the patch author to decide. As far
as I remember, on media subsystem, only a handful drivers were actually
breaking long strings (or even respecting the 80 cols limit).
After checkpatch, we started to enforce such practice, until some discussions
on LKML arguing that breaking long strings actually make more harm than good,
as it makes harder to use grep to identify what part of the Kernel produced
a certain log message.
Thanks,
Mauro
prev parent reply other threads:[~2016-10-15 16:38 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 20:19 [PATCH 00/57] don't break long lines on strings Mauro Carvalho Chehab
2016-10-14 20:19 ` [PATCH 01/57] [media] b2c2: don't break long lines Mauro Carvalho Chehab
2016-10-14 20:19 ` [PATCH 02/57] [media] dvb-frontends: " Mauro Carvalho Chehab
2016-10-14 20:19 ` [PATCH 03/57] [media] firewire: " Mauro Carvalho Chehab
2016-10-15 11:10 ` Takashi Sakamoto
2016-10-15 13:47 ` Stefan Richter
2016-10-14 20:19 ` [PATCH 04/57] [media] cx25840: " Mauro Carvalho Chehab
2016-10-14 20:19 ` [PATCH 05/57] [media] smiapp: " Mauro Carvalho Chehab
2016-10-14 20:19 ` [PATCH 06/57] [media] soc_camera: " Mauro Carvalho Chehab
2016-10-14 20:19 ` [PATCH 07/57] [media] b2c2: " Mauro Carvalho Chehab
2016-10-14 20:19 ` [PATCH 08/57] [media] bt8xx: " Mauro Carvalho Chehab
2016-10-14 20:19 ` [PATCH 09/57] [media] cx18: " Mauro Carvalho Chehab
2016-10-14 20:19 ` [PATCH 10/57] [media] cx23885: " Mauro Carvalho Chehab
2016-10-14 20:19 ` [PATCH 11/57] [media] cx88: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 12/57] [media] ddbridge: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 13/57] [media] dm1105: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 14/57] [media] ivtv: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 15/57] [media] meye: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 16/57] [media] pt1: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 17/57] [media] saa7134: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 18/57] [media] saa7164: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 19/57] [media] solo6x10: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 20/57] [media] ttpci: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 21/57] [media] tw68: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 22/57] [media] davinci: " Mauro Carvalho Chehab
2016-10-18 16:32 ` Lad, Prabhakar
2016-10-14 20:20 ` [PATCH 23/57] [media] exynos4-is: " Mauro Carvalho Chehab
2016-10-14 20:20 ` Mauro Carvalho Chehab
2016-10-14 20:20 ` Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 24/57] [media] marvell-ccic: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 25/57] [media] omap: " Mauro Carvalho Chehab
2016-10-17 13:47 ` Laurent Pinchart
2016-10-14 20:20 ` [PATCH 26/57] [media] omap3isp: " Mauro Carvalho Chehab
2016-10-17 13:48 ` Laurent Pinchart
2016-10-14 20:20 ` [PATCH 27/57] [media] s5p-mfc: " Mauro Carvalho Chehab
2016-10-14 20:20 ` Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 28/57] [media] c8sectpfe: " Mauro Carvalho Chehab
2016-10-14 20:20 ` Mauro Carvalho Chehab
2016-10-17 6:41 ` [STLinux Kernel] " Peter Griffin
2016-10-17 6:41 ` Peter Griffin
2016-10-14 20:20 ` [PATCH 29/57] [media] ti-vpe: " Mauro Carvalho Chehab
2016-10-14 21:18 ` Benoit Parrot
2016-10-14 20:20 ` [PATCH 30/57] [media] si470x: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 31/57] [media] si4713: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 32/57] [media] wl128x: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 33/57] [media] au0828: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 34/57] [media] b2c2: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 35/57] [media] cpia2: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 36/57] [media] cx231xx: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 37/57] [media] dvb-usb: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 38/57] [media] dvb-usb-v2: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 39/57] [media] em28xx: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 40/57] [media] hdpvr: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 41/57] [media] pvrusb2: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 42/57] [media] pwc: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 43/57] [media] siano: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 44/57] [media] stkwebcam: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 45/57] [media] tm6000: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 46/57] [media] ttusb-budget: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 47/57] [media] ttusb-dec: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 48/57] [media] usbvision: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 49/57] [media] uvc: " Mauro Carvalho Chehab
2016-10-17 13:49 ` Laurent Pinchart
2016-10-14 20:20 ` [PATCH 50/57] [media] zr364xx: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 51/57] [media] v4l2-core: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 52/57] [media] common: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 53/57] [media] i2c: " Mauro Carvalho Chehab
2016-10-17 13:54 ` Laurent Pinchart
2016-10-14 20:20 ` [PATCH 54/57] [media] platform: " Mauro Carvalho Chehab
2016-10-14 21:02 ` Robert Jarzmik
2016-10-17 13:45 ` Laurent Pinchart
2016-10-17 19:39 ` Andrey Utkin
2016-10-17 18:44 ` Laurent Pinchart
2016-10-17 19:50 ` Andrey Utkin
2016-10-14 20:20 ` [PATCH 55/57] [media] radio: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 56/57] [media] rc: " Mauro Carvalho Chehab
2016-10-14 20:20 ` [PATCH 57/57] [media] tuners: " Mauro Carvalho Chehab
2016-10-15 13:46 ` [PATCH 00/57] don't break long lines on strings Stefan Richter
2016-10-15 16:38 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161015133840.7b5755a2@vento.lan \
--to=mchehab@s-opensource.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.