From: Elise Lennion <elise.lennion@gmail.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: aditya.shankar@microchip.com, ganesh.krishna@microchip.com,
gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: wilc1000: Remove unnecessary extern variables.
Date: Sat, 15 Oct 2016 19:18:42 -0300 [thread overview]
Message-ID: <20161015221842.GA17856@lennorien.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1610152051200.9280@hadrien>
On Sat, Oct 15, 2016 at 08:51:51PM +0200, Julia Lawall wrote:
>
>
> On Sat, 15 Oct 2016, Elise Lennion wrote:
>
> > The externs were removed because there are already declarations
> > in wilc_wlan.h for them.
>
> Are these functions actually used in more than one file?
Actually not, I see that in this driver there are many extern variables
that could be declared in a .c file as static.
elise
>
> julia
>
prev parent reply other threads:[~2016-10-15 22:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-15 18:46 [PATCH] staging: wilc1000: Remove unnecessary extern variables Elise Lennion
2016-10-15 18:51 ` [Outreachy kernel] " Julia Lawall
2016-10-15 22:18 ` Elise Lennion [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161015221842.GA17856@lennorien.com \
--to=elise.lennion@gmail.com \
--cc=aditya.shankar@microchip.com \
--cc=ganesh.krishna@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.