Re: [Qemu-devel] [PATCH 00/15] tcg field extract primitives

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 00/15] tcg field extract primitives
Type: series
Message-id: 1476589070-5792-1-git-send-email-rth@twiddle.net

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
4d07805 target-s390: Use tcg_gen_extract_i64
3c516d8 target-ppc: Use tcg_gen_extract_*
053b5eb target-mips: Use tcg_gen_extract_*
b32052a target-i386: Use tcg_gen_extract_tl
6387628 target-arm: Use tcg_gen_*extract
0214aa9 target-alpha: Use deposit and extract ops
74f3547 tcg/s390: Implement field extraction opcodes
500fe06 tcg/ppc: Implement field extraction opcodes
976f642 tcg/mips: Implement field extraction opcodes
5eaa14b tcg/i386: Implement field extraction opcodes
123a584 tcg/arm: Implement field extraction opcodes
4624eb9 tcg/arm: Move isa detection to tcg-target.h
7ef8856 tcg/aarch64: Implement field extraction opcodes
2e87ea6 tcg: Minor adjustments to deposit expanders
be676b7 tcg: Add field extraction primitives

=== OUTPUT BEGIN ===
Checking PATCH 1/15: tcg: Add field extraction primitives...
ERROR: spaces required around that ':' (ctx:VxE)
#105: FILE: tcg/optimize.c:881:
+        CASE_OP_32_64(extract):
                               ^

ERROR: spaces required around that ':' (ctx:VxE)
#111: FILE: tcg/optimize.c:887:
+        CASE_OP_32_64(sextract):
                                ^

ERROR: spaces required around that ':' (ctx:VxE)
#125: FILE: tcg/optimize.c:1064:
+        CASE_OP_32_64(extract):
                               ^

ERROR: spaces required around that ':' (ctx:VxE)
#133: FILE: tcg/optimize.c:1072:
+        CASE_OP_32_64(sextract):
                                ^

ERROR: space prohibited after that '&&' (ctx:ExW)
#232: FILE: tcg/tcg-op.c:587:
+        && TCG_TARGET_extract_i32_valid(ofs, len)) {
         ^

ERROR: space prohibited after that '&&' (ctx:ExW)
#286: FILE: tcg/tcg-op.c:641:
+        && TCG_TARGET_extract_i32_valid(ofs, len)) {
         ^

ERROR: space prohibited after that '&&' (ctx:ExW)
#384: FILE: tcg/tcg-op.c:1780:
+        && TCG_TARGET_extract_i64_valid(ofs, len)) {
         ^

ERROR: space prohibited after that '&&' (ctx:ExW)
#473: FILE: tcg/tcg-op.c:1869:
+        && TCG_TARGET_extract_i64_valid(ofs, len)) {
         ^

total: 8 errors, 0 warnings, 560 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/15: tcg: Minor adjustments to deposit expanders...
Checking PATCH 3/15: tcg/aarch64: Implement field extraction opcodes...
Checking PATCH 4/15: tcg/arm: Move isa detection to tcg-target.h...
WARNING: architecture specific defines should be avoided
#20: FILE: tcg/arm/tcg-target.h:30:
+#ifndef __ARM_ARCH

WARNING: architecture specific defines should be avoided
#21: FILE: tcg/arm/tcg-target.h:31:
+# if defined(__ARM_ARCH_7__) || defined(__ARM_ARCH_7A__) \

WARNING: architecture specific defines should be avoided
#40: FILE: tcg/arm/tcg-target.h:50:
+#if defined(__ARM_ARCH_5T__) \

total: 0 errors, 3 warnings, 107 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/15: tcg/arm: Implement field extraction opcodes...
Checking PATCH 6/15: tcg/i386: Implement field extraction opcodes...
ERROR: spaces required around that ':' (ctx:VxE)
#51: FILE: tcg/i386/tcg-target.inc.c:2146:
+    OP_32_64(extract):
                      ^

total: 1 errors, 0 warnings, 75 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 7/15: tcg/mips: Implement field extraction opcodes...
Checking PATCH 8/15: tcg/ppc: Implement field extraction opcodes...
Checking PATCH 9/15: tcg/s390: Implement field extraction opcodes...
ERROR: space required after that ',' (ctx:VxV)
#40: FILE: tcg/s390/tcg-target.h:111:
+#define TCG_TARGET_deposit_i32_valid(o,l)  tcg_target_have_gen_inst()
                                       ^

ERROR: space required after that ',' (ctx:VxV)
#41: FILE: tcg/s390/tcg-target.h:112:
+#define TCG_TARGET_deposit_i64_valid(o,l)  tcg_target_have_gen_inst()
                                       ^

ERROR: space required after that ',' (ctx:VxV)
#42: FILE: tcg/s390/tcg-target.h:113:
+#define TCG_TARGET_extract_i32_valid(o,l)  tcg_target_have_gen_inst()
                                       ^

ERROR: space required after that ',' (ctx:VxV)
#43: FILE: tcg/s390/tcg-target.h:114:
+#define TCG_TARGET_extract_i64_valid(o,l)  tcg_target_have_gen_inst()
                                       ^

ERROR: spaces required around that ':' (ctx:VxE)
#77: FILE: tcg/s390/tcg-target.inc.c:2178:
+    OP_32_64(extract):
                      ^

total: 5 errors, 0 warnings, 73 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 10/15: target-alpha: Use deposit and extract ops...
Checking PATCH 11/15: target-arm: Use tcg_gen_*extract...
Checking PATCH 12/15: target-i386: Use tcg_gen_extract_tl...
Checking PATCH 13/15: target-mips: Use tcg_gen_extract_*...
Checking PATCH 14/15: target-ppc: Use tcg_gen_extract_*...
Checking PATCH 15/15: target-s390: Use tcg_gen_extract_i64...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org