From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bvztI-00012X-QT for qemu-devel@nongnu.org; Mon, 17 Oct 2016 00:51:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bvztF-0005IG-Mx for qemu-devel@nongnu.org; Mon, 17 Oct 2016 00:51:12 -0400 Date: Mon, 17 Oct 2016 15:35:46 +1100 From: David Gibson Message-ID: <20161017043546.GU25390@umbus.fritz.box> References: <1476589070-5792-1-git-send-email-rth@twiddle.net> <1476589070-5792-15-git-send-email-rth@twiddle.net> <20161017033806.GP25390@umbus.fritz.box> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iskw6J4cuOvZ6IVF" Content-Disposition: inline In-Reply-To: <20161017033806.GP25390@umbus.fritz.box> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 14/15] target-ppc: Use tcg_gen_extract_* List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org --iskw6J4cuOvZ6IVF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 17, 2016 at 02:38:06PM +1100, David Gibson wrote: > On Sat, Oct 15, 2016 at 08:37:49PM -0700, Richard Henderson wrote: > > Use the new primitives for RDWINM and RLDICL. > >=20 > > Cc: qemu-ppc@nongnu.org > > Signed-off-by: Richard Henderson >=20 > Applied to ppc-for-2.8, thanks. Uh.. wait.. no, wasn't paying attention to the fact that it needs the whole series. > > --- > > target-ppc/translate.c | 9 ++++----- > > 1 file changed, 4 insertions(+), 5 deletions(-) > >=20 > > diff --git a/target-ppc/translate.c b/target-ppc/translate.c > > index bfc1301..724d95c 100644 > > --- a/target-ppc/translate.c > > +++ b/target-ppc/translate.c > > @@ -1977,9 +1977,8 @@ static void gen_rlwinm(DisasContext *ctx) > > if (mb =3D=3D 0 && me =3D=3D (31 - sh)) { > > tcg_gen_shli_tl(t_ra, t_rs, sh); > > tcg_gen_ext32u_tl(t_ra, t_ra); > > - } else if (sh !=3D 0 && me =3D=3D 31 && sh =3D=3D (32 - mb)) { > > - tcg_gen_ext32u_tl(t_ra, t_rs); > > - tcg_gen_shri_tl(t_ra, t_ra, mb); > > + } else if (me =3D=3D 31 && (me - mb + 1) + sh <=3D 32) { > > + tcg_gen_extract_tl(t_ra, t_rs, sh, me - mb + 1); > > } else { > > target_ulong mask; > > #if defined(TARGET_PPC64) > > @@ -2094,8 +2093,8 @@ static void gen_rldinm(DisasContext *ctx, int mb,= int me, int sh) > > =20 > > if (sh !=3D 0 && mb =3D=3D 0 && me =3D=3D (63 - sh)) { > > tcg_gen_shli_tl(t_ra, t_rs, sh); > > - } else if (sh !=3D 0 && me =3D=3D 63 && sh =3D=3D (64 - mb)) { > > - tcg_gen_shri_tl(t_ra, t_rs, mb); > > + } else if (me =3D=3D 63 && (me - mb + 1) + sh <=3D 64) { > > + tcg_gen_extract_tl(t_ra, t_rs, sh, me - mb + 1); > > } else { > > tcg_gen_rotli_tl(t_ra, t_rs, sh); > > tcg_gen_andi_tl(t_ra, t_ra, MASK(mb, me)); >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --iskw6J4cuOvZ6IVF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYBFUfAAoJEGw4ysog2bOSHF8P/0EB0Qaub+sLN1udXwxdvhbb sUK+z4WnUZ+g/L4Fbefl8VcZkKjbWL+uRoFJkNvImH09ihWo2DTpvJTnynWwzTPk E0W4AapyRHaUcU429HbO0uPc2cNGsPfL7sCiAvnNyNXsAJMxh/ta32WPIB6++Lx8 PZ5nBDs+6HKwwsBIaWLr9uo+dDn4wqCGeF37ol982QcQe/g92R6Mdxce9YOM+jCc h5np7i9NlUhQO2W/LWMRZfAzl20Hrp+uUHCwxP8q0NRls4xICOe8FdUmXwBw5eaG 02mgOdiPdBeHMTWyCi7fKmNzvR7iNtLup/ypR3yYwYi0ZQQgCk/J5i5h7ArkjQX8 Ym9bce3hF/Oidqw2P+bm2KPcKOqelZ0I8BkjnmzXU96E3MMg3+H0EUgJJkzeTGNA z5YGb6Rw1QoqHCG2+nhRzLHsdDpkHQKQEdeD99oEpFYJA/Mnzu3EM5DqRdpVtvlo +D0Aexr5VbcHP9dx9I4EkEeI4AtJBTTM4yk7cEKFh4q7U+U9HKWmY4cBlSWEtYwj 4yz5pzZaNw2uyyl44Zmr26uKSRyCVtmQqPZP7ZpcoiYE/7OobxFC/jDxlpK11xPh mk1ebd8I+aRO/8wwoSx9uREseYIQHtAIE9OBtNWBS1yAOmzXYfPsxDBFgbqeLuTt /AkNMb1culBL+1o5e8mH =EcQo -----END PGP SIGNATURE----- --iskw6J4cuOvZ6IVF--