From: Stephen Hemminger <stephen@networkplumber.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Phil Sutter <phil@nwl.cc>
Subject: Re: [PATCH iproute2] devlink: Convert conditional in dl_argv_handle_port() to switch()
Date: Mon, 17 Oct 2016 05:31:19 -0700 [thread overview]
Message-ID: <20161017053119.38ef5dbc@xeon-e3> (raw)
In-Reply-To: <1475979258-29222-1-git-send-email-liuhangbin@gmail.com>
On Sun, 9 Oct 2016 10:14:18 +0800
Hangbin Liu <liuhangbin@gmail.com> wrote:
> Discovered by Phil's covscan. The final return statement is never reached.
> This is not inherently clear from looking at the code, so change the
> conditional to a switch() statement which should clarify this.
>
> CC: Phil Sutter <phil@nwl.cc>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Applied thanks
prev parent reply other threads:[~2016-10-17 12:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-09 2:14 [PATCH iproute2] devlink: Convert conditional in dl_argv_handle_port() to switch() Hangbin Liu
2016-10-09 9:10 ` Phil Sutter
2016-10-17 12:31 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161017053119.38ef5dbc@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.