From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/edid: Only print the bad edid when
	aborting
Date: Mon, 17 Oct 2016 08:19:45 +0200
Message-ID: <20161017061945.GS20761@phenom.ffwll.local>
References: <20161013194355.30669-1-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20161013194355.30669-1-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gVGh1LCBPY3QgMTMsIDIwMTYgYXQgMDg6NDM6NTVQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IEN1cnJlbnRseSwgaWYgZHJtLmRlYnVnIGlzIGVuYWJsZWQsIHdlIGdldCBhIERSTV9F
UlJPUiBtZXNzYWdlIG9uIHRoZQo+IGludGVybWVkaWF0ZSBlZGlkIHJlYWRzLiBUaGlzIGNhdXNl
cyB0cmFuc2llbnQgZmFpbHVyZXMgaW4gQ0kgd2hpY2gKPiBmbGFncyB1cCB0aGUgc3BvcmFkaWMg
RURJRCByZWFkIGZhaWx1cmVzLCB3aGljaCBhcmUgcmVjb3ZlcmVkIGJ5Cj4gcmVyZWFkaW5nIHRo
ZSBFRElEIGF1dG9tYXRpY2FsbHkuIFRoaXMgcGF0Y2ggY29tYmluZXMgdGhlIHJlcG9ydGluZyBk
b25lCj4gYnkgZHJtX2RvX2dldF9lZGlkKCkgaXRzZWxmIHdpdGggdGhlIGJhZCBibG9jayBwcmlu
dGluZyBmcm9tCj4gZ2V0X2VkaWRfYmxvY2soKSwgaW50byBhIHNpbmdsZSB3YXJuaW5nIGFzc29j
aWF0ZWQgd2l0aCB0aGUgY29ubmVjdG9yCj4gb25jZSBhbGwgYXR0ZW1wdHMgdG8gcmV0cmlldmUg
dGhlIEVESUQgZmFpbC4KPiAKPiBSZWZlcmVuY2VzOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Au
b3JnL3Nob3dfYnVnLmNnaT9pZD05ODIyOAo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8
Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgoKQ2FuIEkgaGF6IGEgdmVyc2lvbiBvZiB0aGlzIHBh
dGNoIHdpdGhvdXQgdGhlIHMvYmxvY2svZWRpZC8/IEl0IGNvbmZ1c2VzCm1lIHRoaXMgZWFybHku
IElmIHlvdSB3YW50IGl0LCBwbGVhc2Ugc3BsaXQgb3V0LgotRGFuaWVsCgo+IC0tLQo+ICBkcml2
ZXJzL2dwdS9kcm0vZHJtX2VkaWQuYyB8IDgyICsrKysrKysrKysrKysrKysrKysrKysrKystLS0t
LS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQ0IGluc2VydGlvbnMoKyksIDM4
IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQu
YyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jCj4gaW5kZXggZWM3N2JkM2UxZjA4Li41MWRk
MTBjNjViNTMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9lZGlkLmMKPiArKysg
Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQuYwo+IEBAIC0xMjYwLDYgKzEyNjAsMjYgQEAgZHJt
X2RvX3Byb2JlX2RkY19lZGlkKHZvaWQgKmRhdGEsIHU4ICpidWYsIHVuc2lnbmVkIGludCBibG9j
aywgc2l6ZV90IGxlbikKPiAgCXJldHVybiByZXQgPT0geGZlcnMgPyAwIDogLTE7Cj4gIH0KPiAg
Cj4gK3N0YXRpYyB2b2lkIGNvbm5lY3Rvcl9hZGRfYmFkX2VkaWQoc3RydWN0IGRybV9jb25uZWN0
b3IgKmNvbm5lY3RvciwKPiArCQkJCSAgIHU4ICpibG9jaywgaW50IG51bSkKPiArewo+ICsJaWYg
KGNvbm5lY3Rvci0+YmFkX2VkaWRfY291bnRlcisrICYmICEoZHJtX2RlYnVnICYgRFJNX1VUX0tN
UykpCj4gKwkJcmV0dXJuOwo+ICsKPiArCWlmIChkcm1fZWRpZF9pc196ZXJvKGJsb2NrLCBFRElE
X0xFTkdUSCkpIHsKPiArCQlkZXZfd2Fybihjb25uZWN0b3ItPmRldi0+ZGV2LAo+ICsJCQkgIiVz
OiBFRElEIGJsb2NrICVkIGlzIGFsbCB6ZXJvZXMuXG4iLAo+ICsJCQkgY29ubmVjdG9yLT5uYW1l
LCBudW0pOwo+ICsJfSBlbHNlIHsKPiArCQlkZXZfd2Fybihjb25uZWN0b3ItPmRldi0+ZGV2LAo+
ICsJCQkgIiVzOiBFRElEIGJsb2NrICVkIGludmFsaWQ6XG4iLAo+ICsJCQkgY29ubmVjdG9yLT5u
YW1lLCBudW0pOwo+ICsJCXByaW50X2hleF9kdW1wKEtFUk5fV0FSTklORywKPiArCQkJICAgICAg
ICIgXHQiLCBEVU1QX1BSRUZJWF9OT05FLCAxNiwgMSwKPiArCQkJICAgICAgIGJsb2NrLCBFRElE
X0xFTkdUSCwgZmFsc2UpOwo+ICsJfQo+ICt9Cj4gKwo+ICAvKioKPiAgICogZHJtX2RvX2dldF9l
ZGlkIC0gZ2V0IEVESUQgZGF0YSB1c2luZyBhIGN1c3RvbSBFRElEIGJsb2NrIHJlYWQgZnVuY3Rp
b24KPiAgICogQGNvbm5lY3RvcjogY29ubmVjdG9yIHdlJ3JlIHByb2JpbmcKPiBAQCAtMTI4Miwy
MCArMTMwMiwxOSBAQCBzdHJ1Y3QgZWRpZCAqZHJtX2RvX2dldF9lZGlkKHN0cnVjdCBkcm1fY29u
bmVjdG9yICpjb25uZWN0b3IsCj4gIAl2b2lkICpkYXRhKQo+ICB7Cj4gIAlpbnQgaSwgaiA9IDAs
IHZhbGlkX2V4dGVuc2lvbnMgPSAwOwo+IC0JdTggKmJsb2NrLCAqbmV3Owo+IC0JYm9vbCBwcmlu
dF9iYWRfZWRpZCA9ICFjb25uZWN0b3ItPmJhZF9lZGlkX2NvdW50ZXIgfHwgKGRybV9kZWJ1ZyAm
IERSTV9VVF9LTVMpOwo+ICsJdTggKmVkaWQsICpuZXc7Cj4gIAo+IC0JaWYgKChibG9jayA9IGtt
YWxsb2MoRURJRF9MRU5HVEgsIEdGUF9LRVJORUwpKSA9PSBOVUxMKQo+ICsJaWYgKChlZGlkID0g
a21hbGxvYyhFRElEX0xFTkdUSCwgR0ZQX0tFUk5FTCkpID09IE5VTEwpCj4gIAkJcmV0dXJuIE5V
TEw7Cj4gIAo+ICAJLyogYmFzZSBibG9jayBmZXRjaCAqLwo+ICAJZm9yIChpID0gMDsgaSA8IDQ7
IGkrKykgewo+IC0JCWlmIChnZXRfZWRpZF9ibG9jayhkYXRhLCBibG9jaywgMCwgRURJRF9MRU5H
VEgpKQo+ICsJCWlmIChnZXRfZWRpZF9ibG9jayhkYXRhLCBlZGlkLCAwLCBFRElEX0xFTkdUSCkp
Cj4gIAkJCWdvdG8gb3V0Owo+IC0JCWlmIChkcm1fZWRpZF9ibG9ja192YWxpZChibG9jaywgMCwg
cHJpbnRfYmFkX2VkaWQsCj4gKwkJaWYgKGRybV9lZGlkX2Jsb2NrX3ZhbGlkKGVkaWQsIDAsIGZh
bHNlLAo+ICAJCQkJCSAmY29ubmVjdG9yLT5lZGlkX2NvcnJ1cHQpKQo+ICAJCQlicmVhazsKPiAt
CQlpZiAoaSA9PSAwICYmIGRybV9lZGlkX2lzX3plcm8oYmxvY2ssIEVESURfTEVOR1RIKSkgewo+
ICsJCWlmIChpID09IDAgJiYgZHJtX2VkaWRfaXNfemVybyhlZGlkLCBFRElEX0xFTkdUSCkpIHsK
PiAgCQkJY29ubmVjdG9yLT5udWxsX2VkaWRfY291bnRlcisrOwo+ICAJCQlnb3RvIGNhcnA7Cj4g
IAkJfQo+IEBAIC0xMzA0LDU4ICsxMzIzLDQ1IEBAIHN0cnVjdCBlZGlkICpkcm1fZG9fZ2V0X2Vk
aWQoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiAgCQlnb3RvIGNhcnA7Cj4gIAo+
ICAJLyogaWYgdGhlcmUncyBubyBleHRlbnNpb25zLCB3ZSdyZSBkb25lICovCj4gLQlpZiAoYmxv
Y2tbMHg3ZV0gPT0gMCkKPiAtCQlyZXR1cm4gKHN0cnVjdCBlZGlkICopYmxvY2s7Cj4gKwlpZiAo
ZWRpZFsweDdlXSA9PSAwKQo+ICsJCXJldHVybiAoc3RydWN0IGVkaWQgKillZGlkOwo+ICAKPiAt
CW5ldyA9IGtyZWFsbG9jKGJsb2NrLCAoYmxvY2tbMHg3ZV0gKyAxKSAqIEVESURfTEVOR1RILCBH
RlBfS0VSTkVMKTsKPiArCW5ldyA9IGtyZWFsbG9jKGVkaWQsIChlZGlkWzB4N2VdICsgMSkgKiBF
RElEX0xFTkdUSCwgR0ZQX0tFUk5FTCk7Cj4gIAlpZiAoIW5ldykKPiAgCQlnb3RvIG91dDsKPiAt
CWJsb2NrID0gbmV3Owo+ICsJZWRpZCA9IG5ldzsKPiArCj4gKwlmb3IgKGogPSAxOyBqIDw9IGVk
aWRbMHg3ZV07IGorKykgewo+ICsJCXU4ICpibG9jayA9IGVkaWQgKyAodmFsaWRfZXh0ZW5zaW9u
cyArIDEpICogRURJRF9MRU5HVEg7Cj4gIAo+IC0JZm9yIChqID0gMTsgaiA8PSBibG9ja1sweDdl
XTsgaisrKSB7Cj4gIAkJZm9yIChpID0gMDsgaSA8IDQ7IGkrKykgewo+IC0JCQlpZiAoZ2V0X2Vk
aWRfYmxvY2soZGF0YSwKPiAtCQkJCSAgYmxvY2sgKyAodmFsaWRfZXh0ZW5zaW9ucyArIDEpICog
RURJRF9MRU5HVEgsCj4gLQkJCQkgIGosIEVESURfTEVOR1RIKSkKPiArCQkJaWYgKGdldF9lZGlk
X2Jsb2NrKGRhdGEsIGJsb2NrLCBqLCBFRElEX0xFTkdUSCkpCj4gIAkJCQlnb3RvIG91dDsKPiAt
CQkJaWYgKGRybV9lZGlkX2Jsb2NrX3ZhbGlkKGJsb2NrICsgKHZhbGlkX2V4dGVuc2lvbnMgKyAx
KQo+IC0JCQkJCQkgKiBFRElEX0xFTkdUSCwgaiwKPiAtCQkJCQkJIHByaW50X2JhZF9lZGlkLAo+
IC0JCQkJCQkgTlVMTCkpIHsKPiArCQkJaWYgKGRybV9lZGlkX2Jsb2NrX3ZhbGlkKGJsb2NrLCBq
LCBmYWxzZSwgTlVMTCkpIHsKPiAgCQkJCXZhbGlkX2V4dGVuc2lvbnMrKzsKPiAgCQkJCWJyZWFr
Owo+ICAJCQl9Cj4gIAkJfQo+ICAKPiAtCQlpZiAoaSA9PSA0ICYmIHByaW50X2JhZF9lZGlkKSB7
Cj4gLQkJCWRldl93YXJuKGNvbm5lY3Rvci0+ZGV2LT5kZXYsCj4gLQkJCSAiJXM6IElnbm9yaW5n
IGludmFsaWQgRURJRCBibG9jayAlZC5cbiIsCj4gLQkJCSBjb25uZWN0b3ItPm5hbWUsIGopOwo+
IC0KPiAtCQkJY29ubmVjdG9yLT5iYWRfZWRpZF9jb3VudGVyKys7Cj4gLQkJfQo+ICsJCWlmIChp
ID09IDQpCj4gKwkJCWNvbm5lY3Rvcl9hZGRfYmFkX2VkaWQoY29ubmVjdG9yLCBibG9jaywgaik7
Cj4gIAl9Cj4gIAo+IC0JaWYgKHZhbGlkX2V4dGVuc2lvbnMgIT0gYmxvY2tbMHg3ZV0pIHsKPiAt
CQlibG9ja1tFRElEX0xFTkdUSC0xXSArPSBibG9ja1sweDdlXSAtIHZhbGlkX2V4dGVuc2lvbnM7
Cj4gLQkJYmxvY2tbMHg3ZV0gPSB2YWxpZF9leHRlbnNpb25zOwo+IC0JCW5ldyA9IGtyZWFsbG9j
KGJsb2NrLCAodmFsaWRfZXh0ZW5zaW9ucyArIDEpICogRURJRF9MRU5HVEgsIEdGUF9LRVJORUwp
Owo+ICsJaWYgKHZhbGlkX2V4dGVuc2lvbnMgIT0gZWRpZFsweDdlXSkgewo+ICsJCWVkaWRbRURJ
RF9MRU5HVEgtMV0gKz0gZWRpZFsweDdlXSAtIHZhbGlkX2V4dGVuc2lvbnM7Cj4gKwkJZWRpZFsw
eDdlXSA9IHZhbGlkX2V4dGVuc2lvbnM7Cj4gKwkJbmV3ID0ga3JlYWxsb2MoZWRpZCwgKHZhbGlk
X2V4dGVuc2lvbnMgKyAxKSAqIEVESURfTEVOR1RILCBHRlBfS0VSTkVMKTsKPiAgCQlpZiAoIW5l
dykKPiAgCQkJZ290byBvdXQ7Cj4gLQkJYmxvY2sgPSBuZXc7Cj4gKwkJZWRpZCA9IG5ldzsKPiAg
CX0KPiAgCj4gLQlyZXR1cm4gKHN0cnVjdCBlZGlkICopYmxvY2s7Cj4gKwlyZXR1cm4gKHN0cnVj
dCBlZGlkICopZWRpZDsKPiAgCj4gIGNhcnA6Cj4gLQlpZiAocHJpbnRfYmFkX2VkaWQpIHsKPiAt
CQlkZXZfd2Fybihjb25uZWN0b3ItPmRldi0+ZGV2LCAiJXM6IEVESUQgYmxvY2sgJWQgaW52YWxp
ZC5cbiIsCj4gLQkJCSBjb25uZWN0b3ItPm5hbWUsIGopOwo+IC0JfQo+IC0JY29ubmVjdG9yLT5i
YWRfZWRpZF9jb3VudGVyKys7Cj4gLQo+ICsJY29ubmVjdG9yX2FkZF9iYWRfZWRpZChjb25uZWN0
b3IsIGVkaWQsIDApOwo+ICBvdXQ6Cj4gLQlrZnJlZShibG9jayk7Cj4gKwlrZnJlZShlZGlkKTsK
PiAgCXJldHVybiBOVUxMOwo+ICB9Cj4gIEVYUE9SVF9TWU1CT0xfR1BMKGRybV9kb19nZXRfZWRp
ZCk7Cj4gLS0gCj4gMi45LjMKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s
aXN0aW5mby9kcmktZGV2ZWwKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJ
bnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs
LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv
bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK