Re: [PATCH] Staging: wilc1000: Replace the name of a variable

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Mon, Oct 17, 2016 at 09:30:27AM +0300, Mihaela Muraru wrote:
> This patch replace the name '*Error' variable with 'err'.

This says what you are doing, but I don't understand why you want to
replace a variable name like this.

Also you have an odd extra space in your subject line :(

> 
> Found and solve with Coccinelle:
> @r1@
> type s;
> identifier sn =~ "Error";
> identifier f;
> type p;
> expression c;
> @@
> 
> f(...) {
> 
> <...
> (
> -p sn = c;
> +p err = c;
> |
> -sn
> +err
> )
> ...>
> }
> 
> Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com>
> ---
>  drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 138 +++++++++++-----------
>  1 file changed, 69 insertions(+), 69 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> index 483a6b6..8c47558 100644
> --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> @@ -603,7 +603,7 @@ static int scan(struct wiphy *wiphy, struct cfg80211_scan_request *request)
>  {
>  	struct wilc_priv *priv;
>  	u32 i;
> -	s32 s32Error = 0;
> +	s32 err = 0;

Also, shouldn't this just be 'int'?

thanks,

greg k-h