From mboxrd@z Thu Jan  1 00:00:00 1970
From: gregkh at linuxfoundation.org <gregkh@linuxfoundation.org>
Date: Mon, 17 Oct 2016 10:31:15 +0200
Subject: [lustre-devel]
 linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973: always
 false test ?
In-Reply-To: <VI1PR08MB1022232C214C9435587602379CD00@VI1PR08MB1022.eurprd08.prod.outlook.com>
References: <VI1PR08MB1022232C214C9435587602379CD00@VI1PR08MB1022.eurprd08.prod.outlook.com>
Message-ID: <20161017083115.GA28881@kroah.com>
List-Id: <lustre-devel-lustre.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: David Binderman <dcb314@hotmail.com>
Cc: "oleg.drokin@intel.com" <oleg.drokin@intel.com>, "andreas.dilger@intel.com" <andreas.dilger@intel.com>, "jsimmons@infradead.org" <jsimmons@infradead.org>, "lustre-devel@lists.lustre.org" <lustre-devel@lists.lustre.org>, "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>

On Mon, Oct 17, 2016 at 07:33:33AM +0000, David Binderman wrote:
> Hello there,
> 
> 
> 
> linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973]: (style) Checking if unsigned variable 'cli.cl_avail_grant' is less than zero.
> 
> 
> 
> Source code is
> 
> 
> 
> ?? if (cli->cl_avail_grant < 0) {
> 
> 
> 
> Suggest code rework.

Great!  Please send a patch.

thanks,

greg k-h

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758467AbcJQIbR (ORCPT <rfc822;w@1wt.eu>);
        Mon, 17 Oct 2016 04:31:17 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:39406 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1758104AbcJQIbI (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 17 Oct 2016 04:31:08 -0400
Date: Mon, 17 Oct 2016 10:31:15 +0200
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: David Binderman <dcb314@hotmail.com>
Cc: "oleg.drokin@intel.com" <oleg.drokin@intel.com>,
        "andreas.dilger@intel.com" <andreas.dilger@intel.com>,
        "jsimmons@infradead.org" <jsimmons@infradead.org>,
        "lustre-devel@lists.lustre.org" <lustre-devel@lists.lustre.org>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re:
 linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973: always
 false test ?
Message-ID: <20161017083115.GA28881@kroah.com>
References: <VI1PR08MB1022232C214C9435587602379CD00@VI1PR08MB1022.eurprd08.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <VI1PR08MB1022232C214C9435587602379CD00@VI1PR08MB1022.eurprd08.prod.outlook.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 17, 2016 at 07:33:33AM +0000, David Binderman wrote:
> Hello there,
> 
> 
> 
> linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973]: (style) Checking if unsigned variable 'cli.cl_avail_grant' is less than zero.
> 
> 
> 
> Source code is
> 
> 
> 
>    if (cli->cl_avail_grant < 0) {
> 
> 
> 
> Suggest code rework.

Great!  Please send a patch.

thanks,

greg k-h