From: Christoph Hellwig <hch@infradead.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Dave Chinner <david@fromorbit.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: Fix uninitialized variable in xfs_reflink_reserve_cow_range()
Date: Mon, 17 Oct 2016 05:08:43 -0700 [thread overview]
Message-ID: <20161017120843.GA9906@infradead.org> (raw)
In-Reply-To: <1476699404-5977-1-git-send-email-geert@linux-m68k.org>
On Mon, Oct 17, 2016 at 12:16:44PM +0200, Geert Uytterhoeven wrote:
> with gcc 4.1.2:
>
> fs/xfs/xfs_reflink.c: In function ‘xfs_reflink_reserve_cow_range’:
> fs/xfs/xfs_reflink.c:327: warning: ‘error’ may be used uninitialized in this function
>
> Indeed, if "count" is zero, the function will return an uninitialized
> error value.
>
> While "count" is unlikely to be zero, this function is called through
> the public iomap API. Hence fix this by preinitializing error to zero.
The iomap API should never call in with a zero count, but I think the
initialization is a fine safety net anyway:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Btw, what compiler did you get this from? I haven't seen it, but then
again I recently missed a lot of initializers without compiler warnings,
so either something changed in the Debian stable gcc or our build
system recently..
next prev parent reply other threads:[~2016-10-17 12:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 10:16 [PATCH] xfs: Fix uninitialized variable in xfs_reflink_reserve_cow_range() Geert Uytterhoeven
2016-10-17 12:08 ` Christoph Hellwig [this message]
2016-10-17 12:13 ` Geert Uytterhoeven
2016-10-17 18:36 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161017120843.GA9906@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.