Re: [PATCH] staging: greybus: es2: Use kmemdup instead of kmalloc and memcpy

[Johan Hovold <johan@kernel.org>]

[+CC: staging list ]

On Sun, Oct 16, 2016 at 02:19:48PM +0530, sayli karnik wrote:
> This patch replaces kmalloc and memcpy with kmemdup for duplication of
> memory.
> 
> Signed-off-by: sayli karnik <karniksayli1995@gmail.com>

Acked-by: Johan Hovold <johan@kernel.org>

> ---
>  drivers/staging/greybus/es2.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/greybus/es2.c b/drivers/staging/greybus/es2.c
> index 071bb1c..8eabc71 100644
> --- a/drivers/staging/greybus/es2.c
> +++ b/drivers/staging/greybus/es2.c
> @@ -175,10 +175,9 @@ static int output_sync(struct es2_ap_dev *es2, void *req, u16 size, u8 cmd)
>  	u8 *data;
>  	int retval;
>  
> -	data = kmalloc(size, GFP_KERNEL);
> +	data = kmemdup(req, size, GFP_KERNEL);
>  	if (!data)
>  		return -ENOMEM;
> -	memcpy(data, req, size);
>  
>  	retval = usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
>  				 cmd,

Thanks,
Johan