Re: [PATCH v2] staging: vc04_services: vchiq_arm: Use ARRAY_SIZE macro

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Mon, Oct 17, 2016 at 08:42:31PM +0530, sayli karnik wrote:
> On Mon, Oct 17, 2016 at 1:04 PM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Sun, Oct 16, 2016 at 07:00:51PM +0530, sayli karnik wrote:
> >> This patch uses ARRAY_SIZE macro instead of division of two sizeofs to
> >> find array size.
> >> Done using coccinelle.
> >> @@
> >> type T;
> >> T[] E;
> >> @@
> >> (
> >> - (sizeof(E)/sizeof(*E))
> >> + ARRAY_SIZE(E)
> >> |
> >> - (sizeof(E)/sizeof(E[...]))
> >> + ARRAY_SIZE(E)
> >> |
> >> - (sizeof(E)/sizeof(T))
> >> + ARRAY_SIZE(E)
> >> )
> >>
> >> Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
> >> ---
> >> Changes in v2:
> >> Adjusted the changed part in one line
> >>
> >>  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 +--
> >>  1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> >> index 5ec7c96..7fee140 100644
> >> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> >> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> >> @@ -190,8 +190,7 @@ static const char *const ioctl_names[] = {
> >>       "CLOSE_DELIVERED"
> >>  };
> >>
> >> -vchiq_static_assert((sizeof(ioctl_names)/sizeof(ioctl_names[0])) ==
> >> -     (VCHIQ_IOC_MAX + 1));
> >> +vchiq_static_assert(ARRAY_SIZE(ioctl_names) == (VCHIQ_IOC_MAX + 1));
> >
> > How were you able to test build this change?  The code is currently
> > broken in the build unless you add a number of external patches at the
> > moment :(
> >
> Yes it is broken.
> Also there isn't a Makefile in
> drivers/staging/vc04_services/interface/vchiq_arm/ to build it.

That's ok, the Makefile a few directories up from that is the one that
builds it.

I'm going to hold off applying this patch until you can test-build it.

thanks,

greg k-h