From: Eduardo Habkost <ehabkost@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Anthony Green <green@moxielogic.com>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,
Max Filippov <jcmvbkbc@gmail.com>,
Greg Ungerer <gerg@uclinux.org>,
Guan Xuetao <gxt@mprc.pku.edu.cn>, Jia Liu <proljc@gmail.com>,
Markus Armbruster <armbru@redhat.com>,
Bharata B Rao <bharata@linux.vnet.ibm.com>,
David Gibson <david@gibson.dropbear.id.au>,
Artyom Tarasenko <atar4qemu@gmail.com>,
Chen Gang <gang.chen.5i5j@gmail.com>, Greg Kurz <groug@kaod.org>,
qemu-arm@nongnu.org, Igor Mammedov <imammedo@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Matthew Rosato <mjrosato@linux.vnet.ibm.com>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Michael Walle <michael@walle.cc>,
qemu-ppc@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-arm] [PATCH v3 1/3] exec: split cpu_exec_init()
Date: Mon, 17 Oct 2016 16:46:57 -0200 [thread overview]
Message-ID: <20161017184657.GY3275@thinpad.lan.raisama.net> (raw)
In-Reply-To: <1476485569-6744-2-git-send-email-lvivier@redhat.com>
On Sat, Oct 15, 2016 at 12:52:47AM +0200, Laurent Vivier wrote:
> Put in cpu_exec_initfn() what initializes the CPU,
> and let in cpu_exec_init() what adds it to the environment.
>
> As cpu_exec_initfn() is called by all XX_cpu_initfn() call it
> directly in cpu_common_initfn().
> cpu_exec_init() is now a realize function, it will be renamed
> to cpu_exec_realizefn() and moved to the XX_cpu_realizefn()
> function in a following patch.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Confirmed that:
* cpu->num_ases and cpu->as are never changed by architecture
code before calling cpu_exec_init()
* cpu_exec_exit() is called on cpu_common_finalize()
* The cpu->memory reference will be dropped automatically
because the property is registered using
OBJ_PROP_LINK_UNREF_ON_RELEASE
BTW, the cpu->as and cpu->num_ases lines are redundant, because
QOM objects are guaranteed to be zeroed when allocated.
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
next prev parent reply other threads:[~2016-10-17 19:26 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 22:52 [Qemu-arm] [PATCH v3 0/3] Split cpu_exec_init() into an init and a realize part Laurent Vivier
2016-10-14 22:52 ` [Qemu-arm] [PATCH v3 1/3] exec: split cpu_exec_init() Laurent Vivier
2016-10-17 3:43 ` David Gibson
2016-10-17 11:15 ` Igor Mammedov
2016-10-17 18:46 ` Eduardo Habkost [this message]
2016-10-14 22:52 ` [Qemu-arm] [PATCH v3 2/3] exec: rename cpu_exec_init() as cpu_exec_realizefn() Laurent Vivier
2016-10-17 3:43 ` [Qemu-devel] " David Gibson
2016-10-17 11:20 ` [Qemu-arm] " Igor Mammedov
2016-10-17 14:03 ` Eduardo Habkost
2016-10-17 14:25 ` Laurent Vivier
2016-10-17 19:20 ` Eduardo Habkost
2016-10-18 10:48 ` Igor Mammedov
2016-10-18 13:00 ` [Qemu-arm] [Qemu-devel] " Andrew Jones
2016-10-18 13:18 ` Eduardo Habkost
2016-10-18 14:22 ` Andrew Jones
2016-10-18 15:22 ` [Qemu-arm] " Eduardo Habkost
2016-10-18 16:22 ` Andrew Jones
2016-10-18 16:57 ` [Qemu-arm] " Laurent Vivier
2016-10-18 17:07 ` Peter Maydell
2016-10-18 17:57 ` Andrew Jones
2016-10-18 18:12 ` Peter Maydell
2016-10-18 18:45 ` [Qemu-arm] QOM properties vs C functions/fields (was Re: [Qemu-devel] [PATCH v3 2/3] exec: rename cpu_exec_init() as cpu_exec_realizefn()) Eduardo Habkost
2016-10-18 18:45 ` [Qemu-devel] QOM properties vs C functions/fields (was " Eduardo Habkost
2016-10-18 20:30 ` [Qemu-arm] QOM properties vs C functions/fields (was Re: [Qemu-devel] " Peter Maydell
2016-10-18 20:30 ` [Qemu-devel] QOM properties vs C functions/fields (was " Peter Maydell
2016-10-18 20:49 ` [Qemu-arm] QOM properties vs C functions/fields (was Re: [Qemu-devel] " Eduardo Habkost
2016-10-18 20:49 ` [Qemu-devel] QOM properties vs C functions/fields (was " Eduardo Habkost
2016-10-18 21:08 ` Peter Maydell
2016-10-18 21:08 ` [Qemu-arm] QOM properties vs C functions/fields (was Re: [Qemu-devel] " Peter Maydell
2016-10-19 11:11 ` Eduardo Habkost
2016-10-19 11:11 ` [Qemu-devel] QOM properties vs C functions/fields (was " Eduardo Habkost
2016-10-19 11:22 ` [Qemu-arm] QOM properties vs C functions/fields (was Re: [Qemu-devel] " Peter Maydell
2016-10-19 11:22 ` [Qemu-devel] QOM properties vs C functions/fields (was " Peter Maydell
2016-10-21 18:26 ` [Qemu-arm] " Markus Armbruster
2016-10-22 9:31 ` Peter Maydell
2016-10-24 7:24 ` Markus Armbruster
2016-10-14 22:52 ` [Qemu-arm] [PATCH v3 3/3] exec: call cpu_exec_exit() from a CPU unrealize common function Laurent Vivier
2016-10-17 3:43 ` [Qemu-devel] " David Gibson
2016-10-17 11:30 ` Igor Mammedov
2016-10-17 3:44 ` [Qemu-arm] [PATCH v3 0/3] Split cpu_exec_init() into an init and a realize part David Gibson
2016-10-17 18:47 ` Eduardo Habkost
2016-10-17 22:50 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161017184657.GY3275@thinpad.lan.raisama.net \
--to=ehabkost@redhat.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=bharata@linux.vnet.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=gang.chen.5i5j@gmail.com \
--cc=gerg@uclinux.org \
--cc=green@moxielogic.com \
--cc=groug@kaod.org \
--cc=gxt@mprc.pku.edu.cn \
--cc=imammedo@redhat.com \
--cc=jcmvbkbc@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=lvivier@redhat.com \
--cc=michael@walle.cc \
--cc=mjrosato@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=proljc@gmail.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.