From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933231AbcJRCCD (ORCPT ); Mon, 17 Oct 2016 22:02:03 -0400 Received: from mail-pa0-f65.google.com ([209.85.220.65]:35763 "EHLO mail-pa0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932978AbcJRCBv (ORCPT ); Mon, 17 Oct 2016 22:01:51 -0400 Date: Tue, 18 Oct 2016 11:01:09 +0900 From: Namhyung Kim To: Honggyu Kim Cc: linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Steven Rostedt Subject: Re: [PATCH 1/3] tools lib traceevent: Add -O2 option to traceevent Message-ID: <20161018020109.GA6099@danjae.aot.lge.com> References: <20161017141712.11932-1-hong.gyu.kim@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161017141712.11932-1-hong.gyu.kim@lge.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Honggyu, You need to CC relevant maintainers when you send patches to LKML. For the libtraceevent, they are Arnaldo and Steven. You can use scripts/get_maintainer.pl for this job later. In addition running scripts/checkpatch.pl before sending patches is a good habit. Arnaldo and Steve, This is from uftrace building libtraceevent with the optimization flag and we want to fix the upstream as well. Thanks, Namhyung On Mon, Oct 17, 2016 at 11:17:10PM +0900, Honggyu Kim wrote: > Since current traceevent somehow does not have an optimization flag, > this patch just adds -O2 to optimize its code. > > Signed-off-by: Honggyu Kim > --- > tools/lib/traceevent/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile > index 7851df1..56d223b 100644 > --- a/tools/lib/traceevent/Makefile > +++ b/tools/lib/traceevent/Makefile > @@ -124,7 +124,7 @@ else > endif > > # Append required CFLAGS > -override CFLAGS += -fPIC > +override CFLAGS += -O2 -fPIC > override CFLAGS += $(CONFIG_FLAGS) $(INCLUDES) $(PLUGIN_DIR_SQ) > override CFLAGS += $(udis86-flags) -D_GNU_SOURCE > > -- > 2.10.0.rc2.dirty >