All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Jan Blunck <jblunck@infradead.org>
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>,
	"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
	dev@dpdk.org, "Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [PATCH] drivers: make driver names consistent
Date: Tue, 18 Oct 2016 21:06:15 +0800	[thread overview]
Message-ID: <20161018130615.GK16751@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <CALe+Z01WbAER5uynvnU1PUYj1FWXyhxE3cCPc0ivJCu8v7XfbQ@mail.gmail.com>

On Tue, Oct 18, 2016 at 02:50:16PM +0200, Jan Blunck wrote:
> >From my understanding this is a massive API breakage. This forces all
> existing users of the virtual PMDs to change with zero benefit. Even
> if that isn't enough it also makes it impossible to switch between
> releases by recompiling.
> 
> Can we please revert these changes and work on some aliasing support
> for the PMDs to fix it long term?

+1. Aliasing is also something I would suggest before making such renames.

	--yliu
> 
> Thanks,
> Jan
> 
> 
> On Fri, Sep 16, 2016 at 11:58 AM, Thomas Monjalon
> <thomas.monjalon@6wind.com> wrote:
> > 2016-08-24 22:37, Mcnamara, John:
> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> >> >
> >> > ...
> >> >
> >> > -    $RTE_TARGET/app/testpmd -c '0xf' -n 4 --vdev 'eth_pcap0,rx_pcap=/path/to/ file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' -- --port-topology=chained
> >> > +    $RTE_TARGET/app/testpmd -c '0xf' -n 4 --vdev 'net_pcap0,rx_pcap=/path/to/ file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' -- --port-topology=chained
> >>
> >>
> >> I know that this is an existing issue but there shouldn't be a space in
> >> "/path/to/ file". Perhaps you could fix that (in a number of places) as part
> >> of this patch. You could probably leave out the "/path/to/" part altogether as
> >> it may be clearer, see below.
> >>
> >> Also, could you wrap the long code lines in the sections that you change at
> >> 80 chars using "\" to keep them on the page in the PDF docs, like:
> >>
> >>     $RTE_TARGET/app/testpmd -c '0xf' -n 4 \
> >>         --vdev 'net_pcap0,rx_pcap=/path/to/file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' \
> >>         -- --port-topology=chained
> >>
> >> Or without the path part:
> >>
> >>     $RTE_TARGET/app/testpmd -c '0xf' -n 4 \
> >>         --vdev 'net_pcap0,rx_pcap=file_rx.pcap,tx_pcap=file_tx.pcap' \
> >>         -- --port-topology=chained
> >
> > Applied with above comments fixed and release notes updated, thanks.

  reply	other threads:[~2016-10-18 13:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-24 22:24 [PATCH] drivers: make driver names consistent Pablo de Lara
2016-08-24 22:27 ` De Lara Guarch, Pablo
2016-08-24 22:37 ` Mcnamara, John
2016-09-16  9:58   ` Thomas Monjalon
2016-10-18 12:50     ` Jan Blunck
2016-10-18 13:06       ` Yuanhan Liu [this message]
2016-10-18 13:42         ` Thomas Monjalon
2016-10-18 14:18           ` Yuanhan Liu
2016-10-18 16:46             ` Thomas Monjalon
2016-10-19 10:05               ` Yuanhan Liu
2016-10-19 12:26                 ` Thomas Monjalon
2016-10-18 15:26           ` Jan Blunck
2016-10-18 16:45             ` Thomas Monjalon
2016-10-19 13:32             ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161018130615.GK16751@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=dev@dpdk.org \
    --cc=jblunck@infradead.org \
    --cc=john.mcnamara@intel.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.